From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40A2C83F17 for ; Thu, 10 Jul 2025 14:07:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30CEB6B0088; Thu, 10 Jul 2025 10:07:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BDBD6B008A; Thu, 10 Jul 2025 10:07:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 185146B008C; Thu, 10 Jul 2025 10:07:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07B716B0088 for ; Thu, 10 Jul 2025 10:07:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8E66F56E49 for ; Thu, 10 Jul 2025 14:07:03 +0000 (UTC) X-FDA: 83648531526.03.1C7C0DF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 81EFD20002 for ; Thu, 10 Jul 2025 14:07:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=szIJjEgR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752156421; a=rsa-sha256; cv=none; b=3KWots63egxq9tfBHZcGhECDcBbDVvoqgeGcONXknf1yu6OeiJhugcWkD4eAIez4S0SC4W hePFGg2XnkZJYWU8uVueJEBRSRZ9tdG3Y76ObcEubwA+2tKY0dLGfJIpsqeHvSwy8S8BsY qGnLcAEMIQvSEwgy9c6dwDtVi2n4vxI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=szIJjEgR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752156421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D1vFCnBEMjFTgl4EUV6U2jtUrHi2Leh7Nmt4I0Hr/TY=; b=I5HGyTWUyvjgEkYba8Q89RbNnga8cOLoZs5JUjF8WC+ERT8E3PnKa+Led6TUoRiefl53Nt 1QeGxLgHIMSYYeUe+DXWQhBG2ON59ZgW9G1WEsZyloLcC/cihPFGCIB2l/LWURV+coQboR gZ+MvYIjqJc+oNJ7HIxUJ5xYaaAgGHE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 783855C6DE7; Thu, 10 Jul 2025 14:07:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 408CCC4CEF7; Thu, 10 Jul 2025 14:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752156420; bh=ABfxzpvxT3fMn5d7wTwVUf6gA1c4LfSNhVMHRzk59U4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=szIJjEgRmjZXBA7w00LoaEMswgW9tV2ZWszKrNHExUNolE1/O9L7ce36i8AXAyWi3 Kb5iI6hvAIoEkv7ShZpRX9kqwa3FIAtwL/iIDbYq4U3krJCVU0xxzwNsOcvGi1IuLd t9qnh6vJQmPWrIJk9RBPnHRPkteL3SZ5XREHPrbrLVj3uWn9NW/A2wQYNhr1F5V9EV X5HDWDA1DZuxmUeAID3QznnAsp+LRvAoPhHi0XVUDkTS5G69EQu1DEjlzxacD6o8H+ 3Op8A1+tfCmNw+xCSukqJWSrN192o2cJOJMrGT3b2ZfEwFXdMSp5FpxCaJgRbBKTV8 oES435lRhZM8Q== Message-ID: Subject: Re: [RFC PATCH v2 6/8] NFSD: add io_cache_read controls to debugfs interface From: Jeff Layton To: Mike Snitzer , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linus-fsdevel@vger.kernel.org, linux-mm@kvack.org Date: Thu, 10 Jul 2025 10:06:58 -0400 In-Reply-To: <20250708160619.64800-7-snitzer@kernel.org> References: <20250708160619.64800-1-snitzer@kernel.org> <20250708160619.64800-7-snitzer@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) MIME-Version: 1.0 X-Rspamd-Queue-Id: 81EFD20002 X-Stat-Signature: nj38bqakpegz4uawr38zz1sx6gwsgei3 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1752156421-578256 X-HE-Meta: U2FsdGVkX18tKhMU7lzzf6qwjuU+DS5c1J4Yt4MYOr4SpaWcyTg1mX9YC0w39sKfVsMiYFZwWkDg0dKu3x65efBGgTtu+jMkfnzx5IrNmRg1qP9dq18y8rYPVS9OlFBg6hi8MkjlhyGUk1JnmobkDa6+NzHbuuA2CWrPepmWIZL/Pp60I5xp3t0oO7KArH7L5sZPnt8emq/HPlNbZ+ZVNqKAbuzB+zS2fitSgRBOIDZxj1gvOxo3GDrlZJC2srOBECh6f4XI7Lj8aEpMVfOGcPaMjl41K0Z55ySlWL84e+Z5GIUHS4RAaajl/+EwFcHJ1Y6rGtpPiHv8STzl89vwHaaNhO2jFHqrTCuR4tQL7lyjr4uMS1vbmKdpsY5xg6NHfG7V4LeRykczyEnvAEvwMHBIyJ8q9uduYafSkFwvZtnXU06oZC4fTNsd4R/mO/ZvYkCKcbhj1zYwIzd0xtIbwFXGqgkmjSGojgOvq1MpoQTeDdpEZjpvMyTmM24d2H7H7PZcKLoBJqQTPvWe4VgycUg8lw5D83k/Grdjrq1Lbz8fZkSSAImGd5VREkbTHIiZKRFyYGxx6AECCPDqaHhRUxAQDaEqt4/ig/bLgseoTf5PJBn+H0Tpd/b1DuSF55Dn+bI/T01/w+uKZKKUDbzVaQKxqlTtTdqq8+aFaXU6NmH0y2lTkawG070uw/yDRJsOlnUzheiZbFIhyFiEIIwF4ed2GNioZqhhtqettHpqITmiGl8MUGnUw4BXCQ6ZLBo0L8lFONJWhj8qvgRb+KzGRdcp6AzBxLaaBQusVhlHmUclaBearU8UewShd3bfa5Ur+Kyt/iPZ2+F2ORbYt+d54+pBhI6wyIkRdpjduGE68C4cPwzJKzahZ7PUZ6r/9rWJ0mBSdQjxbJYWmps5emFQR4y3wOsdVC+Z9tSvihy5ilm8lcg0cppzceoIjRy3C/Cy+Q/7B0qv8w2hoqYL34H 16HBz7Ym WNyCrSinZDyCFNKmrrMhrOpGmC9+qYehHEAam8jTIp9SZ1j5IKcSei+O+yNbVWTznxPBTKFy1thAAsVIS+8REKDqHz8UA5KhD0SOg1QDnZ3n0WIfeOjp7aojf2LrqLwbLR0008bILadNHtFaHWjRihl4uDYtAwz2vku9y3LWSf1vfCQ1dcWgmYjSeEYMtCo9MHI09FEUDMhK/RSOc8A7xxLZ+WBxxd4WmeX0Dh+rMCt1TjU9abLtq6MCnlNrzRtkbFq1ASRVGVGLzEPZhkbK6LrJUN0yOx9UN48LwuMjPkmdESgcj5/iO04L+vd0DeE8b8TbU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-07-08 at 12:06 -0400, Mike Snitzer wrote: > Add 'io_cache_read' to NFSD's debugfs interface so that: Any data > read by NFSD will either be: > - cached using page cache (NFSD_IO_BUFFERED=3D0) > - cached but removed from the page cache upon completion > (NFSD_IO_DONTCACHE=3D1). > - not cached (NFSD_IO_DIRECT=3D2) >=20 > io_cache_read is 0 by default. It may be set by writing to: > /sys/kernel/debug/nfsd/io_cache_read >=20 > If NFSD_IO_DONTCACHE is specified using 1, FOP_DONTCACHE must be > advertised as supported by the underlying filesystem (e.g. XFS), > otherwise all IO flagged with RWF_DONTCACHE will fail with > -EOPNOTSUPP. >=20 > If NFSD_IO_DIRECT is specified using 2, the IO must be aligned > relative to the underlying block device's logical_block_size. Also the > memory buffer used to store the read must be aligned relative to the > underlying block device's dma_alignment. >=20 > Signed-off-by: Mike Snitzer > --- > fs/nfsd/debugfs.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++ > fs/nfsd/nfsd.h | 8 +++++++ > fs/nfsd/vfs.c | 15 ++++++++++++++ > 3 files changed, 76 insertions(+) >=20 > diff --git a/fs/nfsd/debugfs.c b/fs/nfsd/debugfs.c > index 84b0c8b559dc..709646af797a 100644 > --- a/fs/nfsd/debugfs.c > +++ b/fs/nfsd/debugfs.c > @@ -27,11 +27,61 @@ static int nfsd_dsr_get(void *data, u64 *val) > static int nfsd_dsr_set(void *data, u64 val) > { > nfsd_disable_splice_read =3D (val > 0) ? true : false; > + if (!nfsd_disable_splice_read) { > + /* > + * Cannot use NFSD_IO_DONTCACHE or NFSD_IO_DIRECT > + * if splice_read is enabled. > + */ > + nfsd_io_cache_read =3D NFSD_IO_BUFFERED; > + } > return 0; > } > =20 > DEFINE_DEBUGFS_ATTRIBUTE(nfsd_dsr_fops, nfsd_dsr_get, nfsd_dsr_set, "%ll= u\n"); > =20 > +/* > + * /sys/kernel/debug/nfsd/io_cache_read > + * > + * Contents: > + * %0: NFS READ will use buffered IO (default) > + * %1: NFS READ will use dontcache (buffered IO w/ dropbehind) > + * %2: NFS READ will use direct IO > + * > + * The default value of this setting is zero (buffered IO is > + * used). This setting takes immediate effect for all NFS > + * versions, all exports, and in all NFSD net namespaces. > + */ > + Could we switch this to use a string instead? Maybe buffered/dontcache/direct ? > +static int nfsd_io_cache_read_get(void *data, u64 *val) > +{ > + *val =3D nfsd_io_cache_read; > + return 0; > +} > + > +static int nfsd_io_cache_read_set(void *data, u64 val) > +{ > + switch (val) { > + case NFSD_IO_DONTCACHE: > + case NFSD_IO_DIRECT: > + /* > + * Must disable splice_read when enabling > + * NFSD_IO_DONTCACHE or NFSD_IO_DIRECT. > + */ > + nfsd_disable_splice_read =3D true; > + nfsd_io_cache_read =3D val; > + break; > + case NFSD_IO_BUFFERED: > + default: > + nfsd_io_cache_read =3D NFSD_IO_BUFFERED; > + break; I think the default case should leave nfsd_io_cache_read alone and return an error. If we add new values later, and someone tries to use them on an old kernel, it's better to make that attempt error out. Ditto for the write side controls. > + } > + > + return 0; > +} > + > +DEFINE_DEBUGFS_ATTRIBUTE(nfsd_io_cache_read_fops, nfsd_io_cache_read_get= , > + nfsd_io_cache_read_set, "%llu\n"); > + > void nfsd_debugfs_exit(void) > { > debugfs_remove_recursive(nfsd_top_dir); > @@ -44,4 +94,7 @@ void nfsd_debugfs_init(void) > =20 > debugfs_create_file("disable-splice-read", S_IWUSR | S_IRUGO, > nfsd_top_dir, NULL, &nfsd_dsr_fops); > + > + debugfs_create_file("io_cache_read", S_IWUSR | S_IRUGO, > + nfsd_top_dir, NULL, &nfsd_io_cache_read_fops); > } > diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h > index 1cd0bed57bc2..4740567f4e7e 100644 > --- a/fs/nfsd/nfsd.h > +++ b/fs/nfsd/nfsd.h > @@ -153,6 +153,14 @@ static inline void nfsd_debugfs_exit(void) {} > =20 > extern bool nfsd_disable_splice_read __read_mostly; > =20 > +enum { > + NFSD_IO_BUFFERED =3D 0, > + NFSD_IO_DONTCACHE, > + NFSD_IO_DIRECT > +}; > + > +extern u64 nfsd_io_cache_read __read_mostly; > + > extern int nfsd_max_blksize; > =20 > static inline int nfsd_v4client(struct svc_rqst *rq) > diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c > index 845c212ad10b..632ce417f4ef 100644 > --- a/fs/nfsd/vfs.c > +++ b/fs/nfsd/vfs.c > @@ -49,6 +49,7 @@ > #define NFSDDBG_FACILITY NFSDDBG_FILEOP > =20 > bool nfsd_disable_splice_read __read_mostly; > +u64 nfsd_io_cache_read __read_mostly; > =20 > /** > * nfserrno - Map Linux errnos to NFS errnos > @@ -1107,6 +1108,20 @@ __be32 nfsd_iter_read(struct svc_rqst *rqstp, stru= ct svc_fh *fhp, > =20 > trace_nfsd_read_vector(rqstp, fhp, offset, *count); > iov_iter_bvec(&iter, ITER_DEST, rqstp->rq_bvec, v, *count); > + > + switch (nsfd_io_cache_read) { > + case NFSD_IO_DIRECT: > + if (iov_iter_is_aligned(&iter, nf->nf_dio_mem_align - 1, > + nf->nf_dio_read_offset_align - 1)) > + kiocb.ki_flags =3D IOCB_DIRECT; > + break; > + case NFSD_IO_DONTCACHE: > + kiocb.ki_flags =3D IOCB_DONTCACHE; > + break; > + case NFSD_IO_BUFFERED: > + break; > + } > + > host_err =3D vfs_iocb_iter_read(file, &kiocb, &iter); > return nfsd_finish_read(rqstp, fhp, file, offset, count, eof, host_err)= ; > } --=20 Jeff Layton