From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26199C4320A for ; Mon, 16 Aug 2021 19:58:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB27360F55 for ; Mon, 16 Aug 2021 19:58:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB27360F55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 66BFC8D0011; Mon, 16 Aug 2021 15:58:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61C1E8D0001; Mon, 16 Aug 2021 15:58:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50A8A8D0011; Mon, 16 Aug 2021 15:58:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 347148D0001 for ; Mon, 16 Aug 2021 15:58:21 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DCBB821977 for ; Mon, 16 Aug 2021 19:58:20 +0000 (UTC) X-FDA: 78482005560.33.C14B650 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id 7DB5CF005EF6 for ; Mon, 16 Aug 2021 19:58:20 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F13460EE0; Mon, 16 Aug 2021 19:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629143899; bh=5wImwEA4LceS/v2yccDrveV86vmFgqlIhTO0p5YqI+E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tK44WrZy7HVD/dqDLplgG2kQIELyUNEAWk9lUdHHIDsaDrdicE6j9gFEJDpAV7fmh 5cpPDy+rdGrr8p8Ggyf1w2MUT8uQAxXATrnpimS9Pn4HdZ1zweol2drl0LXv496vPO uZm7l1D1tIOq4dIHyDejJvuaggpLzE4EDgDmqzVwPRDlPvP95+15z3c1rTyRZORol8 ztPgUxAAen30b09rjiN0UrHuAdZPdRSO24FcmRmELamdgDR4u6Vr7T890B2miDC2Zp V/9jhJalVX10mFzbAKZ2f2hJ3ibfR4SUzu8Bea3khc8oigbV7lagOjb9Xz6XMVm6Ic W5K757zWktooA== Subject: Re: [PATCH v2 00/19] ARC mm updates: support 3/4 levels and asm-generic/pgalloc To: Mike Rapoport , Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual References: <20210812233753.104217-1-vgupta@kernel.org> From: Vineet Gupta Message-ID: Date: Mon, 16 Aug 2021 12:58:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tK44WrZy; spf=pass (imf16.hostedemail.com: domain of vgupta@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=vgupta@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7DB5CF005EF6 X-Stat-Signature: fu5w1e6d1fcs47kbz3h6ho4xm73bkzdm X-HE-Tag: 1629143900-468804 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/15/21 2:26 AM, Mike Rapoport wrote: > On Thu, Aug 12, 2021 at 04:37:34PM -0700, Vineet Gupta wrote: >> Hi, >> >> Big pile of ARC mm changes to prepare for 3 or 4 levels of paging (from >> current 2) needed for new hardware page walked MMUv6 (in aRCv3 ISA based >> cores). >> >> Most of these changes are incremental cleanups to make way for 14/18 and >> 15/18 which actually imeplement the new levels (in existing ARCv2 port) >> and worth a critical eye. >> >> CC'ing some of you guys dealing with page tables for a while :-) >> to spot any obvious gotchas. > There are a couple of small nits here and there, but overall I've fixed the last remaining things locally and won't repost, unless you want me to. > > Acked-by: Mike Rapoport Thx for spending time to review this Mike. Much appreciated. -Vineet > >> Thx, >> -Vineet >> >> Changes since v1 [1] >> - Switched ARC to asm-generic/pgalloc.h (so struct page based pgtable_t) [Mike Rapoport] >> - Dropped {pud,pmd}_alloc_one/{pud,pmd}_free provided by asm-generic/pgalloc.h [Mike Rapoport] >> - Negative diffstat now due to above >> - Added BUILD_BUG_ON() to arch/arc/mm/init.c for sanity of table sizes >> - Consolidated 2 patches related to ARC_USE_SCRATCH_REG [Mike Rapoport] >> - Reworked how mmu is re-enabled in entry code [Jose Abreu] >> >> [1] http://lists.infradead.org/pipermail/linux-snps-arc/2021-August/005326.html >> >> Vineet Gupta (19): >> ARC: mm: use SCRATCH_DATA0 register for caching pgdir in ARCv2 only >> ARC: mm: remove tlb paranoid code >> ARC: mm: move mmu/cache externs out to setup.h >> ARC: mm: Fixes to allow STRICT_MM_TYPECHECKS >> ARC: mm: Enable STRICT_MM_TYPECHECKS >> ARC: ioremap: use more commonly used PAGE_KERNEL based uncached flag >> ARC: mm: pmd_populate* to use the canonical set_pmd (and drop pmd_set) >> ARC: mm: switch pgtable_t back to struct page * >> ARC: mm: switch to asm-generic/pgalloc.h >> ARC: mm: non-functional code cleanup ahead of 3 levels >> ARC: mm: move MMU specific bits out of ASID allocator >> ARC: mm: move MMU specific bits out of entry code ... >> ARC: mm: disintegrate mmu.h (arcv2 bits out) >> ARC: mm: disintegrate pgtable.h into levels and flags >> ARC: mm: hack to allow 2 level build with 4 level code >> ARC: mm: support 3 levels of page tables >> ARC: mm: support 4 levels of page tables >> ARC: mm: vmalloc sync from kernel to user table to update PMD ... >> ARC: mm: introduce _PAGE_TABLE to explicitly link pgd,pud,pmd entries >> >> arch/arc/Kconfig | 7 +- >> arch/arc/include/asm/cache.h | 4 - >> arch/arc/include/asm/entry-compact.h | 8 - >> arch/arc/include/asm/mmu-arcv2.h | 103 +++++++ >> arch/arc/include/asm/mmu.h | 73 +---- >> arch/arc/include/asm/mmu_context.h | 28 +- >> arch/arc/include/asm/page.h | 74 +++-- >> arch/arc/include/asm/pgalloc.h | 81 ++---- >> arch/arc/include/asm/pgtable-bits-arcv2.h | 151 +++++++++++ >> arch/arc/include/asm/pgtable-levels.h | 179 ++++++++++++ >> arch/arc/include/asm/pgtable.h | 315 +--------------------- >> arch/arc/include/asm/processor.h | 2 +- >> arch/arc/include/asm/setup.h | 12 +- >> arch/arc/kernel/entry-arcv2.S | 1 + >> arch/arc/kernel/entry.S | 7 +- >> arch/arc/mm/fault.c | 20 +- >> arch/arc/mm/init.c | 5 + >> arch/arc/mm/ioremap.c | 3 +- >> arch/arc/mm/tlb.c | 68 +---- >> arch/arc/mm/tlbex.S | 78 ++---- >> 20 files changed, 591 insertions(+), 628 deletions(-) >> create mode 100644 arch/arc/include/asm/mmu-arcv2.h >> create mode 100644 arch/arc/include/asm/pgtable-bits-arcv2.h >> create mode 100644 arch/arc/include/asm/pgtable-levels.h >> >> -- >> 2.25.1 >>