From: Shuah Khan <skhan@linuxfoundation.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Sean Young <sean@mess.org>
Cc: kernel test robot <oliver.sang@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
lkp@lists.01.org, kbuild test robot <lkp@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail
Date: Fri, 28 Jan 2022 10:27:52 -0700 [thread overview]
Message-ID: <e5b72f09-a208-a579-3e51-10935ccee1ff@linuxfoundation.org> (raw)
In-Reply-To: <CAADnVQJ3RCPUQ0k9nu2urrRK=U7SUetuPmY0_b17M_PD=j4fkw@mail.gmail.com>
On 1/28/22 9:49 AM, Alexei Starovoitov wrote:
> On Fri, Jan 28, 2022 at 1:32 AM Sean Young <sean@mess.org> wrote:
>>
>>> ir_loopback.c: In function ‘main’:
>>> ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’?
>>> if (rc_proto == RC_PROTO_RCMM32 &&
>>> ^~~~~~~~~~~~~~~
>>> RC_PROTO_RC6_MCE
>>
>> So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h,
>> so now the test uses /usr/include/linux/lirc.h. It appears that this file
>> does not have RC_PROTO_RCMM32 defined on this system, which means it is a
>> kernel header from v5.1 or earlier (this was added in commit
>> 721074b03411327e7bf41555d4cc7c18f49313f7).
>>
>> It looks like this machine is redhat 8.3, which ships with kernel 4.18.
>>
>> I guess my change was far too optimistic; I had no ideal enterprise kernels
>> were so ancient.
>>
>> We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. Sorry about
>> the turbulence.
>
> I'd rather avoid reverting.
> Just add ifdef or something to shut up the error on old distros.
>
Sean,
Let's not add release checks.
Since RC_PROTO_RCMM32 is the only one missing, perhaps you could define
just that one in ir_loopback.c with a comment that it can be removed.
ifndef RC_PROTO_RCMM32 ---
thanks,
-- Shuah
next prev parent reply other threads:[~2022-01-28 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 7:53 [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail kernel test robot
2022-01-28 9:31 ` Sean Young
2022-01-28 16:49 ` Alexei Starovoitov
2022-01-28 17:27 ` Shuah Khan [this message]
2022-01-28 17:38 ` Sean Young
2022-01-28 17:57 ` Shuah Khan
2022-02-01 16:51 ` Sean Young
2022-02-01 16:53 ` [PATCH] selftests/ir: fix build with ancient kernel headers Sean Young
2022-02-01 16:58 ` Matthew Wilcox
2022-02-01 17:10 ` Sean Young
2022-02-01 17:42 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b72f09-a208-a579-3e51-10935ccee1ff@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=oliver.sang@intel.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).