From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Kiryl Shutsemau <kirill@shutemov.name>,
akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
rppt@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, usama.anjum@arm.com,
usama.arif@linux.dev, nico.pache@linux.dev, ziy@nvidia.com,
baohua@kernel.org, dev.jain@arm.com, hughd@google.com,
lance.yang@linux.dev, liam@infradead.org, mhocko@suse.com,
ryan.roberts@arm.com, shuah@kernel.org, surenb@google.com,
vbabka@kernel.org, agordeev@linux.ibm.com, jgg@ziepe.ca,
leon@kernel.org, kernel-team@meta.com,
"Kiryl Shutsemau (Meta)" <kas@kernel.org>
Subject: Re: [PATCH v5 14/19] selftests/mm: run every supported collapse order by default
Date: Thu, 10 Sep 2026 14:07:59 +0800 [thread overview]
Message-ID: <e611ca08-1952-457d-ba45-8c8854020a74@linux.alibaba.com> (raw)
In-Reply-To: <20260908125105.1510704-15-kirill@shutemov.name>
On 9/8/26 8:51 PM, Kiryl Shutsemau wrote:
> From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
>
> The mTHP collapse cases only run when the caller names both the context
> and an order, so a plain ./khugepaged covers the PMD contexts on anon and
> nothing else. run_vmtests.sh pinned order 4 and covered no other.
>
> Run the mTHP cases once per supported anon THP order below the PMD when
> -c is absent, and pull that context into both the no-argument invocation
> and "all". Also:
>
> - -c still pins one order, and now says what is wrong instead of
> printing the usage text. An order at or below the -s source order is
> skipped: the sources would already be the size being asked for.
>
> - Both orders end up as array indices and shift counts, so -s and -c
> are range-checked before they get there.
>
> - The mTHP context has only anon cases, so a run that names a different
> mem_type -- "all:shmem", say -- drops it again rather than refusing
> to start. Naming both explicitly still refuses.
>
> - A case carries the order it was registered at, so a result names it:
>
> # Run test: collapse_single_mthp (mthp_khugepaged:anon, order 6)
>
> On x86-64 with 4K pages that is orders 2 through 8, and ./khugepaged goes
> from 29 results in 17 seconds to 77 in 29, so run_vmtests.sh can drop its
> pinned order-4 line.
>
> Assisted-by: LLM
> Tested-by: Muhammad Usama Anjum <usama.anjum@arm.com>
> Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> ---
LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
next prev parent reply other threads:[~2026-09-10 6:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 12:50 [PATCH v5 00/19] selftests/mm: improve khugepaged coverage Kiryl Shutsemau
2026-09-08 12:50 ` [PATCH v5 01/19] selftests/mm: raise the khugepaged test-case cap Kiryl Shutsemau
2026-09-09 7:42 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 02/19] selftests/mm: skip collapse_compound_extreme() where the PMD is too large Kiryl Shutsemau
2026-09-09 7:51 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 03/19] selftests/mm: scale khugepaged's collapse wait with the PMD size Kiryl Shutsemau
2026-09-09 7:59 ` Baolin Wang
2026-09-09 10:09 ` Kiryl Shutsemau
2026-09-09 10:17 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 04/19] selftests/mm: skip khugepaged page cache cases without a PMD folio Kiryl Shutsemau
2026-09-09 8:21 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 05/19] selftests/mm: make the swap cases' swapout reliable Kiryl Shutsemau
2026-09-09 8:59 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 06/19] selftests/mm: stop khugepaged during the MADV_COLLAPSE cases Kiryl Shutsemau
2026-09-09 9:55 ` Baolin Wang
2026-09-09 10:41 ` Kiryl Shutsemau
2026-09-10 6:27 ` Baolin Wang
2026-09-10 10:59 ` Kiryl Shutsemau
2026-09-10 11:06 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 07/19] selftests/mm: move is_backed_by_folio() into vm_util Kiryl Shutsemau
2026-09-09 9:16 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 08/19] selftests/mm: add folio-order check for address ranges Kiryl Shutsemau
2026-09-09 10:01 ` Baolin Wang
2026-09-10 10:45 ` Kiryl Shutsemau
2026-09-10 11:14 ` Baolin Wang
2026-09-10 13:04 ` Kiryl Shutsemau
2026-09-11 2:50 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 09/19] selftests/mm: add folio-order detection self-check Kiryl Shutsemau
2026-09-08 12:50 ` [PATCH v5 10/19] selftests/mm: add khugepaged completion barrier helper Kiryl Shutsemau
2026-09-10 1:17 ` Baolin Wang
2026-09-08 12:50 ` [PATCH v5 11/19] selftests/mm: add order-parameterized khugepaged collapse cases Kiryl Shutsemau
2026-09-10 4:59 ` Baolin Wang
2026-09-10 10:53 ` Kiryl Shutsemau
2026-09-08 12:50 ` [PATCH v5 12/19] selftests/mm: parameterize the mixed-source collapse case by source order Kiryl Shutsemau
2026-09-10 5:09 ` Baolin Wang
2026-09-10 10:58 ` Kiryl Shutsemau
2026-09-08 12:50 ` [PATCH v5 13/19] selftests/mm: cover a shared-source collapse write race Kiryl Shutsemau
2026-09-08 21:02 ` Kiryl Shutsemau
2026-09-08 12:51 ` [PATCH v5 14/19] selftests/mm: run every supported collapse order by default Kiryl Shutsemau
2026-09-10 6:07 ` Baolin Wang [this message]
2026-09-08 12:51 ` [PATCH v5 15/19] selftests/mm: check that one khugepaged pass collapses one window Kiryl Shutsemau
2026-09-08 12:51 ` [PATCH v5 16/19] selftests/mm: add khugepaged race harness Kiryl Shutsemau
2026-09-08 21:34 ` Kiryl Shutsemau
2026-09-08 12:51 ` [PATCH v5 17/19] selftests/mm: race the collapse of windows with holes Kiryl Shutsemau
2026-09-08 12:51 ` [PATCH v5 18/19] selftests/mm: add memory-pressure threads to the khugepaged race harness Kiryl Shutsemau
2026-09-08 12:51 ` [PATCH v5 19/19] selftests/mm: zap whole PTE tables in " Kiryl Shutsemau
2026-09-08 19:41 ` [PATCH v5 00/19] selftests/mm: improve khugepaged coverage Andrew Morton
2026-09-08 21:36 ` Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e611ca08-1952-457d-ba45-8c8854020a74@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=kirill@shutemov.name \
--cc=lance.yang@linux.dev \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.anjum@arm.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox