From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Oleg Nesterov <oleg@redhat.com>, Gregory Price <gourry@gourry.net>
Cc: Ye Liu <ye.liu@linux.dev>, Thomas Gleixner <tglx@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
Josh Triplett <josh@joshtriplett.org>,
"Uladzislau Rezki" <urezki@gmail.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>, Ye Liu <liuye@kylinos.cn>,
Michal Hocko <mhocko@suse.com>, <mic@digikod.net>,
<david@kernel.org>, <linmiaohe@huawei.com>,
<nao.horiguchi@gmail.com>, <gnoack3000@gmail.com>,
<ljs@kernel.org>, <sj@kernel.org>, <rientjes@google.com>,
<shakeel.butt@linux.dev>, <xu.xin16@zte.com.cn>,
<chengming.zhou@linux.dev>, <tony.luck@intel.com>,
<reinette.chatre@intel.com>, <x86@kernel.org>,
<paul@paul-moore.com>, <jmorris@namei.org>, <serge@hallyn.com>,
<pavel@kernel.org>, <lance.yang@linux.dev>, <pmladek@suse.com>,
<longman@redhat.com>, <mathieu.desnoyers@efficios.com>,
<jiangshanlai@gmail.com>, <qiang.zhang@linux.dev>,
<dietmar.eggemann@arm.com>, <bsegall@google.com>,
<mgorman@suse.de>, <vschneid@redhat.com>, <mark.rutland@arm.com>,
<Dave.Martin@arm.com>, <james.morse@arm.com>,
<babu.moger@amd.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<rcu@vger.kernel.org>, <linux-trace-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v2 5/8] kernel: convert process/thread iterators to for_each_*_rculock
Date: Tue, 8 Sep 2026 07:57:52 +0530 [thread overview]
Message-ID: <e618ace1-6a8b-42c5-8a97-44b39dd1a7c7@amd.com> (raw)
In-Reply-To: <ap8yoW37GY17pHYS@redhat.com>
On 9/8/2026 3:24 AM, Oleg Nesterov wrote:
>> This might be my - admittedly shallow - understanding of scoped_guard,
>> but does scoped guard handle goto correctly?
>
> Yes, it does,
>
>> and why it's generally discouraged to mix cleanup.h and goto.
>
> Hmm, why? I didn't know...
Apparently older GCC would allow subtle bugs with cleanup + goto to slip
by but clang has always caught those bugs and refused to compile so as
long as clang builds are happy, things should be good.
Here is an older explanation from Peter:
https://lore.kernel.org/lkml/20260327154136.GL3739106@noisy.programming.kicks-ass.net/
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-09-08 2:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 8:13 [PATCH v2 0/8] sched: introduce for_each_process_rculock and for_each_thread_rculock Ye Liu
2026-09-07 8:13 ` [PATCH v2 1/8] " Ye Liu
2026-09-07 8:30 ` Lorenzo Stoakes (ARM)
2026-09-07 9:35 ` Oleg Nesterov
2026-09-07 15:42 ` Gregory Price
2026-09-07 21:20 ` SJ Park
2026-09-07 8:13 ` [PATCH v2 2/8] mm/oom_kill: convert process/thread iterators to for_each_*_rculock Ye Liu
2026-09-07 8:35 ` Lorenzo Stoakes (ARM)
2026-09-07 15:42 ` Gregory Price
2026-09-07 8:13 ` [PATCH v2 3/8] mm/ksm: convert process iterator to for_each_process_rculock Ye Liu
2026-09-07 8:36 ` Lorenzo Stoakes (ARM)
2026-09-07 15:43 ` Gregory Price
2026-09-07 8:13 ` [PATCH v2 4/8] mm/memory-failure: " Ye Liu
2026-09-07 11:05 ` Lorenzo Stoakes (ARM)
2026-09-07 15:43 ` Gregory Price
2026-09-07 21:24 ` SJ Park
2026-09-07 8:13 ` [PATCH v2 5/8] kernel: convert process/thread iterators to for_each_*_rculock Ye Liu
2026-09-07 12:20 ` Lorenzo Stoakes (ARM)
2026-09-07 15:53 ` Gregory Price
2026-09-07 17:57 ` Oleg Nesterov
2026-09-07 21:05 ` Gregory Price
2026-09-07 21:54 ` Oleg Nesterov
2026-09-07 22:27 ` Gregory Price
2026-09-07 22:44 ` Oleg Nesterov
2026-09-08 2:27 ` K Prateek Nayak [this message]
2026-09-08 6:35 ` Oleg Nesterov
2026-09-08 7:51 ` Peter Zijlstra
2026-09-07 21:28 ` SJ Park
2026-09-08 6:42 ` Oleg Nesterov
2026-09-08 7:42 ` Peter Zijlstra
2026-09-07 8:13 ` [PATCH v2 6/8] fs: " Ye Liu
2026-09-07 12:27 ` Lorenzo Stoakes (ARM)
2026-09-07 15:47 ` Gregory Price
2026-09-07 21:40 ` SJ Park
2026-09-07 8:13 ` [PATCH v2 7/8] lib: convert process iterator to for_each_process_rculock Ye Liu
2026-09-07 12:27 ` Lorenzo Stoakes (ARM)
2026-09-07 15:47 ` Gregory Price
2026-09-07 21:42 ` SJ Park
2026-09-07 8:13 ` [PATCH v2 8/8] security/landlock: convert thread iterator to for_each_thread_rculock Ye Liu
2026-09-07 12:28 ` Lorenzo Stoakes (ARM)
2026-09-07 15:49 ` Gregory Price
2026-09-07 21:44 ` SJ Park
2026-09-07 8:26 ` [PATCH v2 0/8] sched: introduce for_each_process_rculock and for_each_thread_rculock Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e618ace1-6a8b-42c5-8a97-44b39dd1a7c7@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=babu.moger@amd.com \
--cc=boqun@kernel.org \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gnoack3000@gmail.com \
--cc=gourry@gourry.net \
--cc=james.morse@arm.com \
--cc=jiangshanlai@gmail.com \
--cc=jmorris@namei.org \
--cc=joelagnelf@nvidia.com \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=lance.yang@linux.dev \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liuye@kylinos.cn \
--cc=ljs@kernel.org \
--cc=longman@redhat.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=mic@digikod.net \
--cc=mingo@redhat.com \
--cc=nao.horiguchi@gmail.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=qiang.zhang@linux.dev \
--cc=rafael@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=urezki@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox