From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9741C4345F for ; Sun, 28 Apr 2024 03:17:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 440076B007B; Sat, 27 Apr 2024 23:17:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F02B6B0083; Sat, 27 Apr 2024 23:17:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B75C6B0085; Sat, 27 Apr 2024 23:17:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0BB576B007B for ; Sat, 27 Apr 2024 23:17:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A09C5C0B91 for ; Sun, 28 Apr 2024 03:17:48 +0000 (UTC) X-FDA: 82057481016.09.C7F9CA2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 0D48E4000D for ; Sun, 28 Apr 2024 03:17:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eSE1W0ug; spf=pass (imf07.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714274267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IqRP7ge6tWlHIT3uS8hf73NpEdKtcHLWFvZPaVxJ4pA=; b=G0QU4Q4rFsnakVuikc0EaJqwqa7lE/LFuLwkfrH70XSc+JOokt1gl0ve7Kofh7yVQ4KQaH qbcUYIjgLr+yCRUwxJSwYtGj3EcOnamBOIYGhiJInadm0sNjHTleNdzVGFFlvLpYA/ykst lKxeUFo7NgC/8z3qRpCY6aU6BjJosIc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eSE1W0ug; spf=pass (imf07.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714274267; a=rsa-sha256; cv=none; b=AnxWSJyIYpipXdbSuhNWzbdOGeU6FRN85KdQ5cKutgxDvxpyHSQU7vN9LOFkPJptUuQWLj qjIvxElfSeOGh8tikR8sjBi+5CcErmXRh6DxZk/DVgx6zTy/t7WTi7bKpuyU+aGZXgVXJ1 BqErXXmumXtZqkZkWjChshpG0JKR6Xg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3684D60349; Sun, 28 Apr 2024 03:17:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B53A4C4AF17; Sun, 28 Apr 2024 03:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714274265; bh=Stf6RD+wk0dcrnB98wXmtvpPzh3y/7iTC6dGDf6CG6E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eSE1W0uggxKHMhGrafLiJ1MoFp6jqU0EtHhmTgaE7FD4rgDGhvXvwpgtHYv7X7tv9 IUyXlgs2qZyH77BpEWVg91SzUXwOMH+0G6jiV5pKwep68UypOG9Y6DaiiKLz6Mkczc kma9smBLp1ZgQZvjYGPIXrgitC0pyJTSmmtX+w8nYqWqXEF9r8q8iTzLjvTlhwNUAQ 3avnbxMudfJ/zwx0/ZETQql4MRxSBH0e9dBBPqGsHAXBLDeBw6UUwMm0qJOCmWdveF nIsER7Q+8JoeGWomOi6vvyBFi69Rk0dKnLglCYpQe70Ux/uu/E9KY2+EUcikN9uZuI semwXapexl8aA== Message-ID: Date: Sun, 28 Apr 2024 11:17:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/8] f2fs: drop usage of page_index To: Matthew Wilcox , Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net References: <20240423170339.54131-1-ryncsn@gmail.com> <20240423170339.54131-4-ryncsn@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1i9oj57amxztn34oczixiaewgnrmyqyh X-Rspamd-Queue-Id: 0D48E4000D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714274266-673545 X-HE-Meta: U2FsdGVkX1+FThuhRq4TFV9aqAs8lPfP+U/QZVXjHij9HJmajruNGptbc8M++1iuTz9ar9kPR6i9T/JG0uNkM4ZoGNcJEPRBVaRCuF+aM7U7jHcMBiHtJs9TMy8PmQ89bx2IpXGMEusdluBT54W+VSAHFtVq8ZSkptAoa8de8V/kesT4ElbNQyccLqzfrQ56ENYMIpkX8XDp+zhICK+nAE1spOjcaooH+PpNcIZazL7mutW5sp54RL72fUDwS8FbIVbpAkkCL2kJj84pTbYNmU8yVHcXV1qOxyKlRYO5hb8uJMWhtlFkPVlhpqYilOvG0nNdWdZtAtrQcVDZASQGAnArExPDEYXm8gclK8diJs7hw8Jy7P2MUgV36MNkHych2NPc1Y/FS/ausqMfUV+rFvEWlYlndKCWMs1Bi5ABReRA1zdbFu6OLeXM3se8jT0ub+IE/xCyo+8d0ichWyq827aFb4BdWHaUFnmC78vBB63pRT4HRdZerCO+M2UNClNAy1G/oFGazKnJ1QEL/hsLeEE1R36Xr49ar5YsL7Axj+lkM2zBzZ9lAW8igVE3HGPNs1X625/XPa1wX5f0B9S0jVH+vMC0FYdZteBX4Oq6L5NhgsuRHu3hpGIl8SpJ9Y9PVPSVkrjfLz/gEm9fGB3WS/bg5uATmaTAdZARUYSjaXIxVVg0n9QC+LJceZ2l668OPtnkPmj4OkDLyT5iDvZ47H7lM7YdOB6+gpevMtmxiRPnC6XWV7E2BIgO3aXkGJmul7YX/8rocGx8feRJpOED8sZywryXUJR0Qv0WNvqr874yj/TDLGXFoUQ7946Sb2DnyXZJOdBWyhzhDfP1VuMg2LYKpna2nKJH34gc9qTr+jdTYo1n0aK1zA7LOGLYpXk875Ql2JGRUVlHS4UKQS48kT/+zGDCUWK6Eg+z8bEvR7IqNDc+2MApqOBC+rqDQ6sGdC/EHIaJXouRTVJD/lt 866dFpUa lfbOh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/24 6:58, Matthew Wilcox wrote: > On Wed, Apr 24, 2024 at 01:03:34AM +0800, Kairui Song wrote: >> @@ -4086,8 +4086,7 @@ void f2fs_clear_page_cache_dirty_tag(struct page *page) >> unsigned long flags; >> >> xa_lock_irqsave(&mapping->i_pages, flags); >> - __xa_clear_mark(&mapping->i_pages, page_index(page), >> - PAGECACHE_TAG_DIRTY); >> + __xa_clear_mark(&mapping->i_pages, page->index, PAGECACHE_TAG_DIRTY); >> xa_unlock_irqrestore(&mapping->i_pages, flags); >> } > > I just sent a patch which is going to conflict with this: > > https://lore.kernel.org/linux-mm/20240423225552.4113447-3-willy@infradead.org/ > > Chao Yu, Jaegeuk Kim; what are your plans for converting f2fs to use Hi Matthew, I've converted .read_folio and .readahead of f2fs to use folio w/ below patchset, and let me take a look how to support and enable large folio... https://lore.kernel.org/linux-f2fs-devel/20240422062417.2421616-1-chao@kernel.org/ Thanks, > folios? This is getting quite urgent.