Re: [PATCH] mm/hugetlb.c: fix a bug within a BUG(): inconsistent pte comparison

John Hubbard
2023-06-30T02:07:13Z

On 6/29/23 18:50, James Houghton wrote:
> Hi John,
>
> Good catch, and thanks for the detailed explanation. It looks like
> riscv and powerpc have equivalent problems in their huge_pte_alloc
> implementations, perhaps it's worth taking a look at those. (riscv
> looks like it has precisely the same problem except it's a WARN, but
> powerpc looks more interesting.)
>
> Either way,
>
> Acked-by: James Houghton <jthoughton@google.com>

Thanks for the ack, and yes, riscv and powerpc do look like the
same problem to me, too. I'm glad you thought to look there, as
I have fallen into tunnel vision while investigating this, heh.

OK, as long as I'm here, let me fix those up, too. I'll make those
a separate patch, because they are still in the "fragile" state,
rather than actually at the full crash state. :)

thanks,
--
John Hubbard
NVIDIA