From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFA6C433EF for ; Wed, 29 Sep 2021 15:07:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15738613D3 for ; Wed, 29 Sep 2021 15:07:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15738613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9DFE8940039; Wed, 29 Sep 2021 11:07:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98EBA940020; Wed, 29 Sep 2021 11:07:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87DCC940039; Wed, 29 Sep 2021 11:07:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 79841940020 for ; Wed, 29 Sep 2021 11:07:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2A2BD82499B9 for ; Wed, 29 Sep 2021 15:07:17 +0000 (UTC) X-FDA: 78640939314.01.2349261 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf22.hostedemail.com (Postfix) with ESMTP id CC8731910 for ; Wed, 29 Sep 2021 15:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632928036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gapF6Q7MxbKj+/Jpg0HNCHa+0ngI63VYNLFNHFDInM4=; b=KM8YB6ciT9CY51YYfZdK61z7iUAtHYXNHB1ZJ8fpmZyP0UrhOHXBGnTimY0jE0uxLJ+SXR yZZNjyqnG+w1t7LH71OrlenCXfMGSpg1RlNDY54gu1a3oo3DN4FaHbcVN0WHEAOaxM5wyJ rTLtvokMYRooahm2NYzm6Af+dcD4fxg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-xvOH2zKsMsasgCLGRo3rNw-1; Wed, 29 Sep 2021 11:07:14 -0400 X-MC-Unique: xvOH2zKsMsasgCLGRo3rNw-1 Received: by mail-wr1-f70.google.com with SMTP id j15-20020a5d564f000000b00160698bf7e9so709591wrw.13 for ; Wed, 29 Sep 2021 08:07:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gapF6Q7MxbKj+/Jpg0HNCHa+0ngI63VYNLFNHFDInM4=; b=wBLThBfNJMvP39KdlG8KnbswlZYHjQ69NJUg+/QYi6u8G4wrD4ncIjdogQNAD2Gv2j crv4FsOG5ozvi5QG6ga40DxklcMLTtARFS2RHqCObv6v1nScZr/QsGYKQKah17P6Zod5 IiFNjBadLYXJQKuDnh9D2jjgtKSrPcTK7ccZ4FilXuGq/4yKeJNP92tRxlVuZgq0x74Q smRwvuhD4Av7HFUBIp/8e9cyEGmqmOGJRTTmHLeYTuktgkrUjyMbOmY7HdOEBh2Wkf2d eKpN/Du2BQBcWQSZodzFneP4+t9aT+VAvE2zt+URnKFYihhcTX4AkdV3rTTxrE6eoqK+ DWjA== X-Gm-Message-State: AOAM533OjaYZ0rMYPUVgdSSwlQyqk+/Ahu4ka2G73m2+Ngu/N9F5+BCe 8HtSQrJv3yCa1PiLBPSLhiDK5GAepR7MQ45jpbYr8s3dIVSGTAgjLmoWQzjBFX3G6M8/J2E2djw XxJUf49GMeoiCCPK9ypoGzN+9n5hB4Fvc7Qu6XAzxeLDYvxpzwuoMZX7nFKw= X-Received: by 2002:a5d:4e4e:: with SMTP id r14mr378710wrt.147.1632928032918; Wed, 29 Sep 2021 08:07:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo/OiD1pi8Vj8uvbtvhFWxk5A000qCxnhsR/1CMHH5asTCVBPsn8x+8H3lxRFK4haIMhJq1A== X-Received: by 2002:a5d:4e4e:: with SMTP id r14mr378630wrt.147.1632928032598; Wed, 29 Sep 2021 08:07:12 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c3b.dip0.t-ipconnect.de. [79.242.60.59]) by smtp.gmail.com with ESMTPSA id f8sm177044wrx.15.2021.09.29.08.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 08:07:12 -0700 (PDT) Subject: Re: [PATCH v1 2/8] x86/xen: simplify xen_oldmem_pfn_is_ram() To: Boris Ostrovsky , linux-kernel@vger.kernel.org Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Jason Wang , Dave Young , Baoquan He , Vivek Goyal , Michal Hocko , Oscar Salvador , Mike Rapoport , "Rafael J. Wysocki" , x86@kernel.org, xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20210928182258.12451-1-david@redhat.com> <20210928182258.12451-3-david@redhat.com> <4ab2f8c2-c3d5-30b3-a670-a8b38e218b6e@oracle.com> <3b935aa0-6d85-0bcd-100e-15098add3c4c@oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 29 Sep 2021 17:07:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3b935aa0-6d85-0bcd-100e-15098add3c4c@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: CC8731910 X-Stat-Signature: uzp6niueo4kkh9pat8jyopkdjkzn8h6x Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KM8YB6ci; spf=none (imf22.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-HE-Tag: 1632928036-28179 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.09.21 16:22, Boris Ostrovsky wrote: >=20 > On 9/29/21 5:03 AM, David Hildenbrand wrote: >> On 29.09.21 10:45, David Hildenbrand wrote: >>>> >>> Can we go one step further and do >>> >>> >>> @@ -20,24 +20,11 @@ static int xen_oldmem_pfn_is_ram(unsigned long pf= n) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct xen_hv= m_get_mem_type a =3D { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .domid =3D DOMID_SELF, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .pfn =3D pfn, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 .mem_type =3D HVMMEM_ram_rw, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ram; >>> =C2=A0=C2=A0 -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (HYPERVISOR_hv= m_op(HVMOP_get_mem_type, &a)) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return -ENXIO; >>> - >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 switch (a.mem_type) { >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case HVMMEM_mmio_dm: >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 ram =3D 0; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 break; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case HVMMEM_ram_rw: >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case HVMMEM_ram_ro: >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default: >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 ram =3D 1; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 break; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> - >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ram; >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HYPERVISOR_hvm_op(HVMOP_get_mem= _type, &a); >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return a.mem_type !=3D HVMMEM_m= mio_dm; >=20 >=20 > I was actually thinking of asking you to add another patch with pr_warn= _once() here (and print error code as well). This call failing is indicat= ion of something going quite wrong and it would be good to know about thi= s. Will include a patch in v2, thanks! --=20 Thanks, David / dhildenb