From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BBEC07E99 for ; Thu, 8 Jul 2021 09:00:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7529161CF2 for ; Thu, 8 Jul 2021 09:00:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7529161CF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29FCC6B0011; Thu, 8 Jul 2021 05:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24FAF6B005D; Thu, 8 Jul 2021 05:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CAA66B006C; Thu, 8 Jul 2021 05:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id DCEE06B0011 for ; Thu, 8 Jul 2021 05:00:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2411F801ABCF for ; Thu, 8 Jul 2021 09:00:14 +0000 (UTC) X-FDA: 78338823948.04.8D8BD5C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 23F2FB0002B6 for ; Thu, 8 Jul 2021 09:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625734811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gIPcM/AEt6CFgVLe5U5Gt1G0R6Bu5ZtRDH8h8xxqSLM=; b=bN2Fq7NNwbwXM1B0pJEZzz4W7U9AZdrgVR91XQTdsIViBKD4Dc1smA8TrHRc92kyF9IOK2 GR1CyWJGOz2h7pWuME4Yrn6vt7CvisiTTlChTFnruIGQDKh0QolvdP2UhchBmJwlsaOHO5 n+OAf28F4wnbCNTl6HwKABPDiTmK9VM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533-dvMrbmsaMEGbgyORYjtuIg-1; Thu, 08 Jul 2021 05:00:10 -0400 X-MC-Unique: dvMrbmsaMEGbgyORYjtuIg-1 Received: by mail-lf1-f70.google.com with SMTP id i13-20020a196d0d0000b029034f05dc854aso2895770lfc.1 for ; Thu, 08 Jul 2021 02:00:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gIPcM/AEt6CFgVLe5U5Gt1G0R6Bu5ZtRDH8h8xxqSLM=; b=hoe5g6+JiwVSPJDHvRbDPVQaXBQNUm05UzLTAmQGpmsU7z1bIIZAILkBaVt415LB0H mPFQkUafzUVbeZt4G+w6Jzge9RtnVnxlPP9adwrzIhV14c77BU0YuXIWkYqx5KOmEaMq wnX683O54urDgNpdBkBYcZFU/k78e4ZVWg6Tj9C6OkRGyO9cjXCeA2fD3hrnVCzKeX8z OHAIbEBmU9jycBUyI9Pin5KGcMtCURsULBNL9Lopvb/cguphThMFOkobNsI21uub+aAE pqK8VcMv0CNP3/aJCMiKPDsvdBg7VHzH9/OBtSe7GIkxLyCyBMEpTBw2rOicpHMOzIn7 YQJw== X-Gm-Message-State: AOAM531fsKIchN/IheEjErSXITnw4N7JwSngpn75UY3pUwVesVy11hRc NRdjbfOIo2QVcdid8QsblY8MG61zoS3NpR+a2Horq/WmOKMk8+LnsWFthM1omOQfJKBgrZ4eGw+ bbwzXxN49Lmk= X-Received: by 2002:a05:6402:1014:: with SMTP id c20mr36763739edu.380.1625734413612; Thu, 08 Jul 2021 01:53:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx/+0c8nIU7pwYBojXCHzTNcV8ZCk6Cqibqq/t9wTBQKxs+CGQcGK3UP/Yf8+cmhDD/LkdhQ== X-Received: by 2002:a05:6402:1014:: with SMTP id c20mr36763691edu.380.1625734413381; Thu, 08 Jul 2021 01:53:33 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u17sm853904edt.67.2021.07.08.01.53.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 01:53:32 -0700 (PDT) Subject: Re: [PATCH Part1 RFC v4 04/36] x86/mm: Add sev_feature_enabled() helper To: "Dr. David Alan Gilbert" , Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com References: <20210707181506.30489-1-brijesh.singh@amd.com> <20210707181506.30489-5-brijesh.singh@amd.com> From: Paolo Bonzini Message-ID: Date: Thu, 8 Jul 2021 10:53:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspam-User: nil Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bN2Fq7NN; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of pbonzini@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=pbonzini@redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 23F2FB0002B6 X-Stat-Signature: 1aifgj58utgxfunmt9e93cn735c37f7g X-HE-Tag: 1625734812-934354 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/07/21 10:50, Dr. David Alan Gilbert wrote: >> +enum sev_feature_type { >> + SEV, >> + SEV_ES, >> + SEV_SNP >> +}; > Is this .... > >> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h >> index a7c413432b33..37589da0282e 100644 >> --- a/arch/x86/include/asm/msr-index.h >> +++ b/arch/x86/include/asm/msr-index.h >> @@ -481,8 +481,10 @@ >> #define MSR_AMD64_SEV 0xc0010131 >> #define MSR_AMD64_SEV_ENABLED_BIT 0 >> #define MSR_AMD64_SEV_ES_ENABLED_BIT 1 >> +#define MSR_AMD64_SEV_SNP_ENABLED_BIT 2 > Just the same as this ? > No, it's just a coincidence. Paolo