From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79A6C54E58 for ; Fri, 15 Mar 2024 16:52:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F400280137; Fri, 15 Mar 2024 12:52:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEF96800B4; Fri, 15 Mar 2024 12:52:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D689C80137; Fri, 15 Mar 2024 12:52:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C7A46800B4 for ; Fri, 15 Mar 2024 12:52:57 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 375DCA0C5B for ; Fri, 15 Mar 2024 16:52:57 +0000 (UTC) X-FDA: 81899867994.05.D31E44B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf03.hostedemail.com (Postfix) with ESMTP id 203822000E for ; Fri, 15 Mar 2024 16:52:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GIVcH5dt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=v9OBHnLK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GIVcH5dt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=v9OBHnLK; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710521573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y4ELQ8jx6kpMYkwxWHw4XIu0o8oKQ+ttZ5iD5/+0aoI=; b=zf0f5yHb3RC1BIAV2KT71ftyi2dWtELx00uuc6Y6To8v0duOlnkcVjFbgvCFPFx4/cN/jZ LPRK4lZqCvPN5r0w4l2bk/4f46C121EJS7F1RLYORYJo0eymgr9VSh9Xh5kykhWbco+NL1 Msb2wTLkg2n+Nl7i2d4eBA6yuCsoohY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GIVcH5dt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=v9OBHnLK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GIVcH5dt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=v9OBHnLK; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710521573; a=rsa-sha256; cv=none; b=UYLcaVKEtpw0vYzEbFRuf5YreRREXI/VUjS5JzTazRiV7ljhr9iVOYF+fdpZuvIppATx02 IUhWe7g0UHBt5lO9y8IjTnwmmlrXhl6diFHCnpX96wLk35JjxipsCWK57G498nroQzF27f Qxs8m0qtQGrRMi4Km70h8j6HS9fF/hA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D2DF21D19; Fri, 15 Mar 2024 16:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710521571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4ELQ8jx6kpMYkwxWHw4XIu0o8oKQ+ttZ5iD5/+0aoI=; b=GIVcH5dtOURRjsdtUmCD+8IDbDFZfndkzp834onReclyzr3ZSsGzmKoG48Q3RIstX5UoFO EzKBDq+9pMXna3n4ZEBof828Uw6Dsb9kv4FwJRm/OVnxA+xXwas3cGxIxx2NiCfRTgWRUc 1t6fi4yhOmG1E7l7RXRD/lGQuIcIduM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710521571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4ELQ8jx6kpMYkwxWHw4XIu0o8oKQ+ttZ5iD5/+0aoI=; b=v9OBHnLKouzjKpvvHgKihPfEoR5Q62+JbhEIKayzSwUE6wLlA2eYmYRzKueSggUnWW2ior OKON2/VpvyuA/JCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710521571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4ELQ8jx6kpMYkwxWHw4XIu0o8oKQ+ttZ5iD5/+0aoI=; b=GIVcH5dtOURRjsdtUmCD+8IDbDFZfndkzp834onReclyzr3ZSsGzmKoG48Q3RIstX5UoFO EzKBDq+9pMXna3n4ZEBof828Uw6Dsb9kv4FwJRm/OVnxA+xXwas3cGxIxx2NiCfRTgWRUc 1t6fi4yhOmG1E7l7RXRD/lGQuIcIduM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710521571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4ELQ8jx6kpMYkwxWHw4XIu0o8oKQ+ttZ5iD5/+0aoI=; b=v9OBHnLKouzjKpvvHgKihPfEoR5Q62+JbhEIKayzSwUE6wLlA2eYmYRzKueSggUnWW2ior OKON2/VpvyuA/JCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 92B6B1368C; Fri, 15 Mar 2024 16:52:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id o1p9I+J89GVLbwAAD6G6ig (envelope-from ); Fri, 15 Mar 2024 16:52:50 +0000 Message-ID: Date: Fri, 15 Mar 2024 17:52:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-24-surenb@google.com> <1f51ffe8-e5b9-460f-815e-50e3a81c57bf@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 203822000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: kjo3bfmkrb5crx5dm6atkgeirrc4mwsy X-HE-Tag: 1710521572-419934 X-HE-Meta: U2FsdGVkX1/xHwetJrAxDKLBFT/3ChshRN0nL739onFctgfehMiNDjFmEnBlohnk/WhM1eDNxe05p7WiU3rJm7eEng6GsyX7X3o1qDWnp/yVsuLmoyg/Z43jWDTgiDtRQORUZ/x5ERzatHZWQi2S9ljHS3eTDQsEx7jQqwMDEtP5QEcgWbx5Gu1siFoQJTKFrljU7R4EvmLXt3Qml5Xg+0Z3oi4SEJicvzMZtFOg1tstgf5AieTy9DD4DJlwUqd/BAruh5/Kim/hoteoB/n27h5KMdfrC3IhjmmKBBTCzbAFoZoadjF1OSh7dei+IzIruKrGQqIMRltDWFKMQhDZ142iBRg+RROeFkvs9gVJGDNRTdC1IHDovsWnxgp60CqbAnHA+dBvX0e70QhLmKCUTtoQTdJbjLcenGcMRqja/kXy9aVEkZCoG2R4IMD09+fSlYsbbiJfjqf7zmDj6JnJU6MWqPky0xd+RuepXQIebIaG5V33APHjno+27363v2ia3J3Dr46QIFN71ftKXlU47IevL++a2r276Q4a5xArNQFuR8iAH4imLAMR53qGYmIvTFv7lE1X96+zaXd27eixFoZk0WIG5BDUYt9Vdx71FVI26CAURzh5iR/2xbzcTFEBxlChmKIHjOdLML30ZAm/TH5Yr18QvHG5HyWen1Iq875P2bV5982iH/Cn0NmZjxthRbykii43CYoMYTGlBo745BoDKbDDeHgFO+W4q2xyR1q7H1QJEFuAozqHQq9sV1t89YinCO1WuZeAR+uRH0C5ONm9HlbtOZTDSJhbzr1YyvbmKjyL90iVlvkmukejDJ9AlX5ZRpBohL0jzm7NFwG+ROI6Fkoz6fKEeyUlRSKMYO+55rUylvcwenU7HxtTfhRHhmfhlZRZMHO0VQ8syMy4G46Pn/EsuKQVvoSYJf6n6DRZCtFuXUyJ7wAhDkHX+khw+cD6RE7SQejayLqR4EG 8TQhJKKm SxdcbK87ppqNTLNgYnpD1dotkBr3R6nbfJZxpzDe/kavYlGtF7JlgBLFn2CqytTT6jKA+WxJqZEgAAdeyWHPPRFwhLr18tvUXDfclla4dtYMguxR+2HVgifqFZr6MPNPvuoBwD14hK4eN0lN9P43SaGFiZlg+O0Oo8HlkgjS8iYPBVt+39ikZohwHeDGMmYoUR/aO6bMNQSYINVgg0Kyvu/qTbr+XE/S0r5ySrRo9zoYXSaLtoZ9nOY6Cab8ubLopME4dA8ww1hoQKti+2XTNfb0Et8GsQPdnY8BjteRASgFTLechWMWGzFgngJ+uoBrj5qOJOY1iHVgntKjcb/5AiDTxLOD8uSJk3s+PvN9KnaT67PepgLlrhiFQKmCTETT9PJCy5TSuSQ79lEy0K6SkWtlOtua2/1x8IOBQRzzgW7BkP0c1f8a5JUbUFduITIxzMQDj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/15/24 16:43, Suren Baghdasaryan wrote: > On Fri, Mar 15, 2024 at 3:58 AM Vlastimil Babka wrote: >> >> On 3/6/24 19:24, Suren Baghdasaryan wrote: >> > Account slab allocations using codetag reference embedded into slabobj_ext. >> > >> > Signed-off-by: Suren Baghdasaryan >> > Co-developed-by: Kent Overstreet >> > Signed-off-by: Kent Overstreet >> > Reviewed-by: Kees Cook >> >> Reviewed-by: Vlastimil Babka >> >> Nit below: >> >> > @@ -3833,6 +3913,7 @@ void slab_post_alloc_hook(struct kmem_cache *s, struct obj_cgroup *objcg, >> > unsigned int orig_size) >> > { >> > unsigned int zero_size = s->object_size; >> > + struct slabobj_ext *obj_exts; >> > bool kasan_init = init; >> > size_t i; >> > gfp_t init_flags = flags & gfp_allowed_mask; >> > @@ -3875,6 +3956,12 @@ void slab_post_alloc_hook(struct kmem_cache *s, struct obj_cgroup *objcg, >> > kmemleak_alloc_recursive(p[i], s->object_size, 1, >> > s->flags, init_flags); >> > kmsan_slab_alloc(s, p[i], init_flags); >> > + obj_exts = prepare_slab_obj_exts_hook(s, flags, p[i]); >> > +#ifdef CONFIG_MEM_ALLOC_PROFILING >> > + /* obj_exts can be allocated for other reasons */ >> > + if (likely(obj_exts) && mem_alloc_profiling_enabled()) Could you at least flip these two checks then so the static key one goes first? >> > + alloc_tag_add(&obj_exts->ref, current->alloc_tag, s->size); >> > +#endif >> >> I think you could still do this a bit better: >> >> Check mem_alloc_profiling_enabled() once before the whole block calling >> prepare_slab_obj_exts_hook() and alloc_tag_add() >> Remove need_slab_obj_ext() check from prepare_slab_obj_exts_hook() > > Agree about checking mem_alloc_profiling_enabled() early and one time, > except I would like to use need_slab_obj_ext() instead of > mem_alloc_profiling_enabled() for that check. Currently they are > equivalent but if there are more slab_obj_ext users in the future then > there will be cases when we need to prepare_slab_obj_exts_hook() even > when mem_alloc_profiling_enabled()==false. need_slab_obj_ext() will be > easy to extend for such cases. I thought we don't generally future-proof internal implementation details like this until it's actually needed. But at least what I suggested above would help, thanks. > Thanks, > Suren. > >> >> > } >> > >> > memcg_slab_post_alloc_hook(s, objcg, flags, size, p); >> > @@ -4353,6 +4440,7 @@ void slab_free(struct kmem_cache *s, struct slab *slab, void *object, >> > unsigned long addr) >> > { >> > memcg_slab_free_hook(s, slab, &object, 1); >> > + alloc_tagging_slab_free_hook(s, slab, &object, 1); >> > >> > if (likely(slab_free_hook(s, object, slab_want_init_on_free(s)))) >> > do_slab_free(s, slab, object, object, 1, addr); >> > @@ -4363,6 +4451,7 @@ void slab_free_bulk(struct kmem_cache *s, struct slab *slab, void *head, >> > void *tail, void **p, int cnt, unsigned long addr) >> > { >> > memcg_slab_free_hook(s, slab, p, cnt); >> > + alloc_tagging_slab_free_hook(s, slab, p, cnt); >> > /* >> > * With KASAN enabled slab_free_freelist_hook modifies the freelist >> > * to remove objects, whose reuse must be delayed. >>