* [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page()
@ 2022-07-21 2:05 Alistair Popple
2022-07-21 2:05 ` Alistair Popple
2022-07-21 8:01 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Alistair Popple @ 2022-07-21 2:05 UTC (permalink / raw)
To: akpm
Cc: david, alex.sierra, Felix.Kuehling, linux-mm, amd-gfx, dri-devel,
Alistair Popple
Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning
instead of failing") added a badly formatted if statement. Fix it.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Reported-by: David Hildenbrand <david@redhat.com>
---
Apologies Andrew for missing this. Hopefully this fixes things.
mm/gup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index 364b274a10c2..c6d060dee9e0 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
folio_nr_pages(folio));
}
- if (!list_empty(&movable_page_list) || isolation_error_count
- || coherent_pages)
+ if (!list_empty(&movable_page_list) || isolation_error_count ||
+ coherent_pages)
goto unpin_pages;
/*
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page()
2022-07-21 2:05 [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page() Alistair Popple
@ 2022-07-21 2:05 ` Alistair Popple
2022-07-21 8:01 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Popple @ 2022-07-21 2:05 UTC (permalink / raw)
To: akpm
Cc: david, alex.sierra, Felix.Kuehling, linux-mm, amd-gfx, dri-devel,
Alistair Popple
Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning
instead of failing") added a badly formatted if statement. Fix it.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Reported-by: David Hildenbrand <david@redhat.com>
---
Apologies Andrew for missing this. Hopefully this fixes things.
mm/gup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index 364b274a10c2..c6d060dee9e0 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
folio_nr_pages(folio));
}
- if (!list_empty(&movable_page_list) || isolation_error_count
- || coherent_pages)
+ if (!list_empty(&movable_page_list) || isolation_error_count ||
+ coherent_pages)
goto unpin_pages;
/*
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page()
2022-07-21 2:05 [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page() Alistair Popple
2022-07-21 2:05 ` Alistair Popple
@ 2022-07-21 8:01 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2022-07-21 8:01 UTC (permalink / raw)
To: Alistair Popple, akpm
Cc: alex.sierra, Felix.Kuehling, linux-mm, amd-gfx, dri-devel
On 21.07.22 04:05, Alistair Popple wrote:
> Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning
> instead of failing") added a badly formatted if statement. Fix it.
>
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Reported-by: David Hildenbrand <david@redhat.com>
> ---
>
> Apologies Andrew for missing this. Hopefully this fixes things.
>
> mm/gup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 364b274a10c2..c6d060dee9e0 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
> folio_nr_pages(folio));
> }
>
> - if (!list_empty(&movable_page_list) || isolation_error_count
> - || coherent_pages)
> + if (!list_empty(&movable_page_list) || isolation_error_count ||
> + coherent_pages)
> goto unpin_pages;
>
> /*
Happy to see the series go upstream soon.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-21 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-21 2:05 [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page() Alistair Popple
2022-07-21 2:05 ` Alistair Popple
2022-07-21 8:01 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).