From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3FBCC43334 for ; Thu, 21 Jul 2022 11:36:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DD7A8E0003; Thu, 21 Jul 2022 07:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 464A58E0001; Thu, 21 Jul 2022 07:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B83A8E0003; Thu, 21 Jul 2022 07:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 14E628E0001 for ; Thu, 21 Jul 2022 07:36:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E218D12089A for ; Thu, 21 Jul 2022 08:01:14 +0000 (UTC) X-FDA: 79710361668.24.7F26202 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 63B7218006E for ; Thu, 21 Jul 2022 08:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658390473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U81cy9CSvVVdYWusFPfbgXUwAXqnFtMTt2aTn1ob23Q=; b=MKIqLnNE4gK+t11hB6wjAQpuIn6KGrJpicUtNaTHP3DlRvkCycOMCTIlm2jeTVs+im3OZh o9vdeO5zXoicvClqJgh4YXrTZrKu5tv/uOjtZX8BcX/wsqRGuFI16/4lhEl5jzJ2Gdxazb s3qFw9LeXuZJ0ULl/aQdomMDQZzsDms= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-139-Mao9BZeHNhGPRRWuVAebUg-1; Thu, 21 Jul 2022 04:01:11 -0400 X-MC-Unique: Mao9BZeHNhGPRRWuVAebUg-1 Received: by mail-wm1-f70.google.com with SMTP id n21-20020a7bc5d5000000b003a2ff4d7a9bso355368wmk.9 for ; Thu, 21 Jul 2022 01:01:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=U81cy9CSvVVdYWusFPfbgXUwAXqnFtMTt2aTn1ob23Q=; b=JKgn6CJVZ8JrxQmwo53MDMT51xDWM4lCir9qmRkSMhUmFU6sRMvAoNfYfNyPlPp07e cd0R8drImGhRtsSJMCPwCG9rVBJ1Z/LAgukiIRnxi52vRWwW9gnO9gArjMmoY/npaOMc blxfUs/F3jBIb/iqxsMeuXevlWmRRrGuFvsRdDVMo9a3QVxRi9j1Q4xVe6bx2DuDfQa6 jOT+7+4lqDhaaWNpz8c5i+QzfRuycD9ky45N3ivzbCSHfjR/XFB1zcYv4dIw+tnhq7mq Le+uR73zC1AFi2eiq8d/NJjOVB+kSzXDeJywwD6P2pegp8n7QebCtWrBFTR6fh5PMKpS KnUg== X-Gm-Message-State: AJIora88iq5zQ5cSSn+5gZsZQC+0vH14IoxoziHRK0EaGJ+Hee1vY/hk W7+g03JtfnTKrHja++nyfrM07j8lB+cgEnDukIrcDdxzePENH51kPV18XhgifsU0hnTZijn1l/T KTVyeZCEISBk= X-Received: by 2002:a5d:4301:0:b0:21b:8af6:4a21 with SMTP id h1-20020a5d4301000000b0021b8af64a21mr34534638wrq.296.1658390470351; Thu, 21 Jul 2022 01:01:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vsZMcTagC0gCtvDk0TNJLA8Jh/PA0P+4jFZJgnmhKZDdzVU3YPOvehRpLoTuyv/pkgq+5j2Q== X-Received: by 2002:a5d:4301:0:b0:21b:8af6:4a21 with SMTP id h1-20020a5d4301000000b0021b8af64a21mr34534605wrq.296.1658390469900; Thu, 21 Jul 2022 01:01:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:e000:25d3:15fa:4c8b:7e8d? (p200300cbc707e00025d315fa4c8b7e8d.dip0.t-ipconnect.de. [2003:cb:c707:e000:25d3:15fa:4c8b:7e8d]) by smtp.gmail.com with ESMTPSA id l37-20020a05600c1d2500b003a33227e49bsm678871wms.4.2022.07.21.01.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 01:01:09 -0700 (PDT) Message-ID: Date: Thu, 21 Jul 2022 10:01:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page() To: Alistair Popple , akpm@linux-foundation.org Cc: alex.sierra@amd.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220721020552.1397598-1-apopple@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220721020552.1397598-1-apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658390474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U81cy9CSvVVdYWusFPfbgXUwAXqnFtMTt2aTn1ob23Q=; b=xfgLbAUuoIGOWxOhEG+dmtBXpRLiQRP5/e/0A8PSM5JoFmwRuu7yzQBskno7PpjUp+dOo9 r/rdKBxjjt9SiBOjHISnso1tUAnzU+kQ6BEl/6JHkVh6qv8L/BKfs6X6mjGvrWhOhp9E/X Ode3DYLmZy0PPYju/RWUdtmvP8NEquY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658390474; a=rsa-sha256; cv=none; b=S6mEylnGXc30gA9YknuWHeNI9MEnDnuAnDuHbXsb1z4qm/kOs9D0RsHeyP2AtRsmH87w0I m7ls/HhdUmlu0/wqpLHkSyJCKjUDydM1+HA2C4m9KD7a/6xID3ODQsHm2BikQiF9XP6tWS Cj0g/ATkRUYPPV/7HWu7ZDdvvJxKXl0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MKIqLnNE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Queue-Id: 63B7218006E Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MKIqLnNE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: qcqk39dr8nxywbjkjcacy53xdcnx16ga X-HE-Tag: 1658390474-220356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.07.22 04:05, Alistair Popple wrote: > Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning > instead of failing") added a badly formatted if statement. Fix it. > > Signed-off-by: Alistair Popple > Reported-by: David Hildenbrand > --- > > Apologies Andrew for missing this. Hopefully this fixes things. > > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 364b274a10c2..c6d060dee9e0 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, > folio_nr_pages(folio)); > } > > - if (!list_empty(&movable_page_list) || isolation_error_count > - || coherent_pages) > + if (!list_empty(&movable_page_list) || isolation_error_count || > + coherent_pages) > goto unpin_pages; > > /* Happy to see the series go upstream soon. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb