From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08827C77B70 for ; Mon, 17 Apr 2023 10:33:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 756FE8E0002; Mon, 17 Apr 2023 06:33:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 706C08E0001; Mon, 17 Apr 2023 06:33:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7FC8E0002; Mon, 17 Apr 2023 06:33:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4AA198E0001 for ; Mon, 17 Apr 2023 06:33:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 166C0140538 for ; Mon, 17 Apr 2023 10:33:09 +0000 (UTC) X-FDA: 80690520498.07.BF96149 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 94A8C40017 for ; Mon, 17 Apr 2023 10:33:06 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fShVyHmM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681727587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xfhFkFEXd/Fa/v20KkaXF/K4tKRiXQWpPAFsCwHLV14=; b=3impmD7a7PJZ37nEcHdYiVSLWXfMto2ojY2bvXM7axKIZd4JjUhxkdLyg1yqvf5J0gCiTy BWXUXZJOTkXn6+4Wy27GEiSTnhypFVLz+/+qfNDSSOu+qXmOPW0z3BWSoe07PhIrfSnbG3 6E8kd9Po+UjmplNlSywfUSQ54+avXBo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fShVyHmM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681727587; a=rsa-sha256; cv=none; b=hxknhbp0STrUYsM1fBXovQSLLQEWTBOHXU/h6QHuWu/Pj/VS/dU2SXhg9BwG8fXdxFod7u aHBlpALrTHnGMbQDhLzhot5mOB8c1sAF827734UOl2KfzfmCD936A4fqUXvncBJ7cKjxLp DBeMvXz0h0kDyZGzRNbKTSHIgG/xaU8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681727585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xfhFkFEXd/Fa/v20KkaXF/K4tKRiXQWpPAFsCwHLV14=; b=fShVyHmMsQWsG6oZY/gen6ivuG94+OOrNgyA9QkZSgRIQF7RUXml8JvlegVCLquhjynSmu uP6JbgHvEI3rOKKZqGRIcv1f9RXMGWRZVNi3eIDf3qFed/9LwZc1uhKETvlbSbUvXJQeUP ZgdVtNJty+XkOYjTRPBHz1G0Tn6XWng= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-DLAbdsT1OGqnfqYsG1OisA-1; Mon, 17 Apr 2023 06:33:04 -0400 X-MC-Unique: DLAbdsT1OGqnfqYsG1OisA-1 Received: by mail-wm1-f71.google.com with SMTP id fl26-20020a05600c0b9a00b003f17448df9aso338566wmb.3 for ; Mon, 17 Apr 2023 03:33:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681727583; x=1684319583; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xfhFkFEXd/Fa/v20KkaXF/K4tKRiXQWpPAFsCwHLV14=; b=jPy4en+b1EfgUFAEi14vhan5QxKWE6UVm3vRmPOh8Uyx8dPXPn/6erhezR9M7Do1Pg GLDX3OG7+0lq8hB6Eox8msaRPqhES7mQ8ajaS9CZj/0CK2h0G1a67pN3/7WkZbj1lYw8 Ofqc9TEr00sf+pLmDR1IkKcLcfUq4q/4bF8qVDb7IdC9M1pzrJhaPjp3HZQTpskroNgR Ss1fOTruFT5Fv0lzMN/5E+rSKbIqv5OclubYCwchyWhevq6ywFgra7qVKkkBIL5br0NI c80QXK/SCpxUHn6vDPEPOaI+Mftdy+8I/mjD5w7t0SPAHEB5MnKPrh2jp2al4rvTnFF6 pIPA== X-Gm-Message-State: AAQBX9cV2xPjnnUqg72bpYb/Jnq18JYTG9MvS2gF89hB/BoXggkxgYnU /vKsXws712kM/5VeZE2in7bgzzgbOlTBE/gLiDVmG5koQv8D5tAiys/BjYQMeIuVFPinPChKRtU 7Dmusqtjyr/s= X-Received: by 2002:a1c:7503:0:b0:3f0:683d:224d with SMTP id o3-20020a1c7503000000b003f0683d224dmr10259140wmc.9.1681727583534; Mon, 17 Apr 2023 03:33:03 -0700 (PDT) X-Google-Smtp-Source: AKy350YlRgN48Ut0i+E/LSX71GzFA10WpzH2YXeQC4oarpyBOopbIwKkr0lyoQSMvsGjH2bHHX2PMQ== X-Received: by 2002:a1c:7503:0:b0:3f0:683d:224d with SMTP id o3-20020a1c7503000000b003f0683d224dmr10259126wmc.9.1681727583198; Mon, 17 Apr 2023 03:33:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id v21-20020a05600c471500b003ef5bb63f13sm15221389wmo.10.2023.04.17.03.33.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 03:33:02 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 12:33:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] userfaultfd: use helper function range_in_vma() To: Peng Zhang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: mike.kravetz@oracle.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20230417003919.930515-1-zhangpeng362@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230417003919.930515-1-zhangpeng362@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 94A8C40017 X-Stat-Signature: wacgni5oa7okq7w7aq5mpsjx8cdjygfx X-HE-Tag: 1681727586-466471 X-HE-Meta: U2FsdGVkX1/OPXBql9qe/6b2kTHv0XL/G76rOPGDbf/U3qnkNYSoRGHq6LiTzEsYjsLU+pzoWbtb0xTPwi8GRp/C5F8zYXQ8BR2IPk4smFvA3OQiYcBUe0LAn7oyQfkDavKj8xt1X4AZGWREzkdbYtDqLOMmWPF82vdjJd03uKmX/oxUa2Wfepl8sgSTrov8Nkji3BpivMnWPooATHJLrsmowOcpI5cbBHGEApOV4nOBQT1RoIWlB9dAdifDZ1ObMrQ6Sg6XOJlwmJlPKGngXSrxMqqj2ghenWej44qe1KAT4dH42rqMUoDofU5gv5wTbCIwpuRfRdG/ZmU6fbLbPrYZiVci8XVQG/PVXBA4iHKztIDA13Le/CO0wctnt+Xf+j1CcINtyz//hfZnbv3xD2Uyi1qcah1HFxThPptFDeej3l0+CTkcvhg8i2XwLHgfkWLBSB27uBmMz6i8reHpYZUIgrZerVVeTckfPrsKpyN2WekbGvbAkDOvPpbkWgNdkf1RIk5brpg4OvIS8FXcGfuNt5MIbJohlhu7EuXWXNy1g6vJoukP6rylCFeR7QAD7in03vFX1qHtQHQOcvUVumZYHtmvD4jVqwybvSle0fcthn8xLeZJyCPUyS0R3T+Nu+208In+dYl37zOG7heG4J2rvb+KnIO458+GnpxhZsbdB/yqpbF912wKka1Gk0JPuefC4ad7OSJ+dpc1if7/MjGWEqLYbJrtg8wl1mqkYFS+c9OYnD1Be4KE/OVUgBedPevfjRM1bLcgsdvqBAFoiqZldv9QUnGMLfZuFf6drBFsAxu/7To2bWCRqCJgXCnRXtigBRgJKeYUrbv5kXHaGW/EY4gHtoQSdlxVcl/swhQOOirViZ0l+HRdXYZujytivlpx/oBjjjSY5fkayWAFPW43JVGrCczOQk+ZcSycURuPPyZbF/TVqa5NZi6g1Xnhr9OrZZap7soVomJ1bFT 31INC81G DfSt8G9jJtYzdqfGcyPX7AUy6CaZGQz6Ldi6xUBLV+u3ytdGzA9vuZ6z0ThSysgxA+hEtdMaXW+tsrMQqBPLSOjiXlOsDKX42JKg9ZctMpoNQeb0eHH+jRuwAzLaZ29P2h4P0IKdkMfcXfkZ9lIYvIYCk7k8wHRL/brCYreHROuwRezRMfDDIio5V8wZEqVi9QgS7ATTgJCsLnBcv6OiJ9VOhAN8u+SbvRYWjp7v8p/4R68piIDoyPqjFaqJUg4n6qvI4JjRnDFKglJNK9l7uQrqViKbOkJRzbluUYEzDnFgKD077iJuyH5s82CsVHK4XRp2Jvy49tnTvMDgIqrWytId3WNks277gQP8cR0MNSUa6jiAG5syBCZ3eQ0GFk05AW76IODvJM3TPj89cMAD7RtSa7Ti5Dt0kbwpYJHexfF0C6x3aD8snMDee4F6Ve/A5cy0i9Dv2chf/8MScjJkGEuBovhYt0F9KSjWVB6ZW1RvUE5UyiWhWAfDLBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.04.23 02:39, Peng Zhang wrote: > From: ZhangPeng > > We could use range_in_vma() to check if dst_start, dst_start + len are > within the dst_vma range. Minor readability improvement. > > Signed-off-by: ZhangPeng > --- > mm/userfaultfd.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > index 11cfd82c6726..e97a0b4889fc 100644 > --- a/mm/userfaultfd.c > +++ b/mm/userfaultfd.c > @@ -31,11 +31,7 @@ struct vm_area_struct *find_dst_vma(struct mm_struct *dst_mm, > struct vm_area_struct *dst_vma; > > dst_vma = find_vma(dst_mm, dst_start); > - if (!dst_vma) > - return NULL; > - > - if (dst_start < dst_vma->vm_start || > - dst_start + len > dst_vma->vm_end) > + if (!range_in_vma(dst_vma, dst_start, dst_start + len)) > return NULL; > > /* Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb