From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82490C433DB for ; Mon, 22 Mar 2021 14:44:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F0C8761925 for ; Mon, 22 Mar 2021 14:44:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0C8761925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D24086B00DC; Mon, 22 Mar 2021 10:25:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFAC46B00DE; Mon, 22 Mar 2021 10:25:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77126B00DF; Mon, 22 Mar 2021 10:25:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 92C1F6B00DC for ; Mon, 22 Mar 2021 10:25:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F2CD48E63 for ; Mon, 22 Mar 2021 14:44:10 +0000 (UTC) X-FDA: 77947780260.06.A9E564E Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 21708A004CE9 for ; Mon, 22 Mar 2021 14:44:08 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id b83so21685016lfd.11 for ; Mon, 22 Mar 2021 07:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zI0qMXNSeXWkmjLx/rxCTs/IrQfMrB84lSC45WohEb8=; b=NySQEmQrIYpVG8gZNVHI3CiB/LYRUq/j8d2JALKnJeonlnt7lcmfMUIyIATzNJcA7f UB1avLvIgVeKONz/Rixb5wh6B2NKqnLLEXmt/cGnAuL5EVT5dlc8hNMXZLCAWsBiDIFm MPAWxXiHDIFJwO9jEAMvsTiVQgSLnRnasdCvrJe/WKG90OqoUqPSUczbv69B1RPjnRha hx6Bs/PP2zkB3qEf6BKSrALmVvYmWdlJa1aW/boTGtFHSGEkFgfRJxpaY5z+7xkrPTBY vdzzVxqef/hI9b73tdbhPSu8ek0zFLYHAPjpniXsclLfX8rjB8QTfGvDnc8mxOy/13Nr 2YbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zI0qMXNSeXWkmjLx/rxCTs/IrQfMrB84lSC45WohEb8=; b=KgxJasDOvJvr2RqZ/jOaFr0Y+885liCNKgyx7p5X/LpPec9j2wtMAUhBKKEYOl+ZAt IDnNo5W5lhUF0CQV9nOD+gK6bfpi7IcXZAwKz4eyP9eOi7Z3tuStAcOD6YKHJkcva7ao yEvn+fBQp8BaKkSqQWZMq4Kh9kLdVqBoQ2/5haW/XzSz5JIBpbDnmt8mKZ2dcHffpzHW kv9S8jHgEBYCFGHe6ZEsBGaFlib7+hUTiRjlEqY2WYUzZDBJZj1z32M5ZVPi0HE/+x9/ litomT9cmMS2eeMsFSit3ON4XDlG5z6W1UHgPA/HWeNuY0AgG6RN6BeJirME5siB87e0 aITg== X-Gm-Message-State: AOAM533gt7sj/pnykPUGSjr9KMagj5LsBUdzR+bGLQGvdughQ2z4EZ/w LvATXqTb2I7uUUx3WIkOWNE= X-Google-Smtp-Source: ABdhPJx2YjtSABIyhLogShpdxcRRiP93mE0TfM35++ovOTjixhAhhfSNg7EBX0ODwNki3akHFtGy8w== X-Received: by 2002:ac2:5449:: with SMTP id d9mr8856236lfn.172.1616424241809; Mon, 22 Mar 2021 07:44:01 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-47.dynamic.spd-mgts.ru. [109.252.193.47]) by smtp.googlemail.com with ESMTPSA id v6sm648251lft.167.2021.03.22.07.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 07:44:00 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Greg Kroah-Hartman Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <071c6681-f492-2c94-5686-30c30778f39d@gmail.com> <007c0317-8819-a6b8-fdff-c0b5899c4f51@gmail.com> From: Dmitry Osipenko Message-ID: Date: Mon, 22 Mar 2021 17:44:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: yuzz1q15wcoi7f7e4yt6o6wfi5fgfasn X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 21708A004CE9 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-lf1-f41.google.com; client-ip=209.85.167.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616424248-683622 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 20.03.2021 10:52, Greg Kroah-Hartman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: .. >> I found the Greg's original argument and not sure that it's really >> worthwhile to worry about the copycats since this is not a driver's co= de.. >> >> Maybe we could just add a clarifying comment for the kobj, telling why >> it's okay for CMA. Greg, doesn't it sound like a good compromise to yo= u? >=20 > Please no. >=20 In the case of a static objects, like CMA, this creates more bad than good, IMO. Even experienced developers are getting confused. In the end it's up to you guys to decide what to choose, either way will work.