From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD3B2C71136 for ; Fri, 13 Jun 2025 18:01:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5934E6B0092; Fri, 13 Jun 2025 14:01:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56ADD6B0093; Fri, 13 Jun 2025 14:01:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 480956B0095; Fri, 13 Jun 2025 14:01:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 298936B0092 for ; Fri, 13 Jun 2025 14:01:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A7A455DB30 for ; Fri, 13 Jun 2025 18:01:28 +0000 (UTC) X-FDA: 83551144656.29.E4A262B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 2FD6840010 for ; Fri, 13 Jun 2025 18:01:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iWmIvcap; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749837686; a=rsa-sha256; cv=none; b=31CHPb28XxVDtU9BXrHEjjmb2ARn2QMQk672Uz5r0jLD2/KRwb8wsyd+YWZC8iFrTn3WON JGpmZm6/dZrIspo5FtIwxsXwgtNPftKsUnTxk8cVnaeXLhbeuEvsvNnjUEFi3UfDXg+YQ8 RSLlJfsGNnvvBsXCv0DRqMlOLmosHgI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iWmIvcap; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749837686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bsu+Wcnjd7wtWlxV8RLC0OdC2mEBW/GepWDmRtxUl30=; b=SfLOPUlwOkUp37BLhq41hsB6L8T+cM+hUYrkcsSWufmHt4GtqJ8jnYs0apKo8cWHgR8peZ A0gkUUmohjJVT05xYlYO3ZY8n9NVl2j3SppYr3UEZF5++KB6m+llL9/OUZLe9b9/5Q9+Jt U6py09PUVm0cYzR5XMCxcQVPEYRYJGA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749837685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Bsu+Wcnjd7wtWlxV8RLC0OdC2mEBW/GepWDmRtxUl30=; b=iWmIvcapoyls/asa1/FiQBA5vpGTURBpQLPIDs5zcqCU3i3HelUn4AGHw5v9zXJTJ40y51 Y+XS0LI7Au29i3tZbZ/ADwTCwjr5qw6A8WFZnuIwG7mABmFmeyN4HYw8rkrJiSST7u4Ffq lg0Y8YXFeygWUbgbdhOU/DphB0M1p3E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-J4dxXEXrMLq189QKmgptXA-1; Fri, 13 Jun 2025 14:01:22 -0400 X-MC-Unique: J4dxXEXrMLq189QKmgptXA-1 X-Mimecast-MFC-AGG-ID: J4dxXEXrMLq189QKmgptXA_1749837682 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4e713e05bso1323584f8f.3 for ; Fri, 13 Jun 2025 11:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749837682; x=1750442482; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Bsu+Wcnjd7wtWlxV8RLC0OdC2mEBW/GepWDmRtxUl30=; b=RZYggwY8y2q6Gj5XquR7SU556tiT0i0JK/J9B9LMUuPyHpWy4CUmaZUSOOozKTZOZB g6R6iqObhWTcsYctjVygbIYVXvRCQe+YjBXyUnDAnFbPPUUgo8wLh/cOre/vW0g9lOKC /VcJRKKt2auhvM+shRWqdHcWywY1rslSVO/ahaJl6QwNS0vENxb/2XS1Y0gVVpop9j97 MxwZpdEOSxIfAWJzux2IBZltKV//6Z4nnZInlHDJFLEGDSbFpDg8QxCn3MzXhTejcW7M M0e+9qtIppfy+Uh55Pljw9enm799l4p93c/FXSaNXaB/naSg/Fob+VXdSNuUy8JaD14A 0yKw== X-Forwarded-Encrypted: i=1; AJvYcCXpsKHWm64tGqIy93rFtxWootxfSOrntVr3lxOux1567O9ZCH8To4LmBcHscJ2YJcqCB4Kc874wRA==@kvack.org X-Gm-Message-State: AOJu0YxhZdbUmeSC3CSXgXIvrLSRvcd9gyHiCrQVH2AV+saWDVBb0s5x qDHwFmcdI157a+9d9GQVPHp3ji1PylKPvmb2mkgdobF0ciQW5il2Y20eEyk5oPhrLEwDODCsIEK 1ym55+Jr7++zb1rB3ME3/iJFa90nF5scLWpl/2v/HOtBofLKTSEhT X-Gm-Gg: ASbGnct6BHx6pgGNOmAVzE258EuBXUd9Ay8xi+ky++Wlf7o3vMSLgmR43n87+YPnejV mkFldTluxeCTCg3nP9nvlHZYWkIkl81/tt5SimUQEbftHrRPyCsaa7sNOaOPCPsyr3vOj+Vtb91 GftNq5/vIMKq3FIn+x8KQsPKagCBJwMgO8DPomLYl4C+eRQQ7EQzsIlc5g30fpCFECBU5OGHJXL QSQ2wG1B5eRQSU+jeL3H3GUhkduCuj6YCYeK1Czc0eFvG1SLV2YXPY3HlfdIHuYDWTorz9INk4T WZ/IHCmKEcUhejf/Ft6elKv0H/J6tu05f1FmjSg/vNXwWxy0QLbyBMTPWe/K74adYfJ7vlKuyqM HRhalf0queppALj+ND/SrXXTOQjkBDRan4nGdURGQlR62aFWFZw== X-Received: by 2002:a05:6000:2310:b0:3a4:eed9:755d with SMTP id ffacd0b85a97d-3a5723679c2mr776519f8f.3.1749837681551; Fri, 13 Jun 2025 11:01:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWRgs9/eOjv6Ni0Z0GgYf1+t6oOJ0Vg7B/D9l25oYMJ7KcIy5VjWpy1ryHHls/6YKXmWWXpA== X-Received: by 2002:a05:6000:2310:b0:3a4:eed9:755d with SMTP id ffacd0b85a97d-3a5723679c2mr776461f8f.3.1749837681034; Fri, 13 Jun 2025 11:01:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b089c2sm3004716f8f.59.2025.06.13.11.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 11:01:20 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 20:01:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm/hugetlb: Remove prepare_hugepage_range() To: Peter Xu , Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Jason Gunthorpe , Alex Mastro , Nico Pache , Huacai Chen , Thomas Bogendoerfer , Muchun Song , Oscar Salvador , loongarch@lists.linux.dev, linux-mips@vger.kernel.org References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-3-peterx@redhat.com> <050B65EF-6A1E-44A8-87D5-152FA9A60641@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kVbYHNZbZaPR6TSS2LwcZ3VqcL5CDY5NCXC-FOJpn4s_1749837682 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: f3z3okx5ebt96r56161phrc3azpe5pc8 X-Rspamd-Queue-Id: 2FD6840010 X-Rspam-User: X-HE-Tag: 1749837686-960074 X-HE-Meta: U2FsdGVkX1+doX5cgBUIGOS1ByFndZgUF6Zg/aWlEdfyfnmnAx/TpAU7Ds8sjI3gdCXzFQ29qTXBr2gXbLhl+8tbz1klJfOsuYu0MC/wWisIC1Eo934UdUVXT0/RQvCSxw6xaLgXIzCoESukJ5K311ideGrIU/swSoJ0DUpvB0k4p9m6VwCicjbvHZLcv+0FwKXgBVjj0QotwswrZnYe5/vQmxRrV/v0Eg47NmVyG8eJFf98N/VXWDwfGfrKE6bIkL/MBHe07sp4qGxUILqoW0A20WC8I4iiKhzH5HcYpHmMWfM17ahESigC+E8rahhW6O8JriEDKCqDUkh22dlANSmeUW0FBLcN+3CzbyAiYTlRPdSNBF59NCTKN9ptalTeeviKsw6sX9zEUDCGbJuF1YelDMxTWIy7WVQ45FIddSlolowtgwIpzb9cegxk+Osk4qMzo43PwhFUDSwL9mEaep+gZGP6vFHInAcC4z0SSqlNGY9cq8e7rLraZR/36aPoubosDC1ZjB0qgq1fzQpkEXpHNUQIQikP6AmMeC0XAQ+/1wHEJZpmSbRws/kJcW9oX4lGtlE7e2B8OMjBBPdij91sZRoZc0Ljx7U2jhRgbkYnsMLDZB3nxEOZNJJrstZaPsico5tOKcRawe7vBv44XGrBOb5ZAd9emAcy0X3TMtG9vi1v+qc+/1jS4Slx9pRQSiEQD4qFmJfa6yeiBSmD3JZMNoDtzr5ZdzNXELz9KtNj/IaZUBiyhcoUtVawAbpKqdq/hE9VFw2sC4TEQV721qQ3eagJ9wJs4D/OSxLl+pjYOR6E8cYPuyEDyQYRy3sXkuypb2+bS3n2QOqZcXbdMILjI733o53ghqCclEPOrpFkqQwLA6JjsOGUGS04kssBytCnt+bMut6R1sY+nItWAWkfYk09eZI57R8tpyr0ei7IYmbQVxLzJMAl/LJIaiOfeeG7nKIhwVi6lcbmipr PzF6Ha+z TwLgc9kGvuu0utXNc4y/RgjJR5hwgUL2Rt86rvwRfc5txhLY5eVmOyRpdsHbDzd/diF2W8Vl/TF8XkUtkDwTs2WbvXHYoPgC9bt8Rx1TXM/jLCi//AR5T4z1IUXPt8AJ12jhn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > But if we want to be super accurate, it's indeed different, in that the old > hugetlb code was checking stack top with STACK_TOP, which is > mips_stack_top() for MIPS: it's a value that might be slightly less than > TASK_SIZE.. > > So strictly speaking, there's indeed a trivial difference on the oddity of > defining stack top, but my guess is nothing will be affected. I can add > some explanation into the commit message in that case. Yeah, that would be good. Acked-by: David Hildenbrand -- Cheers, David / dhildenb