From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4916EECAAD3 for ; Fri, 9 Sep 2022 11:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C68318D0003; Fri, 9 Sep 2022 07:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF0498D0002; Fri, 9 Sep 2022 07:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6AC88D0003; Fri, 9 Sep 2022 07:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 917D08D0002 for ; Fri, 9 Sep 2022 07:31:06 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5A410412D7 for ; Fri, 9 Sep 2022 11:31:06 +0000 (UTC) X-FDA: 79892330532.31.52B347C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id D9DDC40080 for ; Fri, 9 Sep 2022 11:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662723065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8mO4V6+jC7+cyazFgx5SIaIZ4GrrkSJvMkGYj1DVsk=; b=dNqRjoDH2v6E6Cb1WlI93jQfqQWVTCec0TsUf4DyBJr/97DY4by0HVGV7HyH8PV2pgXly3 LVFezF+Hew8w63SPuKgMEFg/p3m/nde8LuM0vl7qzA+9UsXKJ3oUpehHqN4dAz/VNcxUZ8 91P3O9wMSyJRcSpYjgR//ai9C0hsDAk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-77-4Nc2pyNTM9Cg7yatcsM0aw-1; Fri, 09 Sep 2022 07:31:04 -0400 X-MC-Unique: 4Nc2pyNTM9Cg7yatcsM0aw-1 Received: by mail-wm1-f72.google.com with SMTP id q16-20020a1cf310000000b003a626026ed1so410199wmq.4 for ; Fri, 09 Sep 2022 04:31:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=P8mO4V6+jC7+cyazFgx5SIaIZ4GrrkSJvMkGYj1DVsk=; b=GOuY3lWrSvdTFNkZgtuG+Pmihti4YwhA6o6t5W8FBCa4JPP3RzW6bfuaj907D+D1gT GJcKmcWbXU2kqc/fZuNRPwZmljCCLssMj8+XfCZ1ndPZck6AT0d+D/JhBUhHNnx5oeFj NETQzrgOenfB4F+rpqI6BnfxO86VBe1EnGx0vDc3KIIYRwttjxkEGhuv3DMKQj5nnkqg uNd8uYVJmfitSd1r1nzMB0FHAl/F2o2i/ihhVI/DqLx2+EQmJz4c8QBtr/9qJ9D7OQHz ljqilXJN8cVkaQMEg9/PCb1htM+XGC4NQZS2wEPy5er+hXcH1VoEDzF0LGlplrMOjarT WTXA== X-Gm-Message-State: ACgBeo3qYHrQTBKVnjkfxk1+VO1V1K+x/DdEtelIae7nfAyX6A1j3P/a /X1Gwq8Wra+icO7+k5+pKgtj82PyS5nzG10P7fo42ZOoTffyWXE0xhUR2jb4cNvMKvtk+f5+vb8 mbO+pVanTBPs= X-Received: by 2002:a05:600c:19d3:b0:3a8:3b06:655a with SMTP id u19-20020a05600c19d300b003a83b06655amr5127032wmq.182.1662723063240; Fri, 09 Sep 2022 04:31:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR4TfAgMHxcpdIObPHE5KB51ObDNCFmGK3bD6l24TQQxpmch5NWDx4j2npqP0ibnJCL/BeklgQ== X-Received: by 2002:a05:600c:19d3:b0:3a8:3b06:655a with SMTP id u19-20020a05600c19d300b003a83b06655amr5127014wmq.182.1662723062925; Fri, 09 Sep 2022 04:31:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id q127-20020a1c4385000000b003a5f54e3bbbsm307401wma.38.2022.09.09.04.31.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:31:02 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 13:31:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 08/16] mm/page_alloc: add missing is_migrate_isolate() check in set_page_guard() To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-9-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-9-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662723066; a=rsa-sha256; cv=none; b=qeHqiVxp7GRnVgF7CGWBDAOC7ZVNB3uOUcRiP2wZTpjYtA43i0eNY1ExAFB52qoN3Jk3NH LqtVQQ1dOXq3+FmGv5AO+f8aOOIQ67zEYwiRzMsIRFBDqpvYOxiay/2y000r/DPhFo2cCK C0Elw6p2YmjPJer++tEt/Jc7inhimt8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dNqRjoDH; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662723066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P8mO4V6+jC7+cyazFgx5SIaIZ4GrrkSJvMkGYj1DVsk=; b=fMdQ+X0UXrJEDEPRa8WsDjs7hn2N+r6apsisZFPESIBfa5Uy4wVdPWGfKzG5Nm4yA2eh4v P4uFmp1VgOkvwXts7mwj0SLzID4YtwlfntQ+pkherJ1ZEOsKcaR6+9qS8KKOTjzUZFshem 0JIJJUE6akyYhI5JTEnVLuZ/zm2EhZI= X-Rspamd-Queue-Id: D9DDC40080 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dNqRjoDH; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: b7ax3n8ybgs9bo1y7ntkb7p56tgco598 X-HE-Tag: 1662723065-327143 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > In MIGRATE_ISOLATE case, zone freepage state shouldn't be modified as > caller will take care of it. Add missing is_migrate_isolate() here to > avoid possible unbalanced freepage state. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index a35ef385d906..94baf33da865 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -873,7 +873,8 @@ static inline bool set_page_guard(struct zone *zone, struct page *page, > INIT_LIST_HEAD(&page->buddy_list); > set_page_private(page, order); > /* Guard pages are not available for any usage */ > - __mod_zone_freepage_state(zone, -(1 << order), migratetype); > + if (!is_migrate_isolate(migratetype)) > + __mod_zone_freepage_state(zone, -(1 << order), migratetype); > > return true; > } Do we have a fixes: tag for this one? Can it even happen that the pageblock is isolated when we end up in this function? IIUC, we'd have an allocation in an isolated pageblock, which would be wrong already? -- Thanks, David / dhildenb