Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Josef Bacik <josef@toxicpanda.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>
Cc: Vlastimil Babka <vbabka@kernel.org>, Jann Horn <jannh@google.com>,
	Pedro Falcato <pfalcato@suse.de>,
	Muchun Song <muchun.song@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	linux-mm@kvack.org
Subject: Re: [PATCH RFC 0/7] mm: let vm_ops->open() fail for hugetlb
Date: Sun, 22 Nov 2026 17:05:25 +0100	[thread overview]
Message-ID: <e95ddb9d-4608-44e4-8602-2b07ed656901@kernel.org> (raw)
In-Reply-To: <20261118-b4-vma-open-fail-v1-0-c8b0209f2700@toxicpanda.com>

On 11/18/26 18:00, Josef Bacik wrote:
> Hello,
> 
> vm_ops->open() can't fail, so anything that allocates in it has to hide the
> failure.  hugetlb is the one I care about: if it can't allocate the VMA lock
> for a shared mapping it carries on without one, and faults can then race
> with truncation.

I'll leave the final decision to VMA maintainers, but for me this is the right
thing to do and I'm sure it will come handy in the future.

(I have the faint recollection of people having to work around ->open not being
able to fail in weird ways.

-- 
Cheers,

David


      parent reply	other threads:[~2026-11-22 16:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:00 [PATCH RFC 0/7] mm: let vm_ops->open() fail for hugetlb Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 1/7] treewide: make vm_ops->open() return an int Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 2/7] mm/vma: fail the split if vm_ops->open() fails Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 3/7] mm/vma: fail copy_vma() " Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 4/7] mm/nommu: fail the split " Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 5/7] mm/mmap: fail the fork " Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 6/7] mm/hugetlb: fail if the VMA lock can't be allocated Josef Bacik
2026-11-18 17:00 ` [PATCH RFC 7/7] tools/testing/vma: test a failing vm_ops->open() Josef Bacik
2026-11-22 16:05 ` David Hildenbrand (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e95ddb9d-4608-44e4-8602-2b07ed656901@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=jannh@google.com \
    --cc=josef@toxicpanda.com \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=pfalcato@suse.de \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox