From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092ECD42B97 for ; Tue, 12 Nov 2024 15:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68F1E6B00A4; Tue, 12 Nov 2024 10:14:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 618F96B00A5; Tue, 12 Nov 2024 10:14:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 490A86B00A7; Tue, 12 Nov 2024 10:14:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 21A016B00A4 for ; Tue, 12 Nov 2024 10:14:34 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CA5031202A8 for ; Tue, 12 Nov 2024 15:14:33 +0000 (UTC) X-FDA: 82777786728.20.C496173 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 01E61C0019 for ; Tue, 12 Nov 2024 15:13:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=vusUXCI4; dmarc=none; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.167.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731424409; a=rsa-sha256; cv=none; b=uNDdmmSqdEtoFcOuu6M3Bue9pa1ajJHtyWS6Aq/lpPMO3HIrhGwCsnlP5s0IDIvd9ncbcV 7NIXRX+a2jXWnKDjdBXi/JI+UzDqYAgM/Vvfk6g3CGNJF+x+rzSVvJS/kklAWwqaFRhsn8 RH2RvA1zGnUMAfYHqk7v/EfNW9E1WnA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=vusUXCI4; dmarc=none; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.167.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731424409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMz623KukwCRCwVdjpn5ENIcLZ5bWxNUSBajZwamIfs=; b=sxL9L0baEVf6Z7ifyogUR8xEOi4vnvaUTIg8eEFXT7WgKSgRg4M+MYEsxd0dGUnZwxeyu+ /YYwQQ7as0QKW7x9DEGFmuNsqpUS4ryYWTSP5Ldp1a6MCkarsLWeUPR+G8s4P3cdVRr0CR SN+6Iu+dK03+uBepWCIhEfrB2ugpOYE= Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3e5fa17a79dso3535397b6e.1 for ; Tue, 12 Nov 2024 07:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731424470; x=1732029270; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZMz623KukwCRCwVdjpn5ENIcLZ5bWxNUSBajZwamIfs=; b=vusUXCI43WY8cn3KLjV708sEb7Ss2tsM1H4JMwRZ/aYf4gT04iCn4BHpSc1g35H9B0 I1fszuB5yn9JwEXk0yFBNvK0+dBMMZ3ZyYHNW3shE6yPKQVBfrmnK0VRoaXLq7LsfNPR 7XOVZN60W4/brbV1hkUPNDGRzg3umY+ZD3WNvCMU4o/NPwtOGxITgzCVagAiqZos2Y6S buoQrAszco6woRF+sDB9sk7TxLHEFz4guRKxPT7iEDgsuTSOiNYauCZKA3czOQfe0GmQ iVEs2750q2qh/4fFB27AiE0t/j49sis4fTJizxmoriI/9yzhunVDHhl5JFBMfZz8/1lk Irdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731424470; x=1732029270; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZMz623KukwCRCwVdjpn5ENIcLZ5bWxNUSBajZwamIfs=; b=qUO7BYoGxPTG4JQYOkFaWRdVtb5LclEL9RG2tRZX9Hti1VCW0s9q3BzCQNEzDz8vVw 7/yK9SKptWECuzzAuhcd2BT9R54uf1MwOr+pDzCwKf5nSupraYZ9UCTj1GEVaRrHEaC2 Y/ffp+vAWpDQ/1dbofy8Mb3SUtZL9igKf7zyKuxx+IJ7UjejRhd0rreN/446eLZK6wp1 kOqSYc0V/iJvQGFiIsxRdgsgreKnToeTW6t7H7j/iJGJ9lFHgTTJm5M1rQa+ng0iAMl4 OGorhRHPujAAQDTmWESeUMiK1fh0UufMbydzFSoGxpyT9+2M/dN7y45rGjnnTB0hG9db wVbA== X-Forwarded-Encrypted: i=1; AJvYcCUiA/nEJfyifGX9LDPxpb1DvdfkTbaUGyiun2W/tZrBUapHrB7ORQzDdzPDw7AY60XT6Y0Aa5SqHQ==@kvack.org X-Gm-Message-State: AOJu0YyUbLYO7SMsD65s6rdcCS46VIGI+jF+Qm5r/kBuxEz9KXSKBgxz +rp3ytzZyf9OAWp/ag+SHfnPYYrahqjhGkvNBGhzxKea/by4+5M1FAW7sY1BoL0= X-Google-Smtp-Source: AGHT+IHT/p345mEZBMk5iEPlL4UdfBp49t0367lnxgs3ykjFrEFDJjYG+ulQ12gnvLQ/q/yMlk8/Ag== X-Received: by 2002:a05:6870:1d1:b0:278:3de:c8de with SMTP id 586e51a60fabf-295cd08c5cdmr3167596fac.24.1731424470364; Tue, 12 Nov 2024 07:14:30 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-29546ed7ab3sm3542727fac.42.2024.11.12.07.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 07:14:29 -0800 (PST) Message-ID: Date: Tue, 12 Nov 2024 08:14:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/15] mm/filemap: add read support for RWF_UNCACHED To: Christoph Hellwig Cc: "Kirill A. Shutemov" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org References: <20241110152906.1747545-1-axboe@kernel.dk> <20241110152906.1747545-9-axboe@kernel.dk> <221590fa-b230-426a-a8ec-7f18b74044b8@kernel.dk> <04fd04b3-c19e-4192-b386-0487ab090417@kernel.dk> <31db6462-83d1-48b6-99b9-da38c399c767@kernel.dk> <3da73668-a954-47b9-b66d-bb2e719f5590@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 01E61C0019 X-Rspamd-Server: rspam11 X-Stat-Signature: xji7sacmog5d1dz71rmzgcp8x7cxesdp X-HE-Tag: 1731424428-249158 X-HE-Meta: U2FsdGVkX1+BL6ez2bnPCMYPggZszGOtOVYAJ6b9RED8PRLXFFEhWkIiVt9Z7ml2lfl7gebn+mlr10yiyBhyYPLMV9wwSZx5CL01vqIJC2RWLBd4niRkf7jmuj2Fzm2mUOBRk+g2eImCijFomfGEqqB63Y+kc9Na8siiC4Cnap31Y9HrRrdhzp4lFYOTb4h5rb5nnYBgzxIvT2ImoV5TZO+oQZ97+OkCSEwGxLZzvNB+olcEVxAPLcv52AUGnOSy7vJdsHD9ZurqUlnVo1ePSDyP1SR0OhxK9iOO69fn7B/Fs3b39j3D8Ie0NmGdrZgUyaedJv13LffeXftpVqkzEfNhYLGH8vKgMDzOTX56SJiW8SRdBTPuZuvI+9dc20kehFAAIjFpy8Sr3sA+uG+WW7wm2eNpktPa+sHQvcf/PSi3TY7okvoJKz6YSm0YRBr/4d/CPrIHxzw1XWkRVQdoulYLaRt7+TB5+SFqhiBvYh6iLpPgXLJ4okaWe7eRTORzZP69poCWGZ4NqWFA59D8htBgBZ0IgrtzOzJdOy/E2jcG6ruIvJq4dh+Xm3u3kBFq4Kqd5Cd3gpB/NsjNGuJ2Zm9OMpqliDd0I8STQ1GK4TbDKSzgOQOdkGeLPijHdIrR0rcyww/vStHwgMPkJzySeT2SFl4Mz8s05ITubTChLuYCUTMB1LNcqj7oBnnAj9f/76P4fcb8fMfs6rpbbEhzIl/T78rwYRYTo7Wng4AHSWBNEolV2dkicIaLip3akPPPnzPz3weOvBDBLnUNQ71LfG9QKdOFOSYdf0kcmPNJYAbDPVNhDg/YiqcoB04Y1Q/yzSkADk+e2KhAYQk7GGZXVHKOS8xKoMhj44k1Gr7M++HXy97/8Qpjl31JP4CXdI7Gx07RbPtD6KjIDgenMljUeOKLEUXlAivNPSfW1KwMytmdnwwbBC63kFKQFVmIKvOKJRDxK+N07UHEQWCVw7l ZMA9lUSb LHvzg6Ye0dJtYjVpT8ETnn2ECgHbTw2mGztygstXkrToFbtM0sEjzaREWAo0FVMIWM6BKa6vr+Mtm26XS0jbPagNI9UiP/O6p+r2qb3HZ8+DQ9hz8VpwCwEsZyR8BHUJ6lNrTMhIO4HC6b216odUie7x7lLAzsOev86p+LqtLuCrkl3ODzJdojWcT7HkEsHvG0kq1hJUaOmoUmu9uT3XNVOm+l4Ok1WSRJ+DmKTbdmQq2QbDbkbHZ2KjKXKm378/m4eUO3e9crSAEdAfq5+jiGm6KE6jUxU90DQRDC83mSPKLZjP3dDQFE/gH7U5qLevRXflF5erDx6Ru9KqfqBHBXwShkTUKb02cteTXL7Sv4Q851wlKqjFV5dsMQ6EMd2SpIOD6hl5sKp5Ta9KdP9VSupBBUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/11/24 10:13 PM, Christoph Hellwig wrote: > On Mon, Nov 11, 2024 at 04:42:25PM -0700, Jens Axboe wrote: >> Here's the slightly cleaned up version, this is the one I ran testing >> with. > > Looks reasonable to me, but you probably get better reviews on the > fstests lists. I'll send it out once this patchset is a bit closer to integration, there's the usual chicken and egg situation with it. For now, it's quite handy for my testing, found a few issues with this version. So thanks for the suggestion, sure beats writing more of your own test cases :-) -- Jens Axboe