From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED3AC433FE for ; Sat, 1 Oct 2022 08:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A1028D0002; Sat, 1 Oct 2022 04:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84F408D0001; Sat, 1 Oct 2022 04:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EFA58D0002; Sat, 1 Oct 2022 04:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5D6398D0001 for ; Sat, 1 Oct 2022 04:13:48 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 223D2AC25F for ; Sat, 1 Oct 2022 08:13:48 +0000 (UTC) X-FDA: 79971666936.17.2C2828C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id ED58E40010 for ; Sat, 1 Oct 2022 08:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664612026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M08d8mMJzKqyE4XeCsUdHwS/W+NoO/HZQNW27SDN4Bo=; b=et3Mc9qFOJskwP8kgWy/6R1YF2ADYUDgjq0FUNqSqWWj3zZORMkH5wFQFHTMrjX43+Gz5e OQL155FBaRaCQd9vHRfu493A3A+oTyCG/mfsr1FzyJ/wplyzmGx8X48tkz66BUkLjYudWw qvBQSFByk5XOExPn9BNnR+FYlExzXAI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-393-Heg0rw23MrOTSlAHCT3gpg-1; Sat, 01 Oct 2022 04:13:44 -0400 X-MC-Unique: Heg0rw23MrOTSlAHCT3gpg-1 Received: by mail-wm1-f70.google.com with SMTP id fc12-20020a05600c524c00b003b5054c70d3so3190807wmb.5 for ; Sat, 01 Oct 2022 01:13:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=M08d8mMJzKqyE4XeCsUdHwS/W+NoO/HZQNW27SDN4Bo=; b=MXMtpBLDZ71cbF+p68l2k1AgUMyeTObAdb4z/XxktaZyTN9vfSXt1BOald8aaT1cn3 B85viIPVMCp4z0HUkn8P3/lHv2irShl8BYHWdCxwL/joF+pfLLfV6etRi/wMUKMj8dEJ C/kxrsGX2rGj8xAoxcdOeneZoUn8k0d/OC/n2jXcYiqC5Z9XOSuMiZDU12zlEnQsPlLY 6N3L0OC21gEna03jgSIiZ1jmbsMCeShAIPQGvwPKenb5fwGnrgmAUo+lBU81435Hy9GQ bSeZAd32xfDJmmnxGZlfwgmmyvOIipnKFUnCudwKnXVt2yR8JJ6ZtssvQwlKcbBLryOg M+Kg== X-Gm-Message-State: ACrzQf2zY3IjDyrfbqWZaXvHjv4NgD+/TAhBZf9oJ3sYtRjkRUAHwDJb 9aZs4fcqT0hdwhWRCbUB6je05lwYnbdHyWpRjeF4SPs1zPN8xosquRQXi7xzxJ3JkbY8N12PTzK WOBIzHkq3oMs= X-Received: by 2002:a5d:414c:0:b0:22c:de8a:d233 with SMTP id c12-20020a5d414c000000b0022cde8ad233mr5789672wrq.194.1664612023736; Sat, 01 Oct 2022 01:13:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM59J3GMiF+4a1a0pX2sMbyZVeGafvQfLvRP8m46tATdItS6jpn5p/0CVb+9uH6Ql4pCwB6UDw== X-Received: by 2002:a5d:414c:0:b0:22c:de8a:d233 with SMTP id c12-20020a5d414c000000b0022cde8ad233mr5789640wrq.194.1664612023379; Sat, 01 Oct 2022 01:13:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c71e:300:9aa5:eac5:37df:f14? (p200300cbc71e03009aa5eac537df0f14.dip0.t-ipconnect.de. [2003:cb:c71e:300:9aa5:eac5:37df:f14]) by smtp.gmail.com with ESMTPSA id u8-20020a5d5148000000b0022e04bfa661sm3010049wrt.59.2022.10.01.01.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Oct 2022 01:13:43 -0700 (PDT) Message-ID: Date: Sat, 1 Oct 2022 10:13:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 4/7] mm/ksm: fix KSM COW breaking with userfaultfd-wp via FAULT_FLAG_UNSHARE To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan , Hugh Dickins , Vlastimil Babka , Peter Xu , Andrea Arcangeli , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , John Hubbard References: <20220930141931.174362-1-david@redhat.com> <20220930141931.174362-5-david@redhat.com> <20220930152742.55ee9c25b89ba483ec211be8@linux-foundation.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220930152742.55ee9c25b89ba483ec211be8@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664612027; a=rsa-sha256; cv=none; b=6QGuwmca0ymqim0F5T/X0jVpo65EjBYIHrzCqT9BVr8HxcyZP5aXnNxhkqCl+rKN+YfpT5 VAbsKRUOpx2XOz8+ovP7VelCyTch6X+DlO4muW2RosMsR+Hr3Xv+A00jDaPqJRM03ZIXtz ak8kf2Lf6UNlYnU38yvUeHeGHs8s/2A= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=et3Mc9qF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664612027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M08d8mMJzKqyE4XeCsUdHwS/W+NoO/HZQNW27SDN4Bo=; b=2C/QOnPJDaEmJUfuliELFlt3xsjMNy9KFQVdJIkuGLi0M05sPa2anXLn1X5clA/Zo2yVXm QEcfHKS0J7AZzCgvIQZ+4J+leDS27XHu0G4iDxcz/43NMFKBgzg4vrwLfe80cF32waCwFA 6apL95Fr92WpcM416wty4xsi50tjLWs= X-Stat-Signature: xxq1k1rbdgxidzm9kref7ioh1dapz9id X-Rspamd-Queue-Id: ED58E40010 X-Rspamd-Server: rspam04 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=et3Mc9qF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1664612026-475757 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.10.22 00:27, Andrew Morton wrote: > On Fri, 30 Sep 2022 16:19:28 +0200 David Hildenbrand wrote: > >> Let's stop breaking COW via a fake write fault and let's use >> FAULT_FLAG_UNSHARE instead. This avoids any wrong side effects of the fake >> write fault, such as mapping the PTE writable and marking the pte >> dirty/softdirty. >> >> Also, this fixes KSM interaction with userfaultfd-wp: when we have a KSM >> page that's write-protected by userfaultfd, break_ksm()->handle_mm_fault() >> will fail with VM_FAULT_SIGBUS and will simpy return in break_ksm() with 0. >> The warning in dmesg indicates this wrong handling: > > We're at -rc7. I'd prefer to avoid merging larger patchsets at this > time. Yes, this is 6.1 material. > > Is there some minimal fix for 6.0 and -stable? Or is the problem > non-serious enough to only fix it in 6.1 and later? > See the end of this lengthy patch description: "This is primarily a fix for KSM+userfaultfd-wp, however, the fake write fault was always questionable. As this fix is not easy to backport and it's not very critical, let's not cc stable." This can wait, thanks! -- Thanks, David / dhildenb