From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1636FC77B7F for ; Fri, 27 Jun 2025 15:11:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA8766B00B6; Fri, 27 Jun 2025 11:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A52DC6B00B7; Fri, 27 Jun 2025 11:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91ACE6B00B8; Fri, 27 Jun 2025 11:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7E1936B00B6 for ; Fri, 27 Jun 2025 11:11:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EBAA214023C for ; Fri, 27 Jun 2025 15:11:41 +0000 (UTC) X-FDA: 83601520002.04.CEF9683 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 3EEC3A0003 for ; Fri, 27 Jun 2025 15:11:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aXhXFbky; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751037099; a=rsa-sha256; cv=none; b=c0PD7R/0tbQbCEIO9FsUwCzPzDtVFCu4FNXSXiSCgk16yb4qI3RyWo/0yFmAF9r7XeqtCi RW85puqt3QbaejeLmm8Qe335HJWqQzI7ahmoVdR+5own1i7L+b1/XXZDCCecniRW/pEWbj 3XwNI0nV7uIB2uXFWTsZdKL3sCNZPEM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aXhXFbky; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751037099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+PNsEGmUdKDZVIiKSYv92rxKW85xGPPGhxRXNnfISEg=; b=zF82ijCqLZnPG47XvKFafRp/ko+HKYFjaz/H4wHw5rJ3L/bEW8yCmcSJGnjBOmdvVOJQkU ZvkdcPchxBWrKRW73V3pwtO55pYbw85vXhdhZBkOF0bBOyIxLdtZIq3sKHJmYwVPefTPS3 NohBoLKTyoar86R038DLJeAB5naw1a4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751037098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+PNsEGmUdKDZVIiKSYv92rxKW85xGPPGhxRXNnfISEg=; b=aXhXFbkyNC8IISaDP8KIQ/wAUj0GVNlRSJTTMF7beNUpr+shCaJxl8Oc8m7vsNqiSssAa3 EqpZxThOJCmdrwmfC2QCX6gHMA+hdZfRiWVMohLG1Uy6V7PjpUv99GYuZu9+E8ny+AP1J3 I+e6ttlxgbz5f7wz4eCdf4+J7EGALZU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-bzyHvucEOGeIG8vB7rqHcg-1; Fri, 27 Jun 2025 11:11:36 -0400 X-MC-Unique: bzyHvucEOGeIG8vB7rqHcg-1 X-Mimecast-MFC-AGG-ID: bzyHvucEOGeIG8vB7rqHcg_1751037095 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so1680643f8f.0 for ; Fri, 27 Jun 2025 08:11:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751037095; x=1751641895; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+PNsEGmUdKDZVIiKSYv92rxKW85xGPPGhxRXNnfISEg=; b=WrcusXAEhZJtAgGog+trXW9vYORsxwGzOHsqsSopjG7EFe4DpseBVyP+Q+J6bFUOdu 3Df/jNqiDXCIQOBweeE18yEZCYQwRshuXS4fgn04SS6F0NRJd018ojYJu1T7FaajNjSR vqAnOQThQ0W9S68nqBUOKAC41ORL1ARpu1t8O539XQgKnD10XIzr+u0GN0BRgbmZPPs0 JaYc7sDOjF1Am/WsXnp0S0Wwx45pLn0PUNMzISjvIR7Zf03xZudSintpx8QgOCVggUmk iBxrBQGlNffqmXAw0knymXyxHr5+JeVIxSPgXqBeqLAxU0Ww7sHKJgCMzX4XKnyidEzi y5TA== X-Forwarded-Encrypted: i=1; AJvYcCWS56x0cMpGBcJP3CsGXtRlCrICVyw5L7OO2gBJqokMzmyeRSxYrCCw0k0PWqWrI9xrRrNNE6BOnA==@kvack.org X-Gm-Message-State: AOJu0Yy0UPKnGMAu84ub58CTGHdlvRGB2283mBYTM5tlN+WVN7Auyh12 zSARkNwnRWJ00H/F9eZvAMWplRgG4rOFXAvcXRyZ4A4GNryAmR2DmcSoMGRdEXCozuISEkHvmz1 PVCrPe0olfCuO6bJMq2CxA0QW2ASAyRa2cEfBUD2QX/AgoP0WKbX9 X-Gm-Gg: ASbGncu74WjZfgLofOaoE94Obz022tDXVPN1ItHoTVw0h6N+0krX9aPX92CSiPm4idy /n+AawC/b/vWh+HAdywpgwQS0PLYsXZzBSW+harNOt4yrn7jkd6FU/WZCQ9TRfyqZm8iL/0VEYV /zzcQFvhJALfF7y8KxVoaxN4YLh10AKAQ99C+t0yeK3Cf6mVAYe5P/T0+jN7nFAawxUNeBv49/x n6JGqZuJwcLa+GHErhdE1tNf0NjAWAy/+Qoyug/r1K57AhixHf3KKHZ3Y1DyrKxvk9wVY4IjmLe ZZi/vo1CRAB8oL0E9GYYCJeF6I0j1+WU7jH+UWtWyjJ06xVC4Ikmj6AupEokCZSbr2JxM7BWuvJ SgpBAv8H/ge8uOEW+EAEBKWtxQhHMh9UGyu1+cMlSMraF5LPVlw== X-Received: by 2002:a05:6000:2304:b0:3a5:3993:3427 with SMTP id ffacd0b85a97d-3a98cd53803mr3567011f8f.26.1751037095368; Fri, 27 Jun 2025 08:11:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8Qgu2Jgl2J7TvZL3VLP5hIT3tuNl/X1NnEivDIyY3t6UUq5bn/J9s9D2KOD5yjpIyfdMP3A== X-Received: by 2002:a05:6000:2304:b0:3a5:3993:3427 with SMTP id ffacd0b85a97d-3a98cd53803mr3566938f8f.26.1751037094761; Fri, 27 Jun 2025 08:11:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:5d00:f1a3:2f30:6575:9425? (p200300d82f2d5d00f1a32f3065759425.dip0.t-ipconnect.de. [2003:d8:2f2d:5d00:f1a3:2f30:6575:9425]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e62144sm2997866f8f.92.2025.06.27.08.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 08:11:34 -0700 (PDT) Message-ID: Date: Fri, 27 Jun 2025 17:11:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() To: Lance Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-5-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uq486v1L3ngJ24sig4-3egjBnolqhAuEFyax_O_uN94_1751037095 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 3EEC3A0003 X-Rspamd-Server: rspam10 X-Stat-Signature: phwxu5tbzbsci3dapp8cyx854iyqd4ad X-HE-Tag: 1751037099-591781 X-HE-Meta: U2FsdGVkX18MXska5/qf9B7mSIUw3t/Oij/pnf+IMHY1wblAfquOf4xylHPFYNHAZxKdei9Z8zyPqVHjYHi899GzYquyznNoKnFJyeZjmfiaT6oM+5Kk+QANoTdbEuIzdrLsuTfb72c2eddJR10SEda8MJejc4vlPeXYMhwg62pspAQ5oWVEcc4ooGvdFB2J8g4PTecJi//p8NynpkcvjGAey7QE023fNKHv57prnvqrBGsO1PN8l+YpZLedNOiLcHvFKfSmXuf1CJSuKuphEsYZlhENQOk9ggU0SwqhuPWUK0kR4I/RXRCYVLg4wlQopMf33HyPpWLArYf6/op2pnvWM2NZBCZfBIvoe4Qi2b11Tg1gr71cEtoTd+kRMyUnaSRUBx1zLCMdSv0CRzEj92dCFzfqa3wVu07nPhcxFE9vXaJuS5k4lDYwl+9lynU4aseU3tp0UpRw7b4xIqr6GoPo/IY33Abu/+0ha21zU0XSakWpv1ALpuUiP4pSiRWdQ7th+CU2rkb6jqUgIH6E+hEpY9SRGVYT1LWDzBb4eULbPs7ArQ7fpQsdPhq8KYsrYR8S51ET2FwbQuuGXtvm4VfRzx1a6dpCoH49KON8GE87DmB6+W5p9VpyZDwCtFihbUI3iYVcnMrlFdfF9cI25BBl13tYxRLhGBQiFILYHAAJuqKHkfOnjPkqhlOp9Ga56fCjM8HNZhdIIr2Ot9InAHp3ABHLNc1YhZ4pgbOsSQjaYzDjECwJ3T1GKGbrAdWBEC7yDH5a0svEDn/MJJTcnoH94UWgHZNFgJmU+eSiOxHgWcfceWlxsLkawUL75kLnmynLWxQ1GSgq0hpGVDZw85QxlMFEvHD34KPL9WZsYpL1v0A2XApIyigdxHYY9GZrFbGEVWmCSIuXGOVMoPWILA/857dRotHUMkaE6E5ctT0xjGTfSTkqsbxbn1mOVTHQv4fuGMu0ouCdgJ7NhBm z7v1Mc4N mhnqGziF4apnOgn3UndM8nki0xiBJtZkSUjkxMc+AjcyU/Cl7EnSbMMd6rhhmNHaSHpkz5UN5ek7+Tu3TlKWeR+zv2A55RxHt4ppUyNnfALmgkILPAz9uFqF0Ei/pktHPMaXqcwnViF4Obh3FMHUUZ+78+bBQtR4sXPy7Dx+UJUJVJ2Mtes4huO63GNlcZTdPm+W9YvpUol+Z2ZVHM5kg8Yodc9Q66hxiuTrAixgA8oYN53oXqjvcTcLpHWVItgi0kzK3iHFt6KMHo5qFRGmvJqA5vCpkjsZm/xh1hVp+s0JWa2IibeY+A6lSeQprnlWcM9OB4C3bD+9V64vQLXZjOSOUZJFLGZF5lkrWlSkmFRJk9v7CTJPzAel0ZQrZereYqiUTzAbS0ooZgBJ/ltgqmlJWYa3tO6z/NbzQVyt9k2sHb6EQ0OnxZe0zjhlM4gsmTy3p7bLh4ZaTabjcnt/Q8joXSUi/JMDfIG6jLzlylzkgJ91X+30s9zbe6wi8MTy8UroF9emaUPid4vqQqcJyoSI6YR2R02Ov2+20SsPzembNzukde8EJvRbj7GCvgJ38YrlNpIhegGB3zVa4rUoDYdnGfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.06.25 16:34, Lance Yang wrote: > On Fri, Jun 27, 2025 at 7:55 PM David Hildenbrand wrote: >> >> Instead, let's just allow for specifying through flags whether we want >> to have bits merged into the original PTE. >> >> For the madvise() case, simplify by having only a single parameter for >> merging young+dirty. For madvise_cold_or_pageout_pte_range() merging the >> dirty bit is not required, but also not harmful. This code is not that >> performance critical after all to really force all micro-optimizations. > > IIRC, this work you've wanted to do for a long time - maybe even a year ago? Heh, maybe, I don't remember. For this user here, I realized that we might already check the existence of any_dirty at runtime -- because the compiler will not necessarily create two optimized functions. So we already have runtime checks ... instead of checking whether any_dirty == NULL, we now simply do the merging (checking for pte_young() instead) now. -- Cheers, David / dhildenb