From: Usama Arif <usamaarif642@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
david@redhat.com, linux-mm@kvack.org
Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, riel@surriel.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH 1/1] prctl: allow overriding system THP policy to always per process
Date: Wed, 7 May 2025 16:02:44 +0100 [thread overview]
Message-ID: <ea5b3a3f-9eaa-4335-b0ad-fb1a66a3149b@gmail.com> (raw)
In-Reply-To: <20250507141132.2773275-2-usamaarif642@gmail.com>
On 07/05/2025 15:00, Usama Arif wrote:
> Allowing override of global THP policy per process allows workloads
> that have shown to benefit from hugepages to do so, without regressing
> workloads that wouldn't benefit. This will allow such types of workloads
> to be run/stacked on the same machine.
>
> It also helps in rolling out hugepages in hyperscaler configurations
> for workloads that benefit from them, where a single THP policy is likely
> to be used across the entire fleet, and prctl will help override it.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
> include/linux/huge_mm.h | 3 ++-
> include/linux/mm_types.h | 7 ++-----
> include/uapi/linux/prctl.h | 3 +++
> kernel/sys.c | 16 ++++++++++++++++
> tools/include/uapi/linux/prctl.h | 3 +++
> .../perf/trace/beauty/include/uapi/linux/prctl.h | 3 +++
> 6 files changed, 29 insertions(+), 6 deletions(-)
>
I forgot to include the change for non-anon VMA, which Johannes pointed out (Thanks!)
The patch will require the below fixlet on top of it:
From b719cd28ae78de699c0f801a4283449f6ac767ad Mon Sep 17 00:00:00 2001
From: Usama Arif <usamaarif642@gmail.com>
Date: Wed, 7 May 2025 15:58:39 +0100
Subject: [PATCH] prctl: Allowing override of global THP policy per process
This is a fixlet for doing it for non-anon VMAs as well.
Signed-off-by: Usama Arif <usamaarif642@gmail.com>
---
mm/huge_memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 2780a12b25f0..c4bf8eae420c 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -177,7 +177,8 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,
*/
if (enforce_sysfs &&
(!hugepage_global_enabled() || (!(vm_flags & VM_HUGEPAGE) &&
- !hugepage_global_always())))
+ !hugepage_global_always()) ||
+ test_bit(MMF_THP_ALWAYS, &vma->vm_mm->flags)))
return 0;
/*
--
2.47.1
next prev parent reply other threads:[~2025-05-07 15:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 14:00 [PATCH 0/1] prctl: allow overriding system THP policy to always Usama Arif
2025-05-07 14:00 ` [PATCH 1/1] prctl: allow overriding system THP policy to always per process Usama Arif
2025-05-07 15:02 ` Usama Arif [this message]
2025-05-07 20:14 ` Zi Yan
2025-05-08 10:53 ` Usama Arif
2025-05-08 20:29 ` Zi Yan
2025-05-07 14:57 ` [PATCH 0/1] prctl: allow overriding system THP policy to always Zi Yan
2025-05-07 15:12 ` Usama Arif
2025-05-07 15:57 ` Zi Yan
2025-05-07 16:09 ` Usama Arif
2025-05-08 5:41 ` Yafang Shao
2025-05-08 16:04 ` Usama Arif
2025-05-09 2:15 ` Yafang Shao
2025-05-09 5:13 ` Johannes Weiner
2025-05-09 9:24 ` Yafang Shao
2025-05-09 9:30 ` David Hildenbrand
2025-05-09 9:43 ` Yafang Shao
2025-05-09 16:46 ` Johannes Weiner
2025-05-09 22:42 ` David Hildenbrand
2025-05-09 23:34 ` Zi Yan
2025-05-11 8:15 ` David Hildenbrand
2025-05-11 14:08 ` Usama Arif
2025-05-13 11:43 ` Yafang Shao
2025-05-13 12:04 ` David Hildenbrand
2025-05-11 2:08 ` Yafang Shao
2025-05-08 11:06 ` David Hildenbrand
2025-05-08 16:35 ` Usama Arif
2025-05-08 17:39 ` David Hildenbrand
2025-05-08 18:05 ` Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea5b3a3f-9eaa-4335-b0ad-fb1a66a3149b@gmail.com \
--to=usamaarif642@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox