From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE5F4C3ABC0 for ; Wed, 7 May 2025 15:02:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C6D56B0093; Wed, 7 May 2025 11:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99F886B0095; Wed, 7 May 2025 11:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83E3D6B0096; Wed, 7 May 2025 11:02:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 647196B0093 for ; Wed, 7 May 2025 11:02:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7715F1A0687 for ; Wed, 7 May 2025 15:02:51 +0000 (UTC) X-FDA: 83416428942.22.A5A5784 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf18.hostedemail.com (Postfix) with ESMTP id 5E6E71C0009 for ; Wed, 7 May 2025 15:02:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bboGIKRL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746630169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PvCQsEtnh2TDP3TsTaRREibOrpi3QlqsGJ0VRdAePO8=; b=nNW3f3gg7jS398fU1PuJxz84bklGMjRSvPL0bdpRw/k/NHIBIdnfh963psOW+wyNirloaN A0nfjDe2P8/q8QSHCp/1QKFPZA0El8HvJBmsgwXa1ahxgpljYOJYKmv66lTXNgZ3kBQ0Wo dUOMKD5WAwSv4835XEnQxK0aoliuYdU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bboGIKRL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746630169; a=rsa-sha256; cv=none; b=OLCxf9JiqXiMl+wZK1a8OHaC1xtVVAj/DHBhmmpF5UZWCpYtMJ6DL3OAsqRS9tZnlK+wug YAPt/R5nGl7tztmOYIXAqgzUOhjISKHEd8je/se57R1315GlxpmrjfjTXhgq+ephrN4zwh +yDxhJhwTdhUhqQjWqtLOO3Emfcd0Og= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ac2dfdf3c38so1277040766b.3 for ; Wed, 07 May 2025 08:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746630168; x=1747234968; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PvCQsEtnh2TDP3TsTaRREibOrpi3QlqsGJ0VRdAePO8=; b=bboGIKRL05AQ2w+ukFvtC65KhpwCMoKXYEtYW3FOCpfKNbRNxJoRtIRNOoKBWqLlf4 DT8G5PlXIlNDtdMW/XmcpcLdzkJ/11DRpAE7TrFA0WXcdSLD6k3YOPRfcmcWsuenVQY4 O4CHLSD3oeeeKSGYRxh31hHDRjV3rWN09DDlFGZhA+A35ZSnG0jzP37r50HfbV9oRRVt 6c13gkxTGC2v669kSpIvvRJo5z4hl1uC1dDqPezjNFQDcNGSaPKLCA2ErrwJhXXHa3AW IqktZoyBvf0PzPF7YwOLDmkA9PFnFZTZJ25W90+gGmVByGM8lanrX2g5Zna4Pdoz6xoX SwXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746630168; x=1747234968; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PvCQsEtnh2TDP3TsTaRREibOrpi3QlqsGJ0VRdAePO8=; b=s/3ad0V5gSwNOy4xHODw0376hJ3U04dDF5r4g5nZarJ/u6JPGUcDcOmNLYEx+j+ylr KzYsYXLCB0XaLvT8u/a4gIB865+IuRzerK/MI/HhtK7FcNCeTApmxHz1Lz5/RmgUVzde iPBWwWCW20moAuCstg63x5SQ6JRtLJXzRQCJ6aemiYrxc+hwD42ips5Jf5h/qah+feBT v3F0oCM3DI2ZYA0dktHPD11xONax0WkXSsqhScdaogtofSFlCl5PbqfOz+DmTON+oQaA CBNE+mV/Gf/bvMRpNQA9upi0aj14RK/o22ZrGLYQ/e2OC4fiLSjFo3CFQqIMKIJfASpq W19w== X-Forwarded-Encrypted: i=1; AJvYcCVqJ7mk19V2pY5iQYzQQv7+tQ7ApuIkbRGgD6Zv9oPP/QnhiuTPKdZNygvoy5rmDlKw1f7B3rpTQQ==@kvack.org X-Gm-Message-State: AOJu0YzxE101YJcP5ViAHE0DEI+wrfC/DsNb/8uEUhKBvqa7+16U1/U6 f6i2x5knhg9fWCQXkeVcOyp7VvJVMV1vFALVK+v5Ik6BijifiKjFy+F/wzUf X-Gm-Gg: ASbGncsCwlX1I+9sPFEqE/vXfHlxWmT2ENzkOwNzNyrsrMpLf793X8vHm8PJTBc0aTK FUGNCz/5/KtJGcH4ciE80ariAXHSfCh03RDgPTfs01Hi98qz/NrCWWp5WPCi7V0SoO/qWfnxX+H y+fRNUUXE2lnQPCAH6i3+3zDYVhwS2+m++6INBaWbEWWZ9TG5393ryv2KIkknOt9AxQBAd9lbbK 3nxp1qzux8zHPdai9ZSWAuggWNVY6OaWPtYbrQbZ73PkfMDQX7+Gq9ptsJHHwLIIuaP3qeJHPBU oaGupek2nIjAQUsc/n6j354Gqs1cqZQDDOYLV/gl0SNQXVx9rqVGR2imPziJdn0zNb02fYDRunk dXbtyQRUo8dGKQUGmIIc= X-Google-Smtp-Source: AGHT+IGplFhlmPdENtVOHblHI4Aifx/JZlKRDKVxCGNuhfO/rD2149FEo3+r3YoKDpHZypP8PzzeIg== X-Received: by 2002:a17:906:99d3:b0:ace:3f00:25f5 with SMTP id a640c23a62f3a-ad1e8c8c0bemr391262166b.2.1746630167072; Wed, 07 May 2025 08:02:47 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:14f7:eab6:23d5:4cab? ([2620:10d:c092:500::7:6396]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad1894c0346sm926483766b.96.2025.05.07.08.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 08:02:46 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 16:02:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] prctl: allow overriding system THP policy to always per process To: Andrew Morton , david@redhat.com, linux-mm@kvack.org Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, riel@surriel.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20250507141132.2773275-1-usamaarif642@gmail.com> <20250507141132.2773275-2-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250507141132.2773275-2-usamaarif642@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ig1biitgeguwzestdqibdetkbwug7tok X-Rspamd-Queue-Id: 5E6E71C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746630169-905501 X-HE-Meta: U2FsdGVkX1+DnrCEQe3r0KWr2sUBzAGHp1hRf2HWMVkjv1wP5Gt+XTmomqzl93V9DNTg+/XmiYo3cA3I8xTb7BIqXQ7Nc/juuDdQeNimc2efaJ4b1yjIZVAUux/dz0J0fuTEgnuyQC4gK/92t1BWfHqcMlsOLz26t7uYL4hKWCEEsKJtoVE1VvyTP0iYwfkWO2qvzRAMThyw7xGpDERYcqXSMqlL/fU85TD1MhEKkKf4vaOBt8nHq596ISiXCAzi5DfOblcPKfN5bN99PWZEsP4VHLkOsrUDw71IrWANRswY3E+O+mKMRrJrAZ7KuqfGt7u+k02gLVfikHgDID0dznFePp+rpoUCjT64O6oorKbBcAv6GWd8jck/QUGwl+0JrDfZF86sLmr7lmPpWknPyT+brqZftEfmggplJUoC1F8UJyLf00nn/wRs4MaoARJmABcSNDruBfxOAkA4iKxfbi3IwRv8uujmLeXTPnyvQ4JOt7749zNpCkVgPj/BVkIBkQK+gARrsenIOjSn5Q/EIwM0xWb8oxyhKxH9a6iKkP+oyf5Boe7LIMBLtdGYhgF0Nf88ASmTLNJ21fmU+sT55xmngPeOXA9kemc8WGUg4eI7MpLb/DJjYZbvMKWXeJHnB1N4wbBEfgIw664GwB0bwner4tMpFJN70MP6K7iWYZjeZVQ1+M1XSFfmnirv6zZ0tEGMv50tB3I7TBOOSoXaf7iKUhcNG1Mh/NGsJ/URqWfNdFzGcgGqQQuAApCpr9Zz7Bg56nd+eoCHECCYVJ36tZCblWMDKJp/8eUdDNfTSvrKpRvlO5PRQqFIgax9/+QLRmj+D5Hobe7Uh92NqtUQ6wR7SGU3ttztmXMZCfazCyk8WaKZPMFgF+LgZuKxz1lwVwPAJ/JqC3aLsQ9YcnVDaeOozu0/ZVU7+fPpjGMk27afKq6wP3yqTSv8Pmcw+gFQJO+u4Ye8KEIXrOexTMx vzz06AJy iDidSTZCrsQkQ34PR1Y3PA65cl/s53sPvMx4SKaS+JH7Hg6W9A6uiLmZ3PD+521Z1wxGGbaFUXnlgHPlQyD12/PQXoaVjX0ddfTnDiQZU2nLuo5eGYtzNs7LvaTysuufyAWQyCRTMNZ7zZfAqyADKR+fW5TI4qRkWs/30fl8bx9y+x6bkB7njNZkOF/3gIwrf+SkCl5hiv115F4LWxBvlN4CBGGpFSMt+96AChR5SwbnAaK7EwrgI3ONmXbz3iv79e13HgJUK4Pgr+rSfQb3l8+E44Cpq+W9oHXnjdOWbfCBfU8X0rDnV8lscHNLOF41fe8QpRSmHHpwVnV4Otb/D/t4lkjGoab3bSh6RMRSwrWxSRoqJD5gVyDG4wvBnenao0/jTVOJwsSYv4oYVJ9xy97MwDD+zXXGiMZUIj+2GpdHTKS6jCUFHqzwbdaEpaPMBNbt/Mk054Ul3ltn5aNnYb93BKTw5O3rmTcVNeh7Ofu6Z0VxUch7KFgstmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/05/2025 15:00, Usama Arif wrote: > Allowing override of global THP policy per process allows workloads > that have shown to benefit from hugepages to do so, without regressing > workloads that wouldn't benefit. This will allow such types of workloads > to be run/stacked on the same machine. > > It also helps in rolling out hugepages in hyperscaler configurations > for workloads that benefit from them, where a single THP policy is likely > to be used across the entire fleet, and prctl will help override it. > > Signed-off-by: Usama Arif > --- > include/linux/huge_mm.h | 3 ++- > include/linux/mm_types.h | 7 ++----- > include/uapi/linux/prctl.h | 3 +++ > kernel/sys.c | 16 ++++++++++++++++ > tools/include/uapi/linux/prctl.h | 3 +++ > .../perf/trace/beauty/include/uapi/linux/prctl.h | 3 +++ > 6 files changed, 29 insertions(+), 6 deletions(-) > I forgot to include the change for non-anon VMA, which Johannes pointed out (Thanks!) The patch will require the below fixlet on top of it: >From b719cd28ae78de699c0f801a4283449f6ac767ad Mon Sep 17 00:00:00 2001 From: Usama Arif Date: Wed, 7 May 2025 15:58:39 +0100 Subject: [PATCH] prctl: Allowing override of global THP policy per process This is a fixlet for doing it for non-anon VMAs as well. Signed-off-by: Usama Arif --- mm/huge_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2780a12b25f0..c4bf8eae420c 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -177,7 +177,8 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, */ if (enforce_sysfs && (!hugepage_global_enabled() || (!(vm_flags & VM_HUGEPAGE) && - !hugepage_global_always()))) + !hugepage_global_always()) || + test_bit(MMF_THP_ALWAYS, &vma->vm_mm->flags))) return 0; /* -- 2.47.1