From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C298DC433F5 for ; Thu, 24 Mar 2022 12:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 486636B0072; Thu, 24 Mar 2022 08:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 435D56B0073; Thu, 24 Mar 2022 08:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7066B0074; Thu, 24 Mar 2022 08:49:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 1EA926B0072 for ; Thu, 24 Mar 2022 08:49:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D5D08A30AE for ; Thu, 24 Mar 2022 12:49:30 +0000 (UTC) X-FDA: 79279260900.19.ABAA2DC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 13D8A20031 for ; Thu, 24 Mar 2022 12:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648126169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sezx/UQ+EqOvqVxtY+/wVmMk0cHNcnQ9Dv6I0IFtOWk=; b=bdTPGraOpTFPjL0LQY/Da8pnILe3MRyTlI+cGThK7iRFiAMWBAtuarLIuD+P49ElTr91mK zaREf36+8x6rgplxPbN+t2O94W2bpWziHnjtBHvMHE6wuwqUweZN0btoVuU+KcY5+duOrE wVUg570CzvAhAH94rzfeA5a8+BrRrlg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-UAL19e_oM0GVx7D4ec-Y2A-1; Thu, 24 Mar 2022 08:49:28 -0400 X-MC-Unique: UAL19e_oM0GVx7D4ec-Y2A-1 Received: by mail-wr1-f71.google.com with SMTP id 71-20020adf82cd000000b00203dc43d216so1650110wrc.22 for ; Thu, 24 Mar 2022 05:49:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=Sezx/UQ+EqOvqVxtY+/wVmMk0cHNcnQ9Dv6I0IFtOWk=; b=T/ecy9Vn6U+vr6y/Te8cOzvn3oLQAobETQ/bMkaa/AzIoDNfIql7hojEcJhmg2D6I+ VZEt1wuEA2vLeP99em1yoc7rStPcgoEwdI/omYMyzpvYBI8x6FyaTgm6xmQu42OKGsVJ 0xBdjvWACdU+Waw3IvPQFIrZKjyp5Y3GnKy6MRoMD7xCf9k7Si0wJpNFFotYSxsynp2J +bT2iSfGW/eTHiFDiqCmJ2Wzu4ORhc0CRE/wruyCX8uQZ+bM2Tx5dbuvYGkjTxYCA3Aw Qhb2rtTtSVCptFHeZM2csT+fW5gNFscNNJe2/9zC9pE3TCh8urnvC75eQvCsF7TG8sMo aWAg== X-Gm-Message-State: AOAM53367fnl2jul5ObK8b4pougiaXp7FVSVqvhjkmoI+gi1EWXHUqCX 2yqpVq+xr62uiRWJPlclcx04oTeAlA/JPlTb2LBWgU5eTcu7lJ7QB4plUWwPr9nMTJj2NnvW8ZS NoOg+k20GkuA= X-Received: by 2002:a5d:624c:0:b0:1f7:4b77:becb with SMTP id m12-20020a5d624c000000b001f74b77becbmr4406514wrv.594.1648126167105; Thu, 24 Mar 2022 05:49:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrmbcdS8utEDPcOUhjHZBJSzzJhICPIAie9t6e0R27aM7olxWjv+aYWwhU1fvxuOrWAlZnRg== X-Received: by 2002:a5d:624c:0:b0:1f7:4b77:becb with SMTP id m12-20020a5d624c000000b001f74b77becbmr4406499wrv.594.1648126166817; Thu, 24 Mar 2022 05:49:26 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037bb8df81a2sm7205134wmp.13.2022.03.24.05.49.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 05:49:26 -0700 (PDT) Message-ID: Date: Thu, 24 Mar 2022 13:49:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3] mm/vmstat: add events for ksm cow To: Matthew Wilcox , cgel.zte@gmail.com Cc: akpm@linux-foundation.org, yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn, yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com, minchan@kernel.org, saravanand@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xu xin References: <20220324104332.2350482-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bdTPGraO; spf=none (imf03.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 13D8A20031 X-Stat-Signature: qs9k3kj35kz36oa3ekcwo1tnrjsn38ix X-HE-Tag: 1648126169-846019 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.03.22 13:45, Matthew Wilcox wrote: > On Thu, Mar 24, 2022 at 10:43:33AM +0000, cgel.zte@gmail.com wrote: >> +++ b/include/linux/vm_event_item.h >> @@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, >> SWAP_RA_HIT, >> #ifdef CONFIG_KSM >> KSM_SWPIN_COPY, >> + COW_KSM, > > Shouldn't we call this KSM_COW? I guess I proposed COW_KSM because ideally we'll have COW_ANON, COW_ZERO, COW_OTHER, ... so it'd be under the "COW" namespace. No strong opinion, though. -- Thanks, David / dhildenb