From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C191C3ABC3 for ; Tue, 13 May 2025 12:48:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4784F6B00C2; Tue, 13 May 2025 08:48:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 428586B00C3; Tue, 13 May 2025 08:48:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27C4F6B00C4; Tue, 13 May 2025 08:48:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 077736B00C2 for ; Tue, 13 May 2025 08:48:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D36DC5C364 for ; Tue, 13 May 2025 12:48:51 +0000 (UTC) X-FDA: 83437864062.19.03DE7FC Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf27.hostedemail.com (Postfix) with ESMTP id D99EC4000D for ; Tue, 13 May 2025 12:48:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CST+LFmM; spf=pass (imf27.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747140530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a5TgOXyLSPHdmxHWX/DD9xraZLG6iwcHdcK24HBFLhk=; b=u8blT7TvNqEqIqG3IIKRF1NRk1GnS+5n4lN4aij+aY9snuSdLPR4b39QOyhoVqU028Jscu T3u85k5icyHMz05/2epiuuSPqZ9u6CHto24Hr2AqkG76bFWd9aNL1xA1ZVv3uaa+dftSg9 AkSYju1GqpW02SOtoz4sDOfY9yzpr3Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CST+LFmM; spf=pass (imf27.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747140530; a=rsa-sha256; cv=none; b=BHfWbeVfkAM2xjhnOeqkTuwKaNPE2F85KDzlvyKcRmi/wo+H2cwCl/PlspNv5TpKBN00Zc 3DhAK5AZq3X12Fm0TNSGEWeYMvisDFBk3/1DgHDKdZi0Xyd7Ryl875CYWZSyV6lnCSoDlP OBwSHQa01TJdlyvL6bb+zkut4j2FUlw= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a1d8c0966fso3568040f8f.1 for ; Tue, 13 May 2025 05:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747140528; x=1747745328; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a5TgOXyLSPHdmxHWX/DD9xraZLG6iwcHdcK24HBFLhk=; b=CST+LFmMJXh3JJIwSMFedMj6ooDpMYYRFh2yRjqSy2ABSh8c+o/euI0PTTwyigq8uM 1mpOYqrOj7au7oJprxcvLiDljd9NtlPsJ38G3rIR00Z9jzsITUzhCeF7pAPThhZ2LjDu TUbPZ6+We9PkYY/XpVLdt/GMSjIHzlwYrdnH2uGUeJcKx0LN1oxw0GWzrROg8liLi59f ZkbadxXZCC6XKl/w6Ci7Y3RsqyyrDFKT8Sb83UFBvigBVpjYLYeJqsyEVBQ06zuhOnsq tGt9WMTb7c+w/EE2a3OwQRVNLDn65mz3i1DHKOWjagLKg4+/sczYRcWlf3oxpniDlmx9 tJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747140528; x=1747745328; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a5TgOXyLSPHdmxHWX/DD9xraZLG6iwcHdcK24HBFLhk=; b=Ii5o1jvM06bcpY824jJ3AD06RulyGxk9IJRrqpvHOhDsmkP97rIHlrWHIQLft5VRHQ X5bGIbKGVyEyBNurZIWFPc+VgqFyjktp/4tjT0bzgky91H3nfRbnwcmkBCKsE1X3S8t+ NRmfPhHSc10oA6smnv995YwClutdKeflGUuPjvOy9YHom7MwuMsGlhbFlD8SZIEx77CN trrOe1KMAtS0F6y8RRmEfrty/62FY+kuNaSl96K3Ud/82A8NKj5soJWPHZ2Sl9aDKooP 83eNu9JnNmWAJRnmXpPBZneou/7OJzIDo/2oeKCqFSik+nn84WvbiDX9N2pXJVyuCHVj BUlA== X-Forwarded-Encrypted: i=1; AJvYcCXGN9zLdcO9hXqx/2zfVtEHoasnudzWYWJh+Nbj9GEtomiZH36MK5nXmqhHRM7zpcqv7SwXyF4L/A==@kvack.org X-Gm-Message-State: AOJu0Yz2TEnmyiEJNJdyfsvViqoomoS9EmgnO/Pm1g/HsTWnFRDL4qg5 ir/SQWCZ1GxC2oKD927hJ4WMhfpWBDRMOgI7dw2aU2FHEvEXKqtG X-Gm-Gg: ASbGnctzqz8l6+S8bywTTiuCuGniikHXNhuECMfqSsx1T09JprTR7mAQiTSDqkqcYul a8sQuzcOYT7ouJ9Eoe+eq9V5qNdYSUh1o1acdytjvIcfdh/D9RPg3S0So+7HPFZGpmD46xB0P94 iOoozPI/OsuH07vKkrGMlM4oWa6CRehaAcVkGwcWGtVRtuJxESufcl/y6c0YQoRuFy7BXY2nKCh HAga9jRnEjZ2MtBwzs34V16xSv7xO+YAJJaSDB+l/tHKSO4rNthhM0sYlz55eDuvQNwoKnnbKH8 RmpJZwGUgjcWEnj1myb8SAP9C6QEX8i2N3ZdnJcYHo+86E4EPwk69TWSZBWnOJesSn/QL8jZ X-Google-Smtp-Source: AGHT+IHBreVwaNTD250MP1ZhUthvVQWAn2cvlOqmyeNmqTywxz6tsH2Gn2/fdJuks7mp7pU/Wx6dDg== X-Received: by 2002:a5d:47a7:0:b0:3a0:9a02:565a with SMTP id ffacd0b85a97d-3a340d15421mr2730099f8f.3.1747140528111; Tue, 13 May 2025 05:48:48 -0700 (PDT) Received: from [192.168.8.100] ([148.252.146.237]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d6858566sm165365765e9.32.2025.05.13.05.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 May 2025 05:48:47 -0700 (PDT) Message-ID: Date: Tue, 13 May 2025 13:49:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-2-byungchul@sk.com> <20250512132939.GF45370@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250512132939.GF45370@system.software.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: ibj1tq5hzk8wamdh1f63unzmpfpnx7yt X-Rspamd-Queue-Id: D99EC4000D X-Rspam-User: X-HE-Tag: 1747140529-1239 X-HE-Meta: U2FsdGVkX1+QO+FVdqYv7oVY498pJFP5aeHG8hXemPP8S8EMll5BRrN2HgIZBOKZhS22q9mK6osWlCT3GaFYmuuXK62sIa8Uz1sxM6OPLbik/vPrua5RQmlCjz/Nob/6wzwgWDd+N1F8iSPIzQQP9gVQAfGsh9jFYmTy340hsFGFSlj8p4Bu50HkSPjVQ4WMNZgd9Q5xnUOv2urOiXX4fe9FnnJk5Ib3xuqjaZo2I7vONHpMC5jUEcoEHx/05jmwRK6OxpSCoIxeERQ6ZVWZBVPHMkKzg83ZOW9gb0cReQaOUmdMB2E6EmUPGvB2xfZubPGUFTQkMddqK1NJp+T5pdnRP9FDjS3WR/yyM8kehNPZCeXrXO7+JSgKv3mPOdvq6r7pm/VED0VbGalSuZ4XwwWyjQVDYtXygwXWlLGNfWVdO5nyXvJ2s/tmIZj7FjDlDH412A0TK5pGlvOrucwkQg1GMxrUAuhTQ+TJtVsZRkt261PS0sJwBDqwTh8cxHsucBtdhUPUGvE9nMsvcAQ7K/KmdF6iAFh7VcvjPy6pYKaeq0LyaG3fqRKamsQaGlMLFJacMSrSolZYajar2x0m+jIctsYm7UcWl6YjyqnFNBm43sS4qmuQOCWD0L+j57fLrST0nz4jXtZIYaO3q6WK60Ctvz/hW6xcBwq+Eorn4Oh4k1YQvTuGu4hFToWTxTk6FHu8KOKPol/4x2+Ed1IFrYBoL7IuBZuwOaW5KRe7d+l0ol6Xeq/95oSaowG2ThTKeYk9zlVoON1fAWyIX4REkA9/gHYx3qmLVZVARNZ3UUuWaLRDnx2eEQ9vufrvsp+0GBf+k70e2M9hfBvI2xDfqOfcIEs2nt99Mzw8E7wSGEdYJ+cRNYAnPWTS3X27fBbhvmYisovPQEYaUZL7HoWQ1JGYYWtlGtq6miKddppAbgbzMcU0a2bewwXgRwrkjBkc0ImpvlkB15b19yQ5huB u8kaBnj8 CCBOZQySNG9wY6uhXwTt3t8mvH465gbs5aMkcWsyYRHUO3okotKb6ve4QWovx0HVptWfaLwgD/fZLVc4HnEacgqXMAyDwNkWzhLnIAH/fCk8sDsYp0cMDBhwfKf5euMGTmjkdazmehXzltjjrGToJcNzkUwQ+jiqeLbc+gHD/kXkPdYzRWhZFQuNnT5iYk5ZuI+Gy1ELjQE3Xg/blYT+9MSMLdSgQdociUPcLG/r7ydV3u1S6+tX7eglp1M9pJmoqXqh4Ijys+kpjTmpAjytDAg7vBAZC0KOCel8Gfzran0fNSaPgQtOrvwSYZ5f6WpUNZxps4snP1uSZoCcAeerWg62AOsT03LFgsF6GoTtxHtDYtvbvu4t6WmrZTftdkFE8d1LULprsjfHyZ9R3rOBni0Gr9K06y92yDWGlGb6yMEzL2iBaSxwfuWdymhDSLrODxeVWeCpGu0BT4pKbYNy/O8Tswt3CI1iZighQx4GWwUIkrs5JkgNYiG+2S0BZjLc0vSjiA+CPa+d+YyGPHRsUSC7JxRT2JbFoOE2RBqM8zNPuGFOexBmL167mKLgNzE6UXLyYsEdnbOXCSM3YOoRCj3dqtZw3VXPcDFD8QWLJ/Wd7k8g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/12/25 14:29, Byungchul Park wrote: > On Mon, May 12, 2025 at 02:11:13PM +0100, Pavel Begunkov wrote: >> On 5/9/25 12:51, Byungchul Park wrote: >>> To simplify struct page, the page pool members of struct page should be >>> moved to other, allowing these members to be removed from struct page. >>> >>> Reuse struct net_iov for also system memory, that already mirrored the >>> page pool members. >>> >>> Signed-off-by: Byungchul Park >>> --- >>> include/linux/skbuff.h | 4 +-- >>> include/net/netmem.h | 20 ++++++------ >>> include/net/page_pool/memory_provider.h | 6 ++-- >>> io_uring/zcrx.c | 42 ++++++++++++------------- >> >> You're unnecessarily complicating it for yourself. It'll certainly >> conflict with changes in the io_uring tree, and hence it can't >> be taken normally through the net tree. >> >> Why are you renaming it in the first place? If there are good > > It's because the struct should be used for not only io vetor things but > also system memory. Current network code uses struct page as system Not sure what you mean by "io vector things", but it can already point to system memory, and if anything, the use conceptually more resembles struct pages rather than iovec. IOW, it's just a name, neither gives a perfect understanding until you look up details, so you could just leave it net_iov. Or follow what Mina suggested, I like that option. > memory descriptor but struct page fields for page pool will be gone. > > So I had to reuse struct net_iov and I thought renaming it made more > sense. It'd be welcome if you have better idea. -- Pavel Begunkov