From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60557C83F1B for ; Wed, 16 Jul 2025 10:19:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01AD96B0098; Wed, 16 Jul 2025 06:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F34EC6B009D; Wed, 16 Jul 2025 06:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFD9B6B00A7; Wed, 16 Jul 2025 06:19:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CCDB56B0098 for ; Wed, 16 Jul 2025 06:19:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7D208C033C for ; Wed, 16 Jul 2025 10:19:38 +0000 (UTC) X-FDA: 83669731236.21.A82C975 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 12D1F140005 for ; Wed, 16 Jul 2025 10:19:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g1RM3Um8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752661176; a=rsa-sha256; cv=none; b=iXpt8crappXYj9pHi7vT3SkUuYLFx2A8wtEUWFuFZuA25FEpzeBLyk5LHSRIDy9meOgGvJ 55s1LsowWrdhAaw5uALwF7DJ0SQlPnTbhCrLOV4TmW7vc3rDT7jg5np3/eHzuZpK+t38Va VFvnPFiQBtd5EPMvzFfeEqvCLiLR8hc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g1RM3Um8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752661176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RD+mibk5Ud3TFOH/RD4uYn7uTOHZQQh3UhohlOST2QQ=; b=1ILTRdZOaCq7Tw4wUBUODMhJE4EQfrJLfI58n1rEb+SZF5vSHmrdvSocSeSBscRwtGSC0V xwqLQ8OXfzcpRfaacqdHCMA/YWKObCtCvaDwhtJdw4zsf904TN2VSFUOOBqJNbOm4xsXcA v7PruV91RmfsW2no+iZ+WvOBwLa9iWk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752661175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RD+mibk5Ud3TFOH/RD4uYn7uTOHZQQh3UhohlOST2QQ=; b=g1RM3Um8sOGXJZ9H2Afsji+vhKwUxEa/hclHKBkqr/4RT6+l6DXPLy6SPMSN0uG9WqCZ6C NFfEm/mJnIt8v1KsOtOaarW0D5wOnWiUwEtEmWV8oyOFsTERP2dvMKJeJXHXboIoGT5Jgr BOYL6RrXb5Iv129z8fNsyhGo/diDqgg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-jxFeTz2XO3-eTyD74PecTQ-1; Wed, 16 Jul 2025 06:19:32 -0400 X-MC-Unique: jxFeTz2XO3-eTyD74PecTQ-1 X-Mimecast-MFC-AGG-ID: jxFeTz2XO3-eTyD74PecTQ_1752661171 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a5281ba3a4so2477093f8f.0 for ; Wed, 16 Jul 2025 03:19:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752661171; x=1753265971; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RD+mibk5Ud3TFOH/RD4uYn7uTOHZQQh3UhohlOST2QQ=; b=ljEd8rpL8FGJGU4WGpV7aql/msfamsfoK/4QJEmwjjUdALYmN5195/41eWVRAyW95k e2H7vgoSCn93OlEHcfmmuE5sChtm4e6y+WSaoJvVNs+e9GlLm66Fm+9T7m5Q9A9QvVK3 9G6DWNga6rEj1VnO0UC2D1BcHNJd6+GmB97TXqID3BrkZJzDyIA25gVZiPLrOoFWYH9D BkyGRJ16XytZALqFiyd4LFyWsafCSC6dXko/2luqxYibmonpWZHMzAV951I4DiGjRtyk SosmwLTBmVaqtB02vLAXIACDoNdcsZUOrfuByTC8a8XZOxV9hwwEgLB3Z0fEDzObaCSx fTvQ== X-Forwarded-Encrypted: i=1; AJvYcCVJk0bteR8qolh2SZRlu2JjAbOXmqoevywJnCh/K9z8EdTw3vVcNkg1UdSM0lnIK6QTpYmwv/IIgg==@kvack.org X-Gm-Message-State: AOJu0YyDZgfSwqJK4werb2OPo2jeMG4flvhMRkEixr/aEugJH/vNdDyR PWjehex57CTAx8bAYM6vX0a53fdL81UMvcEagTcHRfykEM3n/xwxonL8O5AdxwxrtDaORJL/z0k kbrtiN7j/+4EfHEAFcCDWywqRCtImlPvUymHtHlWvZwtYmR8mnOv7 X-Gm-Gg: ASbGncvFIKHaSiICcrO46iA/VVXP0ryzMKmMMUFkFISbifhNrV3+KIVInXWFgOPHGFc lzXWDXSrGYw2PAXuhj0XANdZGJ40U7JCf/K19G2VIKpokpi4fTjtyzLLylsLjYkndBrcjLJdCYx ZFqGKWzrRrXeUYc4EWQ/N6R9VfkrO17aOZemj/J1JCXBvq2QFmw2/hPENlrbUVTtfVH8Nw3Ufn/ V84GvOoAIo65FeTrd3IWK/RnwhZhjCCmKUR/KxKikyBAbdnuHVoDsfEd/fI7NnjN/ItSjr6t0w4 KLpOVU6DCvAq49yQTswgqjjyn/QUenBtmS/paijzxtU6Fj046KUTDuLadDVSC7GNl+THvro3pJb DNFXNkbZMnhDTxQKNjZrUJvx7ajQj/mDeUAgTgkeY/bFNL1iCodhnI1hXYB0HKYY1tjU= X-Received: by 2002:a05:6000:2489:b0:3b6:c88:7b74 with SMTP id ffacd0b85a97d-3b60dd918b1mr2056086f8f.59.1752661170820; Wed, 16 Jul 2025 03:19:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOdP5/JIvUYKpIbxJNQWhLOoknuYzXxGRBz627SKnreGxi2a7RCGFHQrxfPOEEndJscLarPw== X-Received: by 2002:a05:6000:2489:b0:3b6:c88:7b74 with SMTP id ffacd0b85a97d-3b60dd918b1mr2056062f8f.59.1752661170412; Wed, 16 Jul 2025 03:19:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5f32ed100sm14506640f8f.0.2025.07.16.03.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 03:19:29 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 12:19:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] fs: stable_page_flags(): use snapshot_page() To: Luiz Capitulino , willy@infradead.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, shivankg@amd.com, sj@kernel.org, harry.yoo@oracle.com References: <52c16c0f00995a812a55980c2f26848a999a34ab.1752499009.git.luizcap@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <52c16c0f00995a812a55980c2f26848a999a34ab.1752499009.git.luizcap@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8pVRb1vM7tOffRcKYoufxkI5qMYXAZ2PmzVMYClTY8w_1752661171 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: wnk6yqegnncpqrhbjuwrnwdest7uyk13 X-Rspam-User: X-Rspamd-Queue-Id: 12D1F140005 X-Rspamd-Server: rspam02 X-HE-Tag: 1752661175-409654 X-HE-Meta: U2FsdGVkX187/yrTWY7IMow3ioq+uZaftduqaSVSYc3VGlO3w77oBIN/df1K82seElieOvRS0JsPy62uq31UPB/XwWpelJx+2XcKG/9x5VixZHQKmJoaso922w4Kfcegv4bbDAucjHPL5PBBkKmEG6fdElBXhIzAH618WrQP5KFLMc9AXEwSoRFlLPITYfHra8ASKhl2nb7RkM/r2updZoUIYhR1QCOMlY0Yj6U5Ni+AGviUGt6kw1deGmy3fSLQUSvl7fjTvXrl6PlOhOQT5k+BeQKH16Q5HyTZYJfZ0JoxhUGKb8GP5979lIHAoOFj1BZ9nBWiSphx94xaOBkbDCITur4z9i5lbdKfOyKiL3dzf6rT4yAsEsvHQ8Anc8s7qHgYSAxLbXvwxwSNnkSS2lUoZZRRhKjtG8gKMRFMJDbM3KgHvz2DzPtQBEZZNEuCXytYlgIf7AToWJRKq0RA4b2zObXAPiJQenawmxBWOQEwbSERngV1fDzELGYG1OW2uO9lMDNnR+D3jjXlrFzU/2vpHog3V3PQqqoavkIU7P/94F/1Oe3mBTnUyzO/ZsB10xUWKCoC8I2uBd0p4i0QTlkFn3ZGWN0FH7hKC12PWxEKtiJI757SfnSpiOIUB9L3QP37+YBX8d4ltxiJ+DP/q+994Og+3BHQ9+o1iOHxpQh9UUPqFYbDXC3W/LbI5FFxMmzhF4UgmSv2VSF7GA2FddgX/A/AejSOXGlVI2d4DiE0VTlRCW6bdcqKtyvHPXGCpufFZ6NS79vXtLZKSCrZHF+Xw7zqj/mSqgy+VpciCruI48wZUQOICx8uR6IT/4ybT0PbCtybYMolF/fWssKOS0E9n3fdljMmIPruOuCobblbO4dQUesDNIgX0pMImIsTqkQpu8OJq0JNqIlxULIemymvdwXuFttzu00WbMHr9+KlMivZJ9xOmCVhWvHZjUc/VfLT9+ZRw5oj+ZKhiFk 03gaKwMF 39NwebdX7W4+bA23lHyXlVIeb6XhLrhAZ6cQVgKhXo0zZd/TIlXXVHyCmNOt2PMBtQTl2FZyDZK631CJ8FdMOXu1YiStkczufUZ4RfoAsluNfBSJLagJfG4Y7+LdqFfWdFnbnIRl6H8+bKnNCQsQWpYqNemnWS4n4Kh2Z4EOgNUB92A4WLEabOM77792N+JuWWgLuNzkZNzdqFL6mAKuE0WBb/IOxSCbT+y3v2+HlzcVHHzhg9J+89mCSkNCzKPucjEkt3C+e5OqaTEpBFZariiTuSOGJCx7+1DwWUvDonjwqev6rpjnSdg0ESlieUZTe9F5NelSmB7bLBzisYjsZBxqZlhOOG3N80sUR0BdlErE7wfik0ypBWMgnznW8N5iDvQn9YsmJ5skDx+kMsonsM3LwVV8keuSl6Rmgl+EcsKhh/skB4Q8DXh3espPIe7Y4IqgoQZBJdZCoPwjfoMQSOVdSGpOx8NA2AQ96DVui/W2DTJ/aygZXJHiS3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 15:16, Luiz Capitulino wrote: > A race condition is possible in stable_page_flags() where user-space is > reading /proc/kpageflags concurrently to a folio split. This may lead to > oopses or BUG_ON()s being triggered. > > To fix this, this commit uses snapshot_page() in stable_page_flags() so > that stable_page_flags() works with a stable page and folio snapshots > instead. > > Note that stable_page_flags() makes use of some functions that require > the original page or folio pointer to work properly (eg. > is_free_budy_page() and folio_test_idle()). Since those functions can't > be used on the page snapshot, we replace their usage with flags that > were set by snapshot_page() for this purpose. > > Signed-off-by: Luiz Capitulino > --- > fs/proc/page.c | 29 +++++++++++++---------------- > 1 file changed, 13 insertions(+), 16 deletions(-) > > diff --git a/fs/proc/page.c b/fs/proc/page.c > index 936f8bbe5a6f..52e4f49c0638 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -147,6 +147,7 @@ static inline u64 kpf_copy_bit(u64 kflags, int ubit, int kbit) > u64 stable_page_flags(const struct page *page) > { > const struct folio *folio; > + struct page_snapshot ps; > unsigned long k; > unsigned long mapping; > bool is_anon; > @@ -158,7 +159,9 @@ u64 stable_page_flags(const struct page *page) > */ > if (!page) > return 1 << KPF_NOPAGE; > - folio = page_folio(page); > + > + snapshot_page(&ps, page); > + folio = &ps.folio_snapshot; Not sure what to do here if the snapshot is not faithful. Fortunately, it shouldn't happen often :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb