From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE33C5AD49 for ; Thu, 29 May 2025 20:48:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 865D46B0085; Thu, 29 May 2025 16:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D6E6B0088; Thu, 29 May 2025 16:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 753276B0089; Thu, 29 May 2025 16:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5C8256B0085 for ; Thu, 29 May 2025 16:48:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F35C2BEE2E for ; Thu, 29 May 2025 20:48:45 +0000 (UTC) X-FDA: 83497134210.08.E55EF2A Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf25.hostedemail.com (Postfix) with ESMTP id 048CAA000B for ; Thu, 29 May 2025 20:48:43 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bmmwpLdt; spf=pass (imf25.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748551724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2qIpcYfA1//GAtmsBWG/5uUEcJigGm+o9jyY6nduW1k=; b=wKbAlyuT3KVr+2VtWjjfSThqLsjSGFSDusYkB8X9TC/ohOtp8LNpy6U8g5FK4Af894i2Ja p+xblif3Jg4DGJSly4IYfiFZinxhxx3jv7+S0D0VNABQZtyfIODiChCoV3bTJDdwWP2lGz OYbxo+jvW8WkmxOnmxmD19NmX2ZFyaY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bmmwpLdt; spf=pass (imf25.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748551724; a=rsa-sha256; cv=none; b=hC7wOIQqerHPcpz4YeAlrgAY9GxbhtTiOPaKvxtbXmq1ydvPyjBM43dwH5MJfjwxYpK0D6 HGa3kPZIPS3fL7Y6WNcXsjncMg7Y0+3JzjoTvkXVQb/Jef2K39RdVFGJSDYXJJeM+If28P luJ2XzblIsJ77qTVDOTibEtjokSZFiY= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a36efcadb8so1170104f8f.0 for ; Thu, 29 May 2025 13:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748551722; x=1749156522; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2qIpcYfA1//GAtmsBWG/5uUEcJigGm+o9jyY6nduW1k=; b=bmmwpLdtLbyZJ+6UpwvaV3Ilm30pKvXjYFp0Nx5JAnjVAN1IITlNSO+HcGFpVunB4h +RVLlT1jsx+vG2YDioCcrT1OKK6p/+BvX2J76f5wr80S7VyDh8j/rcBK6CQkVeVs914c wp9pe8tjVw6o8zJA+252tYwu/sQ6t251I1kqY3Gy5t6UCiatJQ2tZJ/CuKHiiOoB5bFv bEX5bFO2LgU1VjwFPeHgwYDWtyyRSCJMeYm+/qWlZDl0Mg9fOd9zk9L/CilL0PJKHob9 dXonrUKQ/WAqGOwAztQgiyQjdcD8LM/5d8OJDV1aVruwiUgGMLRnjwXUSLLKdHu5rXNG +8og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748551722; x=1749156522; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2qIpcYfA1//GAtmsBWG/5uUEcJigGm+o9jyY6nduW1k=; b=IUgIDlrhjRDWll5A7umIZKwFtU6I6dgj984Z5RdgkDmdJkuutlKZ8LZwVKKC6lbWUS yn9HAr2kcgZ5wyGhmu6z9jXqrj2byQBT4XXiuzRPTDmEh/hSA4w3VTFZqbnaUvrTGI8m FsmDds03GVDmDjq7G2KPwE1THdErnvPjOk8nOtt7fLY8IvzpeNRCIoJdAHu2uB6r28SK BUVOTlSl0Js5AiUiXJB51VdXHXG6tYBjaZUhIhPfKoNi+Dnr9RLGSJYIRD/tWW/wewGo jVPzgg83SdGZenc16FXD4ckjXHiVEKJgke0Zv3uZobtUR6TRQEAr8FLwo+whmHsRmcr7 yDPw== X-Forwarded-Encrypted: i=1; AJvYcCXUrLbKX9epCqXcNogk+SNyrAUlaa/O5Q3N4P9H1j98S4kMoGlHMN9JTo4SBpfNeLv7dsKeJRqGNw==@kvack.org X-Gm-Message-State: AOJu0YzUeGh3szAeRsEa5GaGyPYB7p0F5tSZZmMGyBc/2P51fpltu0As 4tpPPaH5ILn7zQOe9FOk/v+N9FQixMHxgrxfMwackRabScI/5Bbsdn6S X-Gm-Gg: ASbGnctLE8h7csbXsrUJUtnkZxaGlFPCrzf6V6adPbbQYyEX2dADMEAm6GN1YJaMXnZ rJTg3lUSLaq0nRMt55pqHE1tZ7KG0oashum0/eqBWL13Zvn1TE1WjinQVBtv86E4JNpK3DYcs4H qNENwTiLZHXSkcEvLhR6wDYbEs2A9k2aGWsnuIEJ0W/D+YJ5tkwmXRJmzXDGFWDqK1DEbZi9v40 KKAfILz3KOq5GDYpTTRUxIKBJ29FHhDjLzfbQE8EFRYPb7aeJ/sp5m4z/PCNwc+ZrPt2YH0VPh1 1oYtLAelWjKl94FL/bVcahmn5SihWXrZe5+Z+2gRP/57UWs/fdDiFti2PyBD4A== X-Google-Smtp-Source: AGHT+IEn+9dMRrH8DN/e6Mt7FBhNbDQtsoQnNYsnfAv7aLn6S8/nHJo/gZniov+3n78HoXJEC+GV4g== X-Received: by 2002:a5d:5f84:0:b0:3a4:f430:2547 with SMTP id ffacd0b85a97d-3a4f7a3e50dmr580875f8f.6.1748551722255; Thu, 29 May 2025 13:48:42 -0700 (PDT) Received: from [192.168.8.100] ([148.252.146.217]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450cfbf40casm29286315e9.4.2025.05.29.13.48.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 May 2025 13:48:41 -0700 (PDT) Message-ID: Date: Thu, 29 May 2025 21:49:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v3 18/18] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() To: Mina Almasry , Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250529031047.7587-1-byungchul@sk.com> <20250529031047.7587-19-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 048CAA000B X-Stat-Signature: 6xweqt7d3zcpouhiun9iamm1pjbe4p63 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748551723-242921 X-HE-Meta: U2FsdGVkX19hnx12QrrY0grmaoH6Jvxx4W0f48ZrnLvHmVwg49gRfN9U2MaSbLSfH2mZYOoq6FJLd4PHR5o1wCZcdXZOy5AIWrU8yVCQWb958vz00SINv+DZcv9qBQ8FbwaCimeuLctD+0zQOqqIXoUsqN3yG+BjeGUu4cCmbOTyH7lgbV211YzQPKnAlIVhoyboXWh5DSl7+Itaf9c/PZTcE1dgLqkkDKvfm9IHaplcaz1sNGDn1X3qCyiztYYIsFb6kPP2trw53Cs402xgNDOCW8uYyP03UMPQjQQeKO/HdsP+ZzDyOmh5qsAC16Wkqj1vALpOS1n6G3JcbeYjH6jxySqG9uUlT7S7P5e6Eo6qwGVIjG4QdtFsr9pXJQUrguZnDxjnEvokj5KD2klSeg77KCQW6RoB8zyhvys+YP0l5pGoSIO3zx5hmumpH3Az/pD/FsTLMvEjqMAtElvN6y/K/Y2S72JYZsdYZRoB9dljUGa/bdBw3Ln4z1abGl/8ZEYSBVrWxWNJ7sJZD7keb2ChBj6DdjmElXNWkrx5liDBQvOxnElN6RJXpwN3wqs92Vap3EOhmS2PXj7G3ApvjYAUkGGq14oAmDUSey/2vCuSlTWuCHI+TkzjMt3SiDUnDxp5vExmnSAsciQJoJdfml5fEoIIJVbwN/Z/7Xj2y+mW3dHdzXVdTBv8r2F6Yln/CWDvld7dfUv4HBeEX+NqpUviUzX/oWEstfKVAGCejwEaygG9qWfKqWx/XIp3mKB4f+t3ap/ctVsdJXAybhExXyFkDiL8T91aYPiock0F688qQehxxbzckrIjqEgU2aEWs1D4kNXJ0zJ+N199dueUzCs41Rqk+dIb3rsf8LLoqIdmzh1kGUM1STrtsfTWsOChIWaPP+ZVSEscBwisNrkxrYTJW3kN6axgfQ5SMVodDjmLDE5WWi0kjlXL+0EeNMceT62gYwr37qijzOYPI+d Xgy0It54 vs/GOz+KDHPWiIgQiPkVg3AIBMJSbdwYqqKnv/Nr6iuKBOlrPdxYHZ5CtslHnrQG97dJDqa7JPsGSYkSpzPgUIzGK5DcmxrRKlUKg7eysXmArFm1CeK+KgSOvAHKhqPBdmH8Qd9TM3Pq1eqRxrL3VqM6bNxUdZzT6DIIGMxLu1XPYA5vbQa9BC2CXZ7BjPAz7C/xCVmDVj61d0H6igH+DsrLEVthJvV1Kk3BJf/QNM2MDxcztatoz58HUXYhXl6RYsBZ+eCgxYDjko9YdGiTtg36+8Yhbrk8hRQ0NfsfE9gMP3XDLaBfWyXHV9BZhlJ4bhgjtKtvM25FNCALTCiavJhrrI/PjpO98H4dZAzQld+gKJWWDnoQooBwiuuj7MST8vHOjbltUPIrOQCq12jlmAz5ISVmQN/E0y+2Hd9I5+OiF9PEW+SoXo4SwPhaD5U2zINjGF/tX4WFnhQFZgQ6XPSAbhLOslzBm3wv7WyPbf2RYaCOiT8Nt0lpchPNLc5o60br7Piy5MX/1WMOri+DIiFebKoelkCKQy7mdyCDW+YVI1s3lqc8g015QWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/29/25 20:54, Mina Almasry wrote: ...>> #endif /* _LINUX_MM_H */ >> diff --git a/include/net/netmem.h b/include/net/netmem.h >> index f05a8b008d00..9e4ed3530788 100644 >> --- a/include/net/netmem.h >> +++ b/include/net/netmem.h >> @@ -53,6 +53,20 @@ NETMEM_DESC_ASSERT_OFFSET(pp_ref_count, pp_ref_count); >> */ >> static_assert(sizeof(struct netmem_desc) <= offsetof(struct page, _refcount)); >> >> +#ifdef CONFIG_PAGE_POOL >> +static inline bool page_pool_page_is_pp(struct page *page) >> +{ >> + struct netmem_desc *desc = (__force struct netmem_desc *)page; >> + > > Is it expected that page can be cast to netmem_desc freely? I know it > works now since netmem_desc and page have the same layout, but how is > it going to continue to work when page is shrunk and no longer has > 'pp_magic' inside of it? Is that series going to fixup all the places > where casts are done? It's expected the struct page will have a type field once it's shrunk. > Is it also allowed that we can static cast netmem_desc to page? > > Consider creating netmem_desc_page helper like ptdesc_page. > > I'm not sure the __force is needed too. > -- Pavel Begunkov