From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95432C3ABD8 for ; Fri, 16 May 2025 18:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7761C6B00C2; Fri, 16 May 2025 14:56:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 725646B00C4; Fri, 16 May 2025 14:56:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C60D6B00C5; Fri, 16 May 2025 14:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 37E0F6B00C2 for ; Fri, 16 May 2025 14:56:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5FBF85ED58 for ; Fri, 16 May 2025 18:56:38 +0000 (UTC) X-FDA: 83449677276.28.B81C16C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id B70BBC000F for ; Fri, 16 May 2025 18:56:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TYvSR2H0; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747421796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ifcGTgJelxajCiU2FWoz2x8XggC8WSn+rbLJz+ygqMw=; b=myPrJetiPek+r0OIDmHN33v8kARTE08UZdXjonZ0DD52efZ3sAtprfXbV/hVQ0ueoQhjb2 ieT7gl5DqTmYjIkE44+lxVTXb0MHMRYcXEgrNhgi+x0+EokH9zKhpNrrZLBOuzoP0MptP/ 79r4fGKANzd1beq4CLYomBcnhAlRfiQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TYvSR2H0; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747421796; a=rsa-sha256; cv=none; b=RyaXTlW0ae6pJnWUYB0xnYBiOrVfoZ/DxOUrU2gM4Po9FnAM+rk/1a7Zpi61tDNmV4LlVf lcIz16vlfKtO7U/RwpkinfhatMWJisBs7Yx6GCRTQ/F11OPBYi1F3GQzbNwzASWowQ80UP cK84b8/+AntjrElShGvxRO4yr69EWO4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747421795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ifcGTgJelxajCiU2FWoz2x8XggC8WSn+rbLJz+ygqMw=; b=TYvSR2H0SUWnrHZicXV7JJxUzFSFd0mM/APwaxz5IUaBMurnExS1sNjclltk6L8rHNyPs+ KAGD/2aHzWWQHQB4Kmq3JXTD+SnAboiExM5c0RM4vlL5oWoaXWOBXE918/x8ll14LiRTlB lLb0lkztlcvScWQqNI7O1uUOHqW3O1o= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-jKXMXCKbMtCzfbqrQpZhyA-1; Fri, 16 May 2025 14:56:33 -0400 X-MC-Unique: jKXMXCKbMtCzfbqrQpZhyA-1 X-Mimecast-MFC-AGG-ID: jKXMXCKbMtCzfbqrQpZhyA_1747421792 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-44059976a1fso10896515e9.1 for ; Fri, 16 May 2025 11:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747421792; x=1748026592; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ifcGTgJelxajCiU2FWoz2x8XggC8WSn+rbLJz+ygqMw=; b=vavhIMz+uPVQX88nrtHb4tX6WVgKN1g/hOf95zhf7OiuTH+P2WpZ4ICsTEi4TCSp9B CNtfJggxf6Wp4XME6YTUoKuLgGMMzQTeZlnOwVORwAcWn71odIo+GkqxwJh+ymNiHupL /8Y+w9z6SBVaIEap8W7mUDwAHvgOFp3IBZldZeFrPP8JCEs3GDgp8Wbb/+sxUenFXSV3 P6ad0ZIbfvWKqUrHIalnZbpdHyEG4zKHWUL/w222XX4ZA0g738sAVOk/mkmQvKsAiQ57 ye1E8uPJF61bR57881xOIH/rU5t8BJWqlIvihLzvxuZJ/mfHRedLenrX8QWiRJRphubz J5wA== X-Forwarded-Encrypted: i=1; AJvYcCUs3CDtGcpSkJON0kksxItHsX9CWKeIK5q+Gsm25DxnZwuinx4o8dggkh/A4mcNalJkj2jUSnkbUg==@kvack.org X-Gm-Message-State: AOJu0YzY4keF5fpkuSsped/hgnsi9/yne131aTx0dSW6iKU94Vd/m+Nj QgTaSqoKYwIe0WC8bdRfcQ+gDUOcWr+/J5tXuMyGRmtGK3R6Hl68WzSYTnTQ/gj1xvIEsNlan0r snhZKd7TThcXS56REWA/tAnsTRD3Vz1XS7NttIHzzCt7vujYNGA3r X-Gm-Gg: ASbGncu9GLWiXd2KuRTIC/NWEQ1zo5M1+S5sgpmPborctVW0F4Xgyng2NdZTIMQfMSz 15iT3iR9E0ll1b5zXgNteK+dxUwHR8OidWxcIcV4Zlr87MOV40KsLR33ZG7DxZL4mf80Lf+EFwj kLYTMc+eqZFZGcGAqP2ch2Mgc+5qNeAKeCGemwHqCcwX5E0EMEG9siXsKGD6cXRFPqQw15dCeKk 56ur1bhHFCSnHRxV4s/Do+YwkJvayzi3IVOQ1CK1kLVopOHwb92eOi/w1faoosWt2Xn4LeTxfbJ +nwcoVsR1/ufdbz7qa0OxOPw/tVMj362n+CEcH2g1g== X-Received: by 2002:a05:6000:2dc2:b0:3a0:b65b:78ef with SMTP id ffacd0b85a97d-3a35c845c04mr4820392f8f.52.1747421792492; Fri, 16 May 2025 11:56:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkqi1Ur9MV4UU247rCekfZQh5zJYD0LlUxflLVxHjPBhdhdSsqXUpzAVzfUm2pO8VCCsxcJA== X-Received: by 2002:a05:6000:2dc2:b0:3a0:b65b:78ef with SMTP id ffacd0b85a97d-3a35c845c04mr4820376f8f.52.1747421792158; Fri, 16 May 2025 11:56:32 -0700 (PDT) Received: from [192.168.3.141] (p57a1ac29.dip0.t-ipconnect.de. [87.161.172.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d230sm3656530f8f.4.2025.05.16.11.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 11:56:31 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 20:56:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/3] s390/uv: handle folios that cannot be split while dirty To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Matthew Wilcox , Zi Yan , Sebastian Mitterle References: <20250516123946.1648026-1-david@redhat.com> <20250516191748.3bd0861c@p-imbrenda> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250516191748.3bd0861c@p-imbrenda> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: N-mMAOVDVRAipsUeOTwE8GgZ6P3vTsbSIqfTjD1vtOY_1747421792 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B70BBC000F X-Rspamd-Server: rspam09 X-Stat-Signature: x1qcnyj45rykmm7razo7688nnoc7thmf X-HE-Tag: 1747421795-108845 X-HE-Meta: U2FsdGVkX1/FNN8L/i+qnhog5HFPedCK/KPWpwMavD9cGtVnsecJ0hwYIMaLNms0/S5Zerdt2+O8QKJ1GY7g5NQQgNHFIo/vlfRIsk5cJ/bRcVqhrXCzTBTYZVtPKdP35hagMF/bA4BkuYNn+gUr+0ypxzD51YO/4yr+cqqbzWbRGeMx/i8q6ykzlXNuHHVDaj3Zjl063umJo30xdTiy/im+cAvXaFFuyBYX0ywjDFa0HLkGmjygMQtDDo1P0XGVgw/rsHHdXmn/VIcKEy4+ZZf5MFFwZ/W14XqgKuWZEwEwspIMvysRhV8lQskPJ/o9/MAF629REkXHTsDrjLqeZUTGquQpM47WXBg1sSth3WSrJeTSoOoaUXXP/N/+bryhkX70ZgD/U9gGMkebbroZ7++9n+A53BV5hOe4pOxBVvEc1LCZpwYQD1I5ZE5iCv1nvzgzwfYf/1YMjuNKVJ4SfwfCWd18csoR+6JBSt30YWSL2kjA3SAvtQsC2AWvLmNKba8IcerZCiHH/9RiaMZuI/J3MiA+q62iSKG8JYSktFfnggUJ9z5o7GFKI1rTxxFQkfPXObXw7CN03ZVHvHJIieEM7ifF67n+nNgaMkK4cPmjvji/8dmM+jKoP+hWgBav9AaSzIEBdeo17UpHvMhrRx093zjWLkesJk7PBfmHOcfUDJVqBiZZiJov/maO5vYTiXWG9+ScX+TqX9ywzpkk313mUiyS73sHSaWPdLctyj2cwhbRKpPyx3U1PQNwHhkA2pJvEO1PYqyRUYv+MdpPg1EmrqxAA9IfnqAXULNfSj9fhkR8ypePOEOEGP3rmqo27JJG4ebv4ApBfMnWpqoCy9tF9BHE1WFWrevCKkUsZ/n6Zqje+5LXgQiT1aBF5+WGjHicyamDbCQs8Hrvw7NWeP/pNZP3+mm6Y1mbT5LqOYYJWLrTglKGR19ajs8i6a9OIR/CdhWUAHnE8YLwbUY KfAF70vn K8hpvzHYxtSej2X8LQopROXzy0+41QYXIJ44Dlg1RXTCSFnDxEiM3qqeiLjTnyF5SnwUu+kJH4TOatadOj5dvq0NurIYQ40UViwW+3htEJGNGqGE0nsGqTgAKsudeEdmW1FrobW+VYbsvuz7qnwcPlSsa+k0pzDxahlmras9OP/BvhNIcIWZUAo0c++2ZAv+EAi2eYFrd9Rqh3qU0PvrsoxxUwJR4VT8+zPvB2KNgCkU/SzT8r5EwftqGqbCHthTsnn37QgR2rqMrwR7CX5SC/CjMDZIiRNyaOC3IJVe2/bjh0SkFGqBriFXnZGs1pNvTvlk7JOpIiCOhrZhm2nQd1tyzAkh1OnfEgt+v74rXvS9Kqwvr/D2ySBrtoeMuCCbba+HUgLV9HKrFDaYDWlO3yzk5OO3qaS+836QoSPRI6zFBZXAij0y+vfndyDC80ZFYwCWC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 19:17, Claudio Imbrenda wrote: > On Fri, 16 May 2025 14:39:43 +0200 > David Hildenbrand wrote: > >> From patch #3: >> >> " >> Currently, starting a PV VM on an iomap-based filesystem with large >> folio support, such as XFS, will not work. We'll be stuck in >> unpack_one()->gmap_make_secure(), because we can't seem to make progress >> splitting the large folio. >> >> The problem is that we require a writable PTE but a writable PTE under such >> filesystems will imply a dirty folio. >> >> So whenever we have a writable PTE, we'll have a dirty folio, and dirty >> iomap folios cannot currently get split, because >> split_folio()->split_huge_page_to_list_to_order()->filemap_release_folio() >> will fail in iomap_release_folio(). >> >> So we will not make any progress splitting such large folios. >> " >> >> Let's fix one related problem during unpack first, to then handle such >> folios by triggering writeback before immediately trying to split them >> again. >> >> This makes it work on XFS with large folios again. >> >> Long-term, we should cleanly supporting splitting such folios even >> without writeback, but that's a bit harder to implement and not a quick >> fix. > > picked for 6.16, I think it will survive the CI without issues, since > I assume you tested this thoroughly I did test what was known to be broken, but our QE did not run a bigger test on it. So giving it some soaking time + waiting for a bit for more review might be a good idea! -- Cheers, David / dhildenb