From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D344D1813D for ; Mon, 14 Oct 2024 19:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B6216B0085; Mon, 14 Oct 2024 15:16:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 066896B0088; Mon, 14 Oct 2024 15:16:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21EE6B0089; Mon, 14 Oct 2024 15:16:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C24E56B0085 for ; Mon, 14 Oct 2024 15:16:53 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 93E06811E5 for ; Mon, 14 Oct 2024 19:16:46 +0000 (UTC) X-FDA: 82673164938.22.A30D0B7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 09C3714000A for ; Mon, 14 Oct 2024 19:16:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=atCsLEbG; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728933364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sQIx8Zvd1bi6csR0yDCe7VkAynOD+MUuQmAi1iHX0fA=; b=Sinr5taGdfbUwocfGn3CM1CcyUlft5FojTF0TLs/EKQJDWQ0XWItL6PUtry9R1aAplAEqx R4LsifuP5Eq0vKUq4qgaj0uADAj9Vf0N8BfgjD6j19bxHvXCYsvZzkVeKOBPSbqObmzWuj aajhIvBpkvFx0iKJsYRkkSJeztLNv7M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=atCsLEbG; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728933364; a=rsa-sha256; cv=none; b=FqUd0irNv0MtWJ7qi/2j9ANfUVqbSjy/f0CtbltBx9X/aMakllb+bcRXfGU7OYbws1vzs6 Ssal3uwNjM3BVxremsdJEtNygQ0oSftToQYY35jQ/6OwuZbYeo7xuBMoy0W8iVHLG9pYD9 4N05CYBNVSJuAsMScyOCSm2opayTuco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728933410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sQIx8Zvd1bi6csR0yDCe7VkAynOD+MUuQmAi1iHX0fA=; b=atCsLEbG5K0KPyrsuMhHD0kB5z9oDNmvIxp+L4SrCKlYFQ8/NCviR0nWcU7lIsSt4PHCDV G7Gz71QXNNs0vh7SvemvFFDpTte+CCd+Q6MLLOAI8TbyyRVCeE1QF/fbVETC8S7l/bhi7F /QW8ErMxO0eYiqNoCvghlFtBAss/PmA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-rVq9M9OaM7WpvoHKpHcNeQ-1; Mon, 14 Oct 2024 15:16:49 -0400 X-MC-Unique: rVq9M9OaM7WpvoHKpHcNeQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43056c979c9so28126845e9.1 for ; Mon, 14 Oct 2024 12:16:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728933408; x=1729538208; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sQIx8Zvd1bi6csR0yDCe7VkAynOD+MUuQmAi1iHX0fA=; b=jpUNMJP3pA0jG670Sm98UhlRe7GITvdD8WyAqxtZpNKjNu8ftkPaaOKFYOnWV5B5TT GJVCgBciYLDLCmxPTXbWtl+PXg2w6HJeDenTN7OPw5r8haHgr2Rjns71jmdjFFeVqgY7 U1R5qKOwJDuBy1K8rzH3TX+ghJy0ODX5VcMwdKb7KDShclUiVbRKKGbA5Gv17LfDZR7f qbqfpgmV7rXkKL1aseNyx/ZH5bVe9tXxs7wnkoBQXshCG9l6KtrVwFpyqplv5ezvP8lz tBSIWoRs+m/rqxT2DkYSP8RyXYT7Mvm4mQz6/Gy2FtRLR+tib5efp8C9vNGXd8vHJgd3 KctQ== X-Forwarded-Encrypted: i=1; AJvYcCVrgJKXKjVzEgV2KpBRneDq2aNY3E6sc8z/6xsxLIvXUM7sgTwCCVPklq9kacmIR/mkunvDH20m+A==@kvack.org X-Gm-Message-State: AOJu0Yws+8cgECjcjsm3zPGvibo+Yygr4CnjRpqbpCMqz8LsVP0adGev 6VQRqcYxsLSObnPPFZ/K37NYTeUEYqI5n1ZsuNWI308V2Iv+io6uK09VC18TPwbNUBOUPRDWqzG iT3TmpyG8TLMA61ZxsRFtsXnEfrDIFBBfXJP3D0Z0hvLOewzj X-Received: by 2002:a5d:4348:0:b0:371:8319:4dbd with SMTP id ffacd0b85a97d-37d551e3d0cmr8006248f8f.17.1728933408029; Mon, 14 Oct 2024 12:16:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6sBThr6RdJ9UzUqBJZ/Z2oXOcyxnQX4PJcKNdIkMaURe8S9HvwixtiT1L8Zrvsmei+/RVow== X-Received: by 2002:a5d:4348:0:b0:371:8319:4dbd with SMTP id ffacd0b85a97d-37d551e3d0cmr8006241f8f.17.1728933407562; Mon, 14 Oct 2024 12:16:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c71e:600:9fbb:f0bf:d958:5c70? (p200300cbc71e06009fbbf0bfd9585c70.dip0.t-ipconnect.de. [2003:cb:c71e:600:9fbb:f0bf:d958:5c70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6cffa5sm12197664f8f.53.2024.10.14.12.16.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 12:16:47 -0700 (PDT) Message-ID: Date: Mon, 14 Oct 2024 21:16:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] virtio-mem: s390 support To: Heiko Carstens Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-6-david@redhat.com> <20241014184824.10447-F-hca@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241014184824.10447-F-hca@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 5eds9ktsfja9wqmoksj7b3qw98naygj1 X-Rspamd-Queue-Id: 09C3714000A X-Rspamd-Server: rspam11 X-HE-Tag: 1728933406-932119 X-HE-Meta: U2FsdGVkX19ey1UHim1zMbyiiShkghdJD6UhFfg8RRZiqzoPuyXqpKSSsC2i9ZkhoL18j2Er9P71DIpuealubU1cazpNT0CIffXMZJ9/k2rTYMAaiTh9672Ry6NjDfGyrKbMGOplwZCZ8FSqDFDVvO2aASl/IglzI8ez0uxWHxoY8ZFojyynPniwH+NBCA98d+OaitphPP8E1MvCNppxrpu3Of0gCShFRLtn6gptqcERUSlGzHtc3BzWr3U2PVKYhXiAb2n4eRUNgMIF4/adAiYzN1Z0ZX75ogyuzP5yEpePbYD2J3ScsdCLqGBYpydKJnCei95Wv1N1o/M5T1xMJ6ELWxhCtevfqwfN+QHV9MvN/tdU6CJPRCNKh2dMwFtgb1nOElUfSipsarXsCm7/VN0HHWx+L/QZUDuf1p3RngwOZTKz96iSAJr4Mli6DlwX35tnZ5XcgeSQdvj4Bfp2Sp/LnWOTgLTCc3e0Ga2iTGyt+6aautnT0nBXtWGh7j6GqJaQVBLQACDaqMgicAfTnnIi+2IxEmWJ/bYBTFPdtN0UIJx4RH/xTTDp+5DBdCRJwS7sz92yRH+y28aE9uQaCWV+xcfmEDN6hTfycTiCP5W26aJwVEPv8h38tWW35NxUxbgqBbLyEfhyW6Li8kQzVSA1rXavifz6CLCpEaj1yIRdEVSbeLLTOvArRHaIrY444fxyhBlgS9RcealJsukKg10OGI9VnKx5djY2YG7jOz8bT74KSPCtnOoVC7MM8i+m9AToWjz7zc63frFUkgr9/Bwy9Xe8sokj+WowXZoTX/tOV3il5FsXLgx41/qmOpUo3UMMES+YF4UBbWNv/QkmUTZI8dHzxD+HW+1iq84lZ9WoLAzKnA1p3ST3T/2FBHgfcsWEUdbYSZgP86WRo20kUIWYwtcbGezrIwsXq4tXGbEaUgNogdFlJjXSvjELgo81g14/s9mJ3ke81BOw68k zCsEdGuA ggR20bLN6SDPEvjS+oUFgWQLjzvGiffeRfstWF6H4COI2WT6n+3O+l0NjKXggTSLr4q3NxS+N3xwPZlffTVrHmcbN4K6/8nTxgVZAdDPjiQ6M53u3D2ajxwxiadD16h+wjK3gwHA4zxqG1AmBdcNtSEN/FGqk/uNohwE9+gU0UkmysQJ2WLahSAiVrKm/OFyLrKx2d1juhPwvpQYqjvvGBTUUALMcKmxqpcTfR1YfjUXbyprn2cYpiaDEpi4QktY6ZFx7ZX/G2iHd0rRMfXWTYGA0gvHD2Mq4UV41obakPxDcyFiTdj6JiotoXSY/eGZfHgZKCvoRXLDmCVtnxsMPKc7pzxIFMxX8O2fipE6NBwBgZJpQlSyOH68lRAr5ptNZ6ivGBujNJS9GCmE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.10.24 20:48, Heiko Carstens wrote: > On Mon, Oct 14, 2024 at 04:46:17PM +0200, David Hildenbrand wrote: >> The special s390 kdump mode, whereby the 2nd kernel creates the ELF >> core header, won't currently dump virtio-mem memory. The virtio-mem >> driver has a special kdump mode, from where we can detect memory ranges >> to dump. Based on this, support for dumping virtio-mem memory can be >> added in the future fairly easily. > Thanks for the review. > Hm.. who will add this support? This looks like a showstopper to me. The cover letter is clearer on that: "One remaining work item is kdump support for virtio-mem memory. This will be sent out separately once initial support landed." I had a prototype, but need to spend some time to clean it up -- or find someone to hand it over to clean it up. I have to chose wisely what I work on nowadays, and cannot spend that time if the basic support won't get ACKed. > Who is supposed to debug crash dumps where memory parts are missing? For many production use cases it certainly needs to exist. But note that virtio-mem can be used with ZONE_MOVABLE, in which case mostly only user data (e.g., pagecache,anon) ends up on hotplugged memory, that would get excluded from makedumpfile in the default configs either way. It's not uncommon to let kdump support be added later (e.g., AMD SNP variants). -- Cheers, David / dhildenb