From: Vlastimil Babka <vbabka@suse.cz>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Yueyang Pan <pyyjason@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Usama Arif <usamaarif642@gmail.com>,
linux-mm@kvack.org, kernel-team@meta.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] mm/show_mem: Add trylock while printing alloc info
Date: Thu, 28 Aug 2025 19:21:36 +0200 [thread overview]
Message-ID: <ec2469aa-5586-4169-a8d3-2f768fbe0ff8@suse.cz> (raw)
In-Reply-To: <5ce6yn4iml5tk5zpf73gbxk6z244bkchwuxfpvuervyh2zlqlc@7sanekvjpglm>
On 8/28/25 18:35, Shakeel Butt wrote:
> On Thu, Aug 28, 2025 at 10:41:23AM +0200, Vlastimil Babka wrote:
>> >
>> > I was not aware of interrupt context before. I will change to test-and-set
>> > lock in the next version.
>>
>> Perhaps simply spinlock_t with spin_trylock()?
>>
>
> Will lockdep complain that this spinlock is taken in non-irq and irq
> context without disabling irqs?
If we only use spin_trylock then it won't.
next prev parent reply other threads:[~2025-08-28 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 18:34 [PATCH v1 0/2] mm/show_mem: Bug fix for print mem alloc info Yueyang Pan
2025-08-27 18:34 ` [PATCH v1 1/2] mm/show_mem: No print when not mem_alloc_profiling_enabled() Yueyang Pan
2025-08-27 18:34 ` [PATCH v1 2/2] mm/show_mem: Add trylock while printing alloc info Yueyang Pan
2025-08-27 22:06 ` Andrew Morton
2025-08-27 22:28 ` Shakeel Butt
2025-08-28 8:36 ` Yueyang Pan
2025-08-28 8:34 ` Yueyang Pan
2025-08-28 8:41 ` Vlastimil Babka
2025-08-28 8:47 ` Yueyang Pan
2025-08-28 8:53 ` Vlastimil Babka
2025-08-28 9:51 ` Yueyang Pan
2025-08-28 9:54 ` Vlastimil Babka
2025-08-28 22:10 ` Yueyang Pan
2025-08-28 16:35 ` Shakeel Butt
2025-08-28 17:21 ` Vlastimil Babka [this message]
2025-08-27 19:51 ` [PATCH v1 0/2] mm/show_mem: Bug fix for print mem " Vishal Moola (Oracle)
2025-08-28 8:29 ` Yueyang Pan
2025-08-28 17:05 ` Vishal Moola (Oracle)
2025-08-28 22:07 ` Yueyang Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec2469aa-5586-4169-a8d3-2f768fbe0ff8@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pyyjason@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=usamaarif642@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).