From: osalvador@suse.de
To: Michal Hocko <mhocko@kernel.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Oscar Salvador <OSalvador@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@gmail.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Stable tree <stable@vger.kernel.org>,
owner-linux-mm@kvack.org
Subject: Re: [RFC PATCH] hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined
Date: Thu, 06 Dec 2018 09:40:23 +0100 [thread overview]
Message-ID: <ec66e12d8140ba117a0e98c37f6557bd@suse.de> (raw)
In-Reply-To: <20181206083206.GC1286@dhcp22.suse.cz>
>> This commit adds shake_page() for mlocked pages to make sure that the
>> target
>> page is flushed out from LRU cache. Without this shake_page(),
>> subsequent
>> delete_from_lru_cache() (from me_pagecache_clean()) fails to isolate
>> it and
>> the page will finally return back to LRU list. So this scenario leads
>> to
>> "hwpoisoned by still linked to LRU list" page.
>
> OK, I see. So does that mean that the LRU handling is no longer needed
> and there is a guanratee that all kernels with the above commit cannot
> ever get an LRU page?
For the sake of completeness:
I made a quick test reverting 286c469a988 on upstream kernel.
As expected, the poisoned page is in LRU when it hits do_migrate_range,
and so, the migration path is taken and I see the exact failure I saw
on. 4.4
Oscar Salvador
---
Suse L3
next prev parent reply other threads:[~2018-12-06 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:03 [RFC PATCH] hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined Michal Hocko
2018-12-04 7:21 ` Naoya Horiguchi
2018-12-04 8:48 ` Michal Hocko
2018-12-04 9:11 ` Naoya Horiguchi
2018-12-04 9:35 ` Michal Hocko
2018-12-05 1:14 ` Naoya Horiguchi
2018-12-04 11:22 ` David Hildenbrand
2018-12-04 12:30 ` osalvador
2018-12-05 12:29 ` Michal Hocko
2018-12-05 16:57 ` Michal Hocko
2018-12-06 5:21 ` Naoya Horiguchi
2018-12-06 8:32 ` Michal Hocko
2018-12-06 8:40 ` osalvador [this message]
2018-12-06 9:15 ` Naoya Horiguchi
2018-12-06 12:02 ` Michal Hocko
2018-12-06 6:43 ` osalvador
2018-12-06 9:02 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec66e12d8140ba117a0e98c37f6557bd@suse.de \
--to=osalvador@suse.de \
--cc=OSalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=owner-linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).