From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CE4C021B8 for ; Tue, 4 Mar 2025 15:10:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CD516B0096; Tue, 4 Mar 2025 10:10:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 456296B0098; Tue, 4 Mar 2025 10:10:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AA156B009A; Tue, 4 Mar 2025 10:10:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 02E9D6B0096 for ; Tue, 4 Mar 2025 10:09:59 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BF67FC0189 for ; Tue, 4 Mar 2025 15:09:59 +0000 (UTC) X-FDA: 83184203718.29.4660D34 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf18.hostedemail.com (Postfix) with ESMTP id BF5B71C0019 for ; Tue, 4 Mar 2025 15:09:56 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Fyd4Dj7O; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741100997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YU1w3QfA6u4C4R3HaZ2G+tlwKRKZflGVGh2qNP9EpgM=; b=dgTz1H0J2OB/1AaUKz6QDDIpgmOP7ByZfdVl45rtROHpPSoXfQcC8tQMU2hQsSXYhgh7mx wXmfinEKT2hzgZrDg2NWa/nFV0xtdR932vtpIQTOOytn5YBFuYCulEa/bKNJpjgs65l9v8 RiGqv4l1N3hmkCT84LwtkuqbKN7gbZs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Fyd4Dj7O; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741100997; a=rsa-sha256; cv=none; b=iWjGJ/fJIQDJPwrYxjwIpIp1eHiOVYmiYmC/8tz7UTJKqw4YXNMUw1dnomB62ELmSTQ+7c 882ZOzVwiLdrF4eSHewjJkznVAHbLJYyx//twyt2sIziXRyPn6Ypab4j1ABVZZWpp0Z6H9 Na8pApy3t4SGrXbgefB1CE3a2wGcv+g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741100997; x=1772636997; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=opmnGSMl5a3rw4PfYRN77P+Mh1CbJMCOLTe7ToepzFw=; b=Fyd4Dj7OYOQhgmeVnb0ACIWnNcz2BgNTWnIdeL5dV0NYlU+bbbQyPb/7 KFg8/y7/qojPStP9QpN/tzJEkxaTz6lZIpt7zWQLZHNWs3SnhhHAUZ9Hm CrHUU+EAKmZM2N+RRYXFc/Axn/RhWciF90TkEk7kAuWC3wybjhq18zLO9 kUE1WVyqdemjGVXG6B0KVsSzPGyw+BHBtAFLozGcHMmogUgFjVBi7HGoo y7HEtEVwAw86dMpTbiY0UTXgLJjX3qxbH2x3kh+e0VchQ3aDanttJOWXR W3HahqVdinBOSQfGdEkXi97zb95aEW1PfqZm2PS9tn65D27FCxrKW1IdR g==; X-CSE-ConnectionGUID: uGhfhxESSSm5gpy6ZkI8Ew== X-CSE-MsgGUID: k8/GAxFQQ7aTu7xOQ5r39Q== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="42216274" X-IronPort-AV: E=Sophos;i="6.14,220,1736841600"; d="scan'208";a="42216274" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2025 07:09:56 -0800 X-CSE-ConnectionGUID: Sg0R8AiqRrqT13SZRdhoQA== X-CSE-MsgGUID: WdUDCJMiSBafbrn400eNuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,220,1736841600"; d="scan'208";a="118404768" Received: from kinlongk-desk.amr.corp.intel.com (HELO [10.125.109.94]) ([10.125.109.94]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2025 07:09:54 -0800 Message-ID: Date: Tue, 4 Mar 2025 07:10:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 03/13] x86/mm: add INVLPGB support code To: Borislav Petkov Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-4-riel@surriel.com> <20250228194734.GGZ8IS1iFVpPzmEyYl@fat_crate.local> <30c721e0-338d-4172-989c-5226d584bcbc@intel.com> <34b80474-a309-493b-81e9-3a7d4de8a369@intel.com> <20250304110032.GEZ8bdUOg2WLUrhMcm@fat_crate.local> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250304110032.GEZ8bdUOg2WLUrhMcm@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ray5iusxa839ewx91udixqkg39ngpa1p X-Rspamd-Queue-Id: BF5B71C0019 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741100996-677289 X-HE-Meta: U2FsdGVkX18hJ746onqrdSsG21QrO58YCppDDr2UusXH5vDWqG61BlEN9r2dgeYYk4vo259zmdARfxWROm6Kez2NxZCZv0cKieHMRavgKZh1dE4mJbhB31d7fv2Gfgp8NR3sR7XvTylBgQfYJnGEsxVqnd4SpAalLRs+JqDY/hSqWlKat8rQOgO0uoZCXfmXCdqemMSe4fpDSmJOBu2ObSKyi3HteauoQZhhLkzht8QNn8rsW+Cxf9OWbEJhO8MpNbqkEFFjQhUkfzzZwrZ/ZMaYiMTIGe6K8YiiEvMbwJRueNOPcwsYQ4AKD6vH7UD7xaCpYoR6FI+Oh/nTYJ66UHPC9XpgZKSUWMp3YuFUvVhYAamHG2YLEdRkyxOn4WhI2LUQWEkrewE0q9mTkd1AXDB8PTri/feb8OsxIrw19R1//ZvqpSAnc2xmTFqB4X4mDB/giDKb15BiLM11oxvieXGAYk65VcjkquinXDKBcuLn/B/kdVCnmNhzleNC50i4bK0YLnLHME1TMCj9YDyV+o9yMZ7/v3xkFOfkVybZUUQURZvAJ+ulZyWxSiw2dqN/vrhTrtp9FDQpaCkfPW6dk2q26+yhQ++aRAkhTRuxZ9G7DVjVOfsZgb3bOA3j2YgqbLojSJ7bSpJHaOaVOYtgp/fg004fxfqBV2UsWHbgODwH/3T3bLABmAloXwI7kmcf8xiBbpMKDIBNAljen8urSnteet58ib5wJ3XkTg/do/1L5R8hJM+Kvjyu+tcEUbi+Jx24hEFJ9Skdh24JQtASSShx0bomNyZn1eQJuAtjqu/PSM6/FhOlv6q/wzERFocGAXIubQx8ZInw15d0Q0gSBA/rTDbAN6m8gEuyPSxEqonoAk5UtQd1dvo4i3o9NTek6aL6mSb9mPJFncJJVYRhoyUz0jdNqVa+N9TwWHql2wg4adDJ3mbZ6envHLke0E8pNq5A82wc7NpBr/m01nC DIDzfx81 69MtQHbxyWEsMg/nZ6xXEN7RA5ItLLGWVXhpEddkGTOEzJz9KyMm1NrEvEXPWj5FQ//8omah4KJhpaOK71kfDytFpzuW6DlzVPjkg4R/+EvYP+VyKpPdODbMu7zCbvRPPk2rhmS/hYix5PaxRUnWvscYCwJgmv2hQzfSTChDemzxuaNn1W0WF2Z6zSdP86Y0HAib/KPcgDpSesNkwztngrkr4A41Tv5Y2R8nJXQdfEVaugAFLmxmoowHJzWd4HoYm5+QHAYqjNpVIT2eRSguDdeTBbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/4/25 03:00, Borislav Petkov wrote: > On Mon, Mar 03, 2025 at 11:23:58AM -0800, Dave Hansen wrote: >> Here's a plain diff if you just want to squish it in. > >> diff --git a/arch/x86/include/asm/tlb.h b/arch/x86/include/asm/tlb.h >> index 5375145eb9596..3bd617c204346 100644 >> --- a/arch/x86/include/asm/tlb.h >> +++ b/arch/x86/include/asm/tlb.h >> @@ -28,6 +28,11 @@ static inline void invlpg(unsigned long addr) >> asm volatile("invlpg (%0)" ::"r" (addr) : "memory"); >> } >> >> +enum invlpgb_stride { > > Right, this is an address stride, as the text calls it. > >> + NO_STRIDE = 0, >> + PTE_STRIDE = 0, > > Ok, so those are confusing. No stride is PTE stride so let's just zap > NO_STRIDE. Passing "PTE_STRIDE" to an operation that doesn't have a stride is pretty confusing too. ... > /* Flush all mappings, including globals, for all PCIDs. */ > @@ -117,21 +126,21 @@ static inline void invlpgb_flush_all(void) > * as it is cheaper. > */ > guard(preempt)(); > - __invlpgb(0, 0, 0, 1, 0, INVLPGB_INCLUDE_GLOBAL); > + __invlpgb(0, 0, 0, 1, PTE_STRIDE, INVLPGB_FLAG_INCLUDE_GLOBAL); > __tlbsync(); > } This one, for example. It's not flushing PTEs an doesn't have a start address or nr>0. So, we could have the enum be totally divorced from the hardware type: NO_STRIDE, PTE_STRIDE, PMD_STRIDE and decode it at the end: if (stride == PMD_STRIDE) foo | PMD_STRIDE_BIT;