From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D039C83F17 for ; Tue, 15 Jul 2025 09:52:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4018F8D0005; Tue, 15 Jul 2025 05:52:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B2A58D0001; Tue, 15 Jul 2025 05:52:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C88E8D0005; Tue, 15 Jul 2025 05:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1B1F38D0001 for ; Tue, 15 Jul 2025 05:52:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6DB5F1D9D99 for ; Tue, 15 Jul 2025 09:52:00 +0000 (UTC) X-FDA: 83666032800.26.46D69E9 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf13.hostedemail.com (Postfix) with ESMTP id 6F2372000E for ; Tue, 15 Jul 2025 09:51:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NbFzkmCJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752573118; a=rsa-sha256; cv=none; b=yWaoSS36dwGU+MELKjTf0StLB18rqqk493G11Fi8AOzD5+qVsmI9xl2HnATf0vG1drpje5 1WEuakgG3aJyjUZH9rcVHg+w3auAFItITBsq8a+D81Xwv5tMS9KQkr6QXzYgcnNcR1zCtF BnMd2dvvrkgs0VeqRiOPPPLfo4MBLws= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NbFzkmCJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752573118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+JfCVmz7dmcyIZuFeXL/VPi/f+vUofPTsyu4Vo/HNV8=; b=ARTPndhz4wpneyh1Xon336XQo9mC9cBFdM935RPx4WothEREaIIe2RaZSjDHCgR/C4Vu3j ii0OWsAV2P3M7PQZtaGQphRRH3Uqt0mLTl0SE9auHw0kkpZv6IginwBVp+lzFBo/4lrY2H B1vue/TPedyGqc58IVH8ps+Y0N9pI3E= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-60c9d8a169bso9294653a12.1 for ; Tue, 15 Jul 2025 02:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752573117; x=1753177917; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+JfCVmz7dmcyIZuFeXL/VPi/f+vUofPTsyu4Vo/HNV8=; b=NbFzkmCJ48IT2gp47rRpAnT8UAsp/XNHGKiltkNKb9LQ1MtwDk3+2C+YhOX8L4XF3K zGFs3MrfSW1yeYD6lHS6zlpozalNHpialzvN6uw4cSxaq7o88N0l8La/3meslcbmcmgn HBZzDHTrixsJrCwIuSG2m/OR9zkGkrF9oH9huXlR33JV0zDNxiom2rkV+sIcjduCpIk2 zcJgoGZNmNstPzKySelvkCDzMmAsTYGcNitQh6i0gpu6ADqTgIkrH6O/3ZYKIyMeAfDP 0SvuKykbJiXVrGJ9XJ+ZPEj2AJ7E2kvas1LJ5fVN7yS8hLQzPaap1jbPkny7E4zMMTpJ QkMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752573117; x=1753177917; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+JfCVmz7dmcyIZuFeXL/VPi/f+vUofPTsyu4Vo/HNV8=; b=sAJRLJ1h/9n/9CqbJk5sgLVJfo83DVKs7VHQZPQ1I57INfyS48waTPfHVQXDKOuBZd t8+NszF2lW3+RYERL7CVwOm5CPOgfWIkVSMdWxTNAPHg7pXPbqwi3zb385SZL0DhUu0Q kqHpYHMm0nW97MFYWvP9RGsmUkz+azxZt7kmc4ivlxdUllYGubDGGp2eoBfbvTinFLpH RH+WuzcurRzHKXuH+sz20ELFILtFrLH5WLZ3t7PXD4boZSGYI5ZQWRn0td7QsUYCA5Xs bsqKuqr/qwYjeDIaPvdZnq04/ZKQCcUlATY+b1AkDpbr2zwMbmnDqUiWATthtJay5nJ1 cIOw== X-Forwarded-Encrypted: i=1; AJvYcCWkGsJJoKPEa+mF6AjFUgRJlzMnI2wUPTb3rU6ROujr2z5RgVA59fApIAEr0lUQv0H6d8FsrqAWVQ==@kvack.org X-Gm-Message-State: AOJu0YxQlydzag/HI7qiV+KueeE7xkYdouovXRlY6gBLgM2w7HrgFCaN FBEe/ebVhBVlyNZ70VH4rOpD0/aCoQj63DDnLhmpsZFr5lnAx/IsvXWC X-Gm-Gg: ASbGncs8tB2KAFbCnqkOrTzXph6jxQM5Y3j5HKpcLSHq4avcS/LUk2jYXSFuzbBRqxf 5Q86Vc1oJphXlWy6Os9WEvuB2QpK5iiZF8eXwRoUGX2vNivprdJnLPsyREAqQg5N0iviTROpxQ8 VtrPDR0JXEqfMuoDjivpENOn08ULxY7ZZZwnbAMeYVtih8osrzxlhHK/es25T68Y57DUeSbJofA whFarSsenGKrg+CxYlXppSVGzrfiZoCM0EyUJFXNhvvTUMjYYjjm2vBE69+wAFo+ul6pVtCwlxB Rw08UHOtnETXYCSMasMgfL1LYhALNsUm1FFihSniMA4CyWpOnaXdvh39RW4NuSj2xlqyzz9ts6J a4wcIjhJ9BsCvr4FIjVnLdit1GCnlAuCC5yspLpVlv/cdIw== X-Google-Smtp-Source: AGHT+IFtyv+behObgwuhkDzO4fwWTfcA9W4Bzf00R+XfXl6ZnDUgjY9rXODXpIsVAPEVnRVB4STm/Q== X-Received: by 2002:a50:cd87:0:b0:5f3:857f:2b38 with SMTP id 4fb4d7f45d1cf-611e84aa0e9mr10404889a12.17.1752573116791; Tue, 15 Jul 2025 02:51:56 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::1ac? ([2620:10d:c092:600::1:a4c1]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-611c94f3753sm7018754a12.16.2025.07.15.02.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 02:51:55 -0700 (PDT) Message-ID: Date: Tue, 15 Jul 2025 10:53:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 3/8] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() To: Mina Almasry , Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com References: <20250710082807.27402-1-byungchul@sk.com> <20250710082807.27402-4-byungchul@sk.com> <20250711011435.GC40145@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6F2372000E X-Stat-Signature: s41wcqwdsyn3a8iqbgwad8sya788i4js X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752573118-96123 X-HE-Meta: U2FsdGVkX19ET4/HSdQa1EQHFWzU7JLYe0NN7sArHTzypc3a/reBM6MXiye5iHj5lPRL4uPAes6dZlLr/+hXv2ZEG2UoPHA1dD45kj2DqY+Id4/GPs0TkxeqxGEKoE2iiIUs2gIsL8B/fO54uA+uM8Hy5+Pqj3wuk9/1xGtD7d9cWH1svg1Ri1q6YTTDiNgSHW7WnVH08yKphhv68agjzkR6nPgtFhLnoluWcrPwmpKJ8VvxJCo7wjHIQP5GjbrbRUqvj8bHl6JzheBCcBQ5vf1hAlA+5CzIoYFsJv+uExiLWFiuqEAh+K6Ev7rPFVrTlAgSM3xrJ6+spjU1QCM/P8LItNJi5eDWCkxRmNpjiaQCKQywaQqsLA0frky1HRZTOayfaIE5NbMgCig0oO+Dw8zBaNnVZRpvnVyh2uVx12oiqziw2OxyWP6F9DxmdgMM31Lz7oQ6yb4Zf72JKBgSHmw8FekiJqq0EjEB2R8nKWe2DhUlF4xgxKHdJGJVTKoJ4XbVzbphxhtmjaxwVd6fOzNK9E+lkvWX7H1xZvX5NGXh+hFvPLWT+ojYstKFEmLQzRglgJGDZ0YNnSm/WUqWQaCp1HzWoTZsIfJwxuqUvE9Oo2GVNfvjtLCafnLnNIzeRePw0ZnESgrgCNDGMPNlIIqKkK+R2EfTjgQwxOX23Xh2eLRZFwPANd7wDa21MtiBN9Ckyhn8fwowyL57a+IOuZpBk00DqhM4PbDYHTjwyHS5CgchvXUbwaAbW9x5uq/PSWwgrMiLBZIdvqEFUASOjJmFyiwYUHOtYy+vmnQ40GBdMV2DWpEw6emtLr+eENij3Kg7uJZsQNuxtaEGIpsZnMvYae1Jg1ds/+v7MHm6cm9N76zuD/UpnGsP+0IZxguOsg+ismfWGiMX0a4P9YrsxAdxxXjfbXQfkx+x2ud1kGngHSiP1l2mIO/VyLgrsPf7K1gImvLWnjhcum+Yevq t9reEAxe yDHRve+Oi9nf0Vx0oaE+miSfVJnmI3qU7/jkLMHGuPa614Eg+sSZ1R2d28oVRhQiG7m/N0pcgA/zRA6+2KgBuSMYQAuaLH+juGE3IxMrUXTb08Zdb3x+knlE5kZcW1IDQRrq/qNm+HQCspu7bXM7E1tMllIYAHFVpd+cB5HYxkFfbdTCZXr9kZKI911XnUnhwdLP2zFY4MyEetrxKdo+8m+YtFpuYLJ39qhFrtjJwjvUC+Fd/fyDpEzKzV7+DlQ4/A0P3CMtKi1PicDIgQUdegZ1+kVpVZl90OoxFUu/uuvH0tkzNm/12ZfL40iZWmRz4s3P2jBug4oFGXvAIg7WK1tVVvsIbWbMby2GYqPAfb9/9c2ljkhzu0UhqoFnzDXeNEIS2pRjXoKr7M+nQil4bO9jgF61RKyME2pikfuFnOavevcsEAq5fGhbSvgPKXyDT8AZCvBI7afaD0xb2Jj9fenRwv8rQ/qcBvzUxASI8ELhDAuT3QD1wR/5YlPsTAug1iyUfBv4sM3NgI9S/VfYZDApy5J6tHul+9qO8jEsbnOyM9N6colxdA/8rZyBFnGsyjAOoBqOYM3eiPUltvLiDKeVzPZfybX7P0FEzrwQwz1dVDyh6PI239N/wVQV3ys7s7+/n+WiSDAnaTOftAZlC1ZW4a7E/SHCcxb+5h9SrBzaWIMz4T/DWiHGCjRzEavroIi+iks5AH0gZ9ptBhMYSnHoAUysPSZpExnBI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/14/25 20:09, Mina Almasry wrote: > On Thu, Jul 10, 2025 at 6:14 PM Byungchul Park wrote: ...>> Both the mainline code and this patch can make sense *only if* it's >> actually a pp page. It's unevitable until mm provides a way to identify >> the type of page for page pool. Thoughts? > > I don't see mainline having a problem. Mainline checks that the page > is a pp page via the magic before using any of the pp fields. This is > because a page* can be a pp page or a non-pp page. > > With netmem_desc, having a netmem_desc* should imply that the > underlying memory is a pp page. Having a netmem_desc* that is not > valid because the pp_magic is not correct complicates the code for no > reason. Every user of netmem_desc has to check pp_magic before > actually using the fields. page_to_nmdesc should just refuse to return > a netmem_desc* if the page is not a pp page. > > Also, this patch has my Reviewed-by, even though I honestly don't see > it as acceptable and I clearly have feedback (and Pavel seems too?). I was fine with it as a transitory solution, but there is nothing to argue about anymore since mm already got a nice way to type check pages and we can use that. > __please__, when you make significant changes to a patch, you have to > reset the Reviewed-by tags. > -- Pavel Begunkov