From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF21EB64DA for ; Mon, 19 Jun 2023 08:23:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03A2B8D0003; Mon, 19 Jun 2023 04:23:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2C908D0001; Mon, 19 Jun 2023 04:23:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3E78D0003; Mon, 19 Jun 2023 04:23:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CDB328D0001 for ; Mon, 19 Jun 2023 04:23:29 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9D4B8160509 for ; Mon, 19 Jun 2023 08:23:29 +0000 (UTC) X-FDA: 80918808138.19.C7CB011 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 6C070120012 for ; Mon, 19 Jun 2023 08:23:27 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Lsl9EsX4; spf=pass (imf29.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687163007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sSBDd1/f6xXmLpw9z/ese37NiOW7x5KUx8osjqdGUnM=; b=nnAjrHMYzZnr1C+fWPXtAno4+pRNvKiHwPNpAjF70+nTs/gXUfnTV6vpMBEUNX2IQ1RhTq b0E5pyzfsbWMUhGR9NMrV82wCP21pURMz5bFhA2e1oEOBJBrLQ9/qy2UTKYqAU9rGM39Le 4vHxOWCq3aucJ0oJ5nGHbXEa3FPPqnE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687163007; a=rsa-sha256; cv=none; b=nH0m1yINkisZ9KoXQgbigZNvPBBS0Nm4PYgviAb54vm/5KTewxVPQJruAa+w09X6TVYMKz rS8vgNNtl+wjbpMd5Eh+xVQwdx11tlKBLJ/YCrrS68NbJE5dJAbKYo3327AdXM/McGsnt+ 5N+hjxqCcajOgjzUBeog43DFGhczWrA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Lsl9EsX4; spf=pass (imf29.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3113da5260dso659262f8f.2 for ; Mon, 19 Jun 2023 01:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687163006; x=1689755006; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sSBDd1/f6xXmLpw9z/ese37NiOW7x5KUx8osjqdGUnM=; b=Lsl9EsX4jszeG2zvJgvVKjDAR4ejPIDTxSfqQw+n1L8gF+f7OgxW8IkzEQptJqo3jv 3f+ywIeXHzCLnN0BoQSzh140TYGbvtlQxK/WgKGmeNw5JVjmePsBpRc/5edy2o+A6K4e xKbkbq4gGu1DhMfFjrYklap/6XWzpXgxGliXuvoPQVpsRAJWgm94xVVfGJ9BpMkUgxUk VRC7iOeu1H2s4wj6R7f9m3VkuG5nOKdFVuL4rAX8gCJpS7QXFsDSL6zOUNjme/F2KwVY qpTmxDZhXR9U4EmlqJnuWTgGn7HiKIssbn/9KC7Lc3wQ6vF4BFh1IhIM7br3SEmVKnG+ 3kHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687163006; x=1689755006; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sSBDd1/f6xXmLpw9z/ese37NiOW7x5KUx8osjqdGUnM=; b=KqfuuA2cdStoT4Gq0UDKibt4TsQq07n3URyHTnTZVERRR+1QZiPrFd6ZBkzNLDeDkp G2Ho6/K0h6lWflUTwYA5U3lmZ7zLPDkzSbhmU3aRJKl1MrXg9g+KOFi3afpX1GiTU6nu pElov60McYSfmfOQf82iLl8RLwlYQ8aCCDKwM8Rf7zBlM609ZCBzz02u+4lUwJkiMkcL CA3erkrcjr5VPrQCinrNuLkvfqKIZuFpSbBkQZlp635Ix2ptTmuq1lFcR4PnspbFXpdQ aYi5L32pVm9U+UlRWSfDR340iLM+Pe5Sx31vMxhrOkgwUR35tHrc60WzC8ZgeCSTR3kO 97rQ== X-Gm-Message-State: AC+VfDxIdlt2gCwt9/kJm19kdmoGoawNT8N9sUeSaVgLWLhtSG2uD0gE pxjpMCbji5aZ0CbAxwtTWzQ= X-Google-Smtp-Source: ACHHUZ7EeWzzK8WgDL/QMovggKVNr0k/fH9meoPoVMqoAtP4sO1FreA9c6hWXDPwYHtwf9V0pzIqIg== X-Received: by 2002:a5d:568a:0:b0:311:1497:a002 with SMTP id f10-20020a5d568a000000b003111497a002mr5516686wrv.3.1687163005624; Mon, 19 Jun 2023 01:23:25 -0700 (PDT) Received: from [10.158.37.55] ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id e3-20020a056000194300b0030ae901bc54sm30867342wry.62.2023.06.19.01.23.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 01:23:25 -0700 (PDT) Message-ID: Date: Mon, 19 Jun 2023 11:23:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> Content-Language: en-US From: Tariq Toukan In-Reply-To: <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: xq3a1oht8dx6az64caoorhj61thbe5mr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6C070120012 X-Rspam-User: X-HE-Tag: 1687163007-681822 X-HE-Meta: U2FsdGVkX1+q4CJ8V9T5dTNtalAXCOsMceB6pDSp7l9hKfdiQ7abUyLQaFRuHlCAzmc3iS4v6z+qNnWq7YPnSoknPxnnkkVeIhgdQ6vwlQzkwRPI7CrPJWpbNrZ1kExywxTilFUdg3hCl1Mwb8prj9pw7QCDennQ/MqmhIH8Y5cwTJaOn5n6bcQWCwmnXkIKmBo/AYTdC2E5EQr6sTtjuApCe2MY11QOLSUVUR2Xbu2zxu/l2bh9+Pk88LBj3RxnhX/BW7xvkcF4U3Ra6IX7YzhUIKWfYbhWiDApZxKm0JsnxuzZf6XkbdkNyLUvlnZcxl5OE1EmIJGBusWJ+U0R9YsJjbMdaT1bPES6ecDOlmZpg5UhbnWIunMGUUm9vKWqNT9Nec7lSBZFRA2m3lvSFehVAw5tIP8XHgBDVc9su3CsA8YdRr1NGfH2Ur2hf3B9gNxW1K/JqlveaJ1ewdCnK8xv2fPLkXYBdChiLOH2i5AeH1giYaPQ+ZEAbhAJ3yws5tBVirFpxlA77aVked1jj/2kuOQL/CQxqhfaHgztyRSOLQFYoCGtL5IJtKgTnXe3VeruvoXwBVAqLrO/0IsMtxzvpUZfsN0ar4VsZ8/4pZx3C8neK9AH8fIZPtTF/a+pQTsdo9tg/wNibHh/7EtJgmnIZGsZJF/7XBdwYwz8R5ro8KnrQrzQXpvMSbvwlT3Zz9iFmrJlvA0U2UYOT6kjLtnvBoRQ+0KIYEx0zhD9n0zwBocN6DhmNVE4Wr6sx1OfQqYMKetV7vvJwCLxL0bxMLMwTNCxS/C9YHICaYs0rGiUCgI91bzp+iPFqfmgGnHb6oBdPOARtzAs+d7OuX9PkOtS+j2XoQW2hbE+p8u3k0Q/TPlynaubpa/JjF7Dw9GMbjy2z4NUQLPQrDDF1MZ2GPRyYdlwS7153XM2FVU0gB+7ls0xLa/YjwDzyw+i7+EHuuzMkcYMjTKqgKpnoBj V9TmYgjH UdXMLzv8a/VWp1ShP4y4p7KSaAKbuuNeee+a9tygKANxlWEzeRFOZ3ryatWV8ssTHptCWluloW1Vmb+z2IFCv3NmCcV1XQgTgL+at0FSzbo3rph6++j0VA2LVlP+PTLoYrmzfmqwDrDQz9y/BA5MolwgK6X45xgXnfJUnvch0vACHBWreNePNP2MU7FhPqli/muvq6LfQ7+jtmE8xlUIAUzDTvMHbTUeJJCJZZ3BsLA7wt2Dph4DRfA3184QqZ9Po/M03HF6RyNhDuybHZHs2Ju9BG04vuoSY38DmP9UZRf2ZJiKwP5p2jFDrfHUVvWPjZOGT8YAKaHhxogvqH21gWkywFzGMEHgo651ppMuihOcNvk87gYNYyBGJeekS/xdBsZKrvg5T0LwNu6KJmnkZ0YRbmRJXyjQa8fm71tgEkbyQEYZ2m8gZ0t4Jxp5zCqxRn1s0Gt1dStXd9YS+mPND9EgLx0LMHk6Tv3BKVoIQsHOTuDrxjUYCIl7TF9ppIbRWBXAjDl+qDB3idLMKeHUSBIv5HfvLe5w9IxwoC+XyKv5jzkzsg7iXc6eezx9q6yWA4U5TUCGXe0W63S2jyWpHDJvqAcTsAZ7t+9KS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13/06/2023 14:15, Tariq Toukan wrote: > > > On 07/06/2023 18:03, David Howells wrote: >> Tariq Toukan wrote: >> >>> My team spotted a new degradation in TLS TX device offload, bisected >>> to this >>> patch. >> >> I presume you're using some hardware (I'm guessing Mellanox?) that can >> actually do TLS offload?  Unfortunately, I don't have any hardware >> that can do >> this, so I can't test the tls_device stuff. >> >>>  From a quick look at the patch, it's not clear to me what's going >>> wrong. >>> Please let us know of any helpful information that we can provide to >>> help in >>> the debug. >> >> Can you find out what source line this corresponds to? >> >>     RIP: 0010:skb_splice_from_iter+0x102/0x300 >> >> Assuming you're building your own kernel, something like the following >> might >> do the trick: >> >>     echo "RIP: 0010:skb_splice_from_iter+0x102/0x300" | >>     ./scripts/decode_stacktrace.sh /my/built/vmlinux /my/build/tree >> > > Hi, > > It's: > RIP: 0010:skb_splice_from_iter (/usr/linux/net/core/skbuff.c:6957) > > which coresponds to this line: >                         if (WARN_ON_ONCE(!sendpage_ok(page))) > Hi David, Any other debug information that we can provide to progress with the analysis?