From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Michal Hocko <mhocko@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mm,page_alloc: Use {get,put}_online_mems() to get stable zone's values
Date: Wed, 02 Jun 2021 21:45:58 +0200 [thread overview]
Message-ID: <ed17a39ad61edeb19b04c0f4308d5d36@suse.de> (raw)
In-Reply-To: <39473305-6e91-262d-bcc2-76b745a5b14a@redhat.com>
On 2021-06-02 20:37, David Hildenbrand wrote:
> Long story short, using get_online_mems() looks wrong.
>
> Maybe the current lightweight reader/writer protection does serve a
> purpose?
It was too nice and easy to be true I guess.
Yeah, I missed the point that blocking might be an issue here, and
hotplug operations can take really long, so not an option.
I must have switched my brain off back there, because now it is just too
obvious.
Then I guwmess that seqlock must stay and the only thing than can go is
the pgdat resize lock from the hotplug code.
Meh.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-06-02 19:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 9:14 [PATCH v2 0/3] Memory hotplug locking cleanup Oscar Salvador
2021-06-02 9:14 ` [PATCH v2 1/3] mm,page_alloc: Use {get,put}_online_mems() to get stable zone's values Oscar Salvador
2021-06-02 18:37 ` David Hildenbrand
2021-06-02 19:45 ` Oscar Salvador [this message]
2021-06-03 8:38 ` Oscar Salvador
2021-06-03 12:45 ` Michal Hocko
2021-06-04 7:41 ` Oscar Salvador
2021-06-07 7:52 ` Oscar Salvador
2021-06-07 8:49 ` David Hildenbrand
2021-06-07 10:23 ` Oscar Salvador
2021-06-08 10:42 ` Oscar Salvador
2021-06-08 15:00 ` David Hildenbrand
2021-06-09 9:42 ` David Hildenbrand
2021-06-07 8:42 ` Michal Hocko
2021-06-03 2:32 ` [mm,page_alloc] [confidence: ] acb5758bf4: BUG:sleeping_function_called_from_invalid_context_at_include/linux/percpu-rwsem.h kernel test robot
2021-06-02 9:14 ` [PATCH v2 2/3] mm,memory_hotplug: Drop unneeded locking Oscar Salvador
2021-06-03 12:52 ` Michal Hocko
2021-06-02 9:14 ` [PATCH v2 3/3] mm,memory_hotplug: Remove unneeded declarations Oscar Salvador
2021-06-02 18:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed17a39ad61edeb19b04c0f4308d5d36@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).