From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79597C5B543 for ; Wed, 4 Jun 2025 13:17:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CE966B05DE; Wed, 4 Jun 2025 09:17:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A6666B05E0; Wed, 4 Jun 2025 09:17:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BCE86B05E1; Wed, 4 Jun 2025 09:17:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E59536B05DE for ; Wed, 4 Jun 2025 09:17:16 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8B67DC1558 for ; Wed, 4 Jun 2025 13:17:16 +0000 (UTC) X-FDA: 83517769272.05.815316F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1B43BA0009 for ; Wed, 4 Jun 2025 13:17:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZPOUSQEJ; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749043034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bIO55ksEFdETkeVPuN9/YoTmoE0JSO6vLQWMjgK7hBA=; b=EG2JrGO6j+kmtxRyCcfFx8IY6OnEWgxyckX081PGtrK4NkYSXSU51/cD+WPdfLyvDWFvq/ Xy35a88BRQJErA9qn+6alaFfQ0J2XJlw1FMTAyDi6kBHytsthUerKNfxo0/zWAMqbxANPT oNjwCSWLGte7S/FXFMaw6mtDfAL6JZ4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZPOUSQEJ; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749043034; a=rsa-sha256; cv=none; b=duJ1bWOvM89NDJhqJYwg9kUPsdZzztHLO4ZqSN7i8ttE2eXwLlgybmWPlWUbpJwrO41UNt 77pxA+ArKN0ohZYyiOajsU5TReanoIoiTCesku8OBL2YVhbjljz72JBWZR+3eg7TUsVC+m KMRzzfS8gqtf8DWiC0yW+UnoXGns25E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749043033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bIO55ksEFdETkeVPuN9/YoTmoE0JSO6vLQWMjgK7hBA=; b=ZPOUSQEJfmL1h80mqwwYN4ceQW5H05tXOwyHEoIrCL7yjoqntCR10n5Ns1+92NX0p/+Fzf NH4gL2weucV0nuGve9U326nrEIHt0I9rqG3Zh7uPXnJGB8Yrn8Uaiqod2ACKsG8ZT4bTyv H3YEydlqMhG/Lx9ugwA+yEEimtHE3/E= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-O4V64CedOwyGMsl7TgzJbw-1; Wed, 04 Jun 2025 09:17:10 -0400 X-MC-Unique: O4V64CedOwyGMsl7TgzJbw-1 X-Mimecast-MFC-AGG-ID: O4V64CedOwyGMsl7TgzJbw_1749043029 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so45222955e9.0 for ; Wed, 04 Jun 2025 06:17:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749043029; x=1749647829; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bIO55ksEFdETkeVPuN9/YoTmoE0JSO6vLQWMjgK7hBA=; b=ZFXM+gDj/EBziB7i4daEfTbtC2rrHYfrvNf7l6vlL4WuMARj0l/j2SNmp1gjoFeOzV GG4WjbdSbNWsA0ULj534n4Z0IsZr5TR0Zi0ZIwohgpNTu/pHVnqTuq+xOXPFqWZhjITV 9j3E94xPUY3KBXe6isuNrlWDJRymtfnYwbwO10QzYWIwJCQObqXe3y1iabDlqMNYRkGF LKSxNEVmcLHd5H/Xxj67+qC8kSI+8jD/oQ6cURI2+tbwrzecWqzYT18aaXJlnoXHk1Al +Bx4bBWMOz/X3M2cfjlCuqNVFzoXu5yJ9jhh8JzRoz8JMnXQA8mtlEPrGQb45a7zZiFQ XF5Q== X-Forwarded-Encrypted: i=1; AJvYcCVBTmwmjEZj1brur3EO9aTg9lau2JZ6a6M2ujYTp2KQWphxWz2x+Ul+YydP9jz09duwR5a2l5db1g==@kvack.org X-Gm-Message-State: AOJu0YyViw73vgYImvDgT1dmU8QrZAko+R5P5USCwx0Q7s3OO9v31nVw vwqHQhZAsB8L842RB7axNRP6ovmmqV1ZiX47qmFYuN8go2paz9Ri+uCch6CkpRFQB+UffrR/bbl TNY/2ukfTZIjTTuX6YUL7nWCmFicHZkzz8tVfmt9Dfk35RKnnsX0L X-Gm-Gg: ASbGncu4QtL0TEC2vwfSlXOSApYySV6aE/+s4r6kTMi/bGQFzWMWsHV7LCTufDqm72y U09ODF3nXJXI+TsV7anHlaghykutLWuQLIRrWcWJci0JnZrlnxrpDl3SFBezTccNGcOcmQDy9hd tYfTubo5IimtNeXnruyQF/xEW2R+Vw3Kb18y622gzUwsCiiJOk0E10mhemzPG2wqdDaO/DHbDDe 3Ip0AxKWRi/X4xtawYDenVl9ZkGXZGS9yJs7/l3T3EFCXW5buAItuern0I+LNMFuKI3KoQeD7ql 6CgFIph/uTnWDljeqFZNjFrRDs6gCePREQ7GF6A5YayB00AOwGJP7zm/gJuI26c85ZKPJGML3lb 2ObiN5900xZzZVadTJzJJEo7xY13lK2LX0QJpJJE= X-Received: by 2002:a05:6000:1a87:b0:3a4:f7f3:2840 with SMTP id ffacd0b85a97d-3a51d8f60c3mr2508202f8f.1.1749043029089; Wed, 04 Jun 2025 06:17:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHj6QdN2FkVHcXOshhIV/yEB/MAbubLpFJhi81QGj978EJzjeBuLXZHtjKOcWLjb0qoD8TCJA== X-Received: by 2002:a05:6000:1a87:b0:3a4:f7f3:2840 with SMTP id ffacd0b85a97d-3a51d8f60c3mr2508161f8f.1.1749043028548; Wed, 04 Jun 2025 06:17:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d800671csm201084705e9.30.2025.06.04.06.17.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 06:17:08 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 15:17:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 13/16] KVM: arm64: Handle guest_memfd-backed guest page faults To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-14-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250527180245.1413463-14-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9gcT_yjkEamXvwcP6soFyS8YCiJ6nS1-mOvyZqiooII_1749043029 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: miq6y8r78cjj43efb7bxeudqsoz1bo3a X-Rspamd-Queue-Id: 1B43BA0009 X-Rspamd-Server: rspam11 X-HE-Tag: 1749043033-302202 X-HE-Meta: U2FsdGVkX1+qF+lCzBEeFchMlv1Zo1nuuLFM6C7NUpYV9ucTQtxutOVz6P6/IdGjrSyy0h8CHx8YP/itvNxXUrF/YWyIbo2aIlEddBVr+Ih4VvDwK/X0PLgb2ht/goU5Q+6rKoOd67T725xv95G5pQ1YR2C6JakIIgSIJ+rhEWjmjzNRjPMei3ToIern84kMXK2UtaL3iDzsYxo5Q2RwUpCmwTfqj1EtAPAbafaO7YH4K9/loTlqXJvY+8Pu2zSXOjgeZhtL0/bne2ld8IyvOi9StW0fT7ptnaReNTRFnFrcPec0zQgJXGZBXeYYZDYzQZRtlwClRA8B7VsSNhM4QyTIvq/CNgRbRYwwdrB96EzNj4StiADLFgS/rgs3P0zJxbkRuZoZQ6geZUwmTgxZLcG9KVPPDT+k3jIsGLb/eoh525JuUNuRFxXH7mA4uxPnM0/iy8pPwyvaRamGRlT+1+Ma7p1MqX2iI2qTfJLjsEinxuC92RpA7/PcfktkMm2zPs/kzE7gbHXa6zlEylyIqKJRGSXj3E8sLekP8u+AsdpnBkoDi3QEX3tIa4DY2UnQK0qzNiM98QB3SRoHdGnuPrrg8KsSnyhv8JvmnI27V+k+4g9nVhGlDGcapr5w/Cp9Wt7XDM0yIzAuSrpjKczZoW0dyPOxLL66DMfptWy8DgmPWm3DGIZjfsdcBqjB+MTAGMR++LYu0zfbk8fPC7UfqAKRQAkYOE0kJfMi24xA/3EAXsTDJjwg5eM85teasuAgTU8wXo8xYRKENWPtU23RwIJ5UIcw+JhDSBBXhtRY25FW3NXqxmnLH/EZ+a8FNtpEY0kfgJ7aCqD6kRcV9fEQWByxgpHIvw4FNVYJpCBnINurBa9v3oRx0ybT/qr/6vuTTyU5ZCOIKsYa2B6wWI2ZILA1OlA1NDQbQKrd8NM1eT7SNHtOKueExATILGzvpU8fB8Qugy8kP6uLB6PQJO7 kis/vaiy TcFBVPR6X3zR1l2RhYrdiiWNxJA47OifcoFzWfPARveZR+NrvDXUs5ifUSdYJ8qU7TyhnGAX3+Qv816yHcHQ3F3BPG015Quxokg3hlQTibNaADaUPvkkPQNC/mKuiPsBJWyu3LIO8mB+ijIHmu5BWwycaCKleAcVbEnAsR70apqG9z/RB2C/++Dub9F8gxKzVZCv9t+0WsudJK6MSyzBteTzgyw4iAmCjGget5ZSZahJV9RjEczJp6eBtGsHWUnz7trx+UEqlPyhUpgxJgOAU5z1OxZzKJ3AkaNxVmq/AMOqFyWc0yTxDhEcjoEc09YqT6wJfqVFlUkFH8/D9cd8RDONUaS4hwdBwrXFphrsgAh84zkGhwmyvFN+ZRM4X2vYS4lGQ3vqNErtbAEE0MYrllfO6vIPiAYb89BNqDNgRCr9RQ0RsrzFvIyDRRewGjz8yjh2K5kSRvGT1Wqq80+8VzRWdWCClFx8llxdqhIWYoKb+kMLMECANjJuOz2/CW1ubI7t7F6PbFb35x/6xLTFS+yv8lVM9HnxEadhb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.05.25 20:02, Fuad Tabba wrote: > Add arm64 support for handling guest page faults on guest_memfd backed > memslots. Until guest_memfd supports huge pages, the fault granule is > restricted to PAGE_SIZE. > > Signed-off-by: Fuad Tabba > > --- > > Note: This patch introduces a new function, gmem_abort() rather than > previous attempts at trying to expand user_mem_abort(). This is because > there are many differences in how faults are handled when backed by > guest_memfd vs regular memslots with anonymous memory, e.g., lack of > VMA, and for now, lack of huge page support for guest_memfd. The > function user_mem_abort() is already big and unwieldly, adding more > complexity to it made things more difficult to understand. > > Once larger page size support is added to guest_memfd, we could factor > out the common code between these two functions. > > --- > arch/arm64/kvm/mmu.c | 89 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 87 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 9865ada04a81..896c56683d88 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1466,6 +1466,87 @@ static bool kvm_vma_mte_allowed(struct vm_area_struct *vma) > return vma->vm_flags & VM_MTE_ALLOWED; > } > > +static int gmem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > + struct kvm_memory_slot *memslot, bool is_perm) TBH, I have no idea why the existing function is called "_abort". I am sure there is a good reason :) > +{ > + enum kvm_pgtable_walk_flags flags = KVM_PGTABLE_WALK_HANDLE_FAULT | KVM_PGTABLE_WALK_SHARED; > + enum kvm_pgtable_prot prot = KVM_PGTABLE_PROT_R; > + bool logging, write_fault, exec_fault, writable; > + struct kvm_pgtable *pgt; > + struct page *page; > + struct kvm *kvm; > + void *memcache; > + kvm_pfn_t pfn; > + gfn_t gfn; > + int ret; > + > + if (!is_perm) { > + int min_pages = kvm_mmu_cache_min_pages(vcpu->arch.hw_mmu); > + > + if (!is_protected_kvm_enabled()) { > + memcache = &vcpu->arch.mmu_page_cache; > + ret = kvm_mmu_topup_memory_cache(memcache, min_pages); > + } else { > + memcache = &vcpu->arch.pkvm_memcache; > + ret = topup_hyp_memcache(memcache, min_pages); > + } > + if (ret) > + return ret; > + } > + > + kvm = vcpu->kvm; > + gfn = fault_ipa >> PAGE_SHIFT; These two can be initialized directly above. > + > + logging = memslot_is_logging(memslot); > + write_fault = kvm_is_write_fault(vcpu); > + exec_fault = kvm_vcpu_trap_is_exec_fault(vcpu); > + VM_BUG_ON(write_fault && exec_fault); No VM_BUG_ON please. VM_WARN_ON_ONCE() maybe. Or just handle it along the "Unexpected L2 read permission error" below cleanly. > + > + if (is_perm && !write_fault && !exec_fault) { > + kvm_err("Unexpected L2 read permission error\n"); > + return -EFAULT; > + } > + > + ret = kvm_gmem_get_pfn(vcpu->kvm, memslot, gfn, &pfn, &page, NULL); > + if (ret) { > + kvm_prepare_memory_fault_exit(vcpu, fault_ipa, PAGE_SIZE, > + write_fault, exec_fault, false); > + return ret; > + } > + > + writable = !(memslot->flags & KVM_MEM_READONLY) && > + (!logging || write_fault); > + > + if (writable) > + prot |= KVM_PGTABLE_PROT_W; > + > + if (exec_fault || cpus_have_final_cap(ARM64_HAS_CACHE_DIC)) > + prot |= KVM_PGTABLE_PROT_X; > + > + pgt = vcpu->arch.hw_mmu->pgt; Can probably also initialize directly above. > + > + kvm_fault_lock(kvm); > + if (is_perm) { > + /* > + * Drop the SW bits in favour of those stored in the > + * PTE, which will be preserved. > + */ > + prot &= ~KVM_NV_GUEST_MAP_SZ; > + ret = KVM_PGT_FN(kvm_pgtable_stage2_relax_perms)(pgt, fault_ipa, prot, flags); > + } else { > + ret = KVM_PGT_FN(kvm_pgtable_stage2_map)(pgt, fault_ipa, PAGE_SIZE, > + __pfn_to_phys(pfn), prot, > + memcache, flags); > + } > + kvm_release_faultin_page(kvm, page, !!ret, writable); > + kvm_fault_unlock(kvm); > + > + if (writable && !ret) > + mark_page_dirty_in_slot(kvm, memslot, gfn); > + > + return ret != -EAGAIN ? ret : 0; > +} > + Nothing else jumped at me. But just like on the x86 code, I think we need some arch experts take a look at this one ... -- Cheers, David / dhildenb