From: Yunsheng Lin <linyunsheng@huawei.com>
To: Liang Chen <liangchen.linux@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<hawk@kernel.org>, <ilias.apalodimas@linaro.org>
Cc: <netdev@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH net-next v3 2/3] page_pool: halve BIAS_MAX for fragment multiple user references
Date: Sat, 25 Nov 2023 20:01:00 +0800 [thread overview]
Message-ID: <ed236fc1-fa6d-5ffc-54db-2c44448ea5fd@huawei.com> (raw)
In-Reply-To: <20231124073439.52626-3-liangchen.linux@gmail.com>
On 2023/11/24 15:34, Liang Chen wrote:
The title seems a little hard for me to understand, but the description
below does seem clear to me, so LGTM.
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
> Referring to patch [1], in order to support multiple users referencing the
> same fragment and prevent overflow from pp_ref_count growing, the initial
> value of pp_ref_count is halved, leaving room for pp_ref_count to increment
> before the page is drained.
next prev parent reply other threads:[~2023-11-25 12:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 7:34 [PATCH net-next v3 0/3] skbuff: Optimize SKB coalescing for page pool Liang Chen
2023-11-24 7:34 ` [PATCH net-next v3 1/3] page_pool: Rename pp_frag_count to pp_ref_count Liang Chen
2023-11-25 11:53 ` Yunsheng Lin
2023-11-27 4:21 ` Liang Chen
2023-11-24 7:34 ` [PATCH net-next v3 2/3] page_pool: halve BIAS_MAX for fragment multiple user references Liang Chen
2023-11-25 12:01 ` Yunsheng Lin [this message]
2023-11-27 4:22 ` Liang Chen
2023-11-24 7:34 ` [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool Liang Chen
2023-11-25 12:16 ` Yunsheng Lin
2023-11-27 4:23 ` Liang Chen
2023-11-27 10:48 ` Yunsheng Lin
2023-11-28 10:41 ` Liang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed236fc1-fa6d-5ffc-54db-2c44448ea5fd@huawei.com \
--to=linyunsheng@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).