From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06969C61D9D for ; Sat, 25 Nov 2023 12:01:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 796086B05F6; Sat, 25 Nov 2023 07:01:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 745476B05F8; Sat, 25 Nov 2023 07:01:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 633E26B05FA; Sat, 25 Nov 2023 07:01:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FCE86B05F6 for ; Sat, 25 Nov 2023 07:01:07 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F94CC047D for ; Sat, 25 Nov 2023 12:01:07 +0000 (UTC) X-FDA: 81496335774.02.3DE7A1E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf20.hostedemail.com (Postfix) with ESMTP id 40A501C0021 for ; Sat, 25 Nov 2023 12:01:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700913665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jaTnI23A4ADVuUR7tsIGbN2AAsHE5W6IY0GE/VlDWtM=; b=tKf+Pjuw3dyKHinm6lvQpf6RpjhiyFVE3opDdS0kiBHmkHkvzhhfC6w1iAuOLFrTwMi0ks 5geTnq5eLfNkDojVH/pq/hnrbmvujcrK5K3IZmMDdlQZbSqwZ0dprn4B0bpZdxP4DjXrQd PdG3rcirZX4tBkoShjAdkRJIbTjV5qs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700913665; a=rsa-sha256; cv=none; b=GcLrhyJ4ySSFve8HePWKfUxR8yK35U6E6HNRLLiT3sv2GlL2P0P6jkueXZeiUDzkO1CJue jsVNwGMI4xkeMr6KQNsgtAOZfRj/Ru59vP10TPim8XbfQW0/jKo95TtNzhtdlc8bizyB7t xMADPaholcdQ5kTcXzViJt2gnG1o4IU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Scr5Y2L31zvR21; Sat, 25 Nov 2023 20:00:33 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 25 Nov 2023 20:01:00 +0800 Subject: Re: [PATCH net-next v3 2/3] page_pool: halve BIAS_MAX for fragment multiple user references To: Liang Chen , , , , , , CC: , References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-3-liangchen.linux@gmail.com> From: Yunsheng Lin Message-ID: Date: Sat, 25 Nov 2023 20:01:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231124073439.52626-3-liangchen.linux@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Stat-Signature: gr7qx1pjgpme5eck8iiougy9piagk6x4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 40A501C0021 X-Rspam-User: X-HE-Tag: 1700913663-886668 X-HE-Meta: U2FsdGVkX1+De677T+9GjmGTzkDyOkT6me6oAXr+zGaon5o4MeKNnS8Z3LRYVY6E4YJEYonWEMDy22JnNdCv7YKJBzVvRbKk1rLl8I9UEYG9P34ZeRc+hv85O+1HmdavmKFshvFv9t1kJ5UkGJhyt8mMDF9+hSnduP0Ae43ZFefuwiAm8kWtQbTJ5kMjaoUiedmXzzFgBYL9JU6hi1C4yQr/TBM1ACZDxP/QRX4VSWmnt5HHw8FigNEv3XqyRQ/+7Le9fJwJeKVhtevm2vm3a5IkdN20Iati3iiyr+c/+kGlnU1da6GQc+/7BahsoXrpDDM3qDaBuB8uwADdLXHc7PgB8KKsuAsNrKmi3Stgzu+91abQX0HCJqAmTiZSLvjhHGoKqD82XLTPV8WujJUzpPrZ78qVMabZn3QG+cNTuNYMasd9uKgLBbTmr1QOjUiIrcR9dExtr9L4hTyYY0iwwYkXbrskx6Vo38isujMgNIczv9u/w1LfCTKEQamSFE+0e2gq5pbBIHMspQ6WHk1wAtH+Gfpg6/RlDEEGtsu4W20GCIDWANRE1vKP9RxKa/Q7zMY0veXb2L7nNYdNXfUxxq9/Cxzt3SRwq+Q5Y7LzlSrzvxI2EZLr7O9BfBPrB+0T7Hm+PlML0gnPMznvItIy6z/GzWVbtl/9DMO7eDRoDe8MJZgnVyIGhcqBSHeIr+fiZMNGk7vQI3kT8iZax+Guw7KJca0LfvlpzwpNV/7aK4FDcBvpdH5OgKagncCHt7xH87mU9c0tgI59B+fxQKNd0HeKn7YQhsa43w0fMYeXHjcIMqG8945x3M7AiZ6QjoX1VYwTiU4qQzauMw9MGAdexqx5S9RqD41JWqEJLxyRAF7wQFwN0Piq7KE54nE89vKWP0I851edmyJiWJnSLVIM9gy76ZOIXpBkOZccx6kwrL01OA4BL191QQacq77dVv7sT3g0wEEX04M4+/mq3Gm qXpy/pde kP9i0Q7uOllTKQ4MfuxpOJHmOIDZhphjBANoHGlXBQ4cNaVATwgcMs/tuvo4vmTfq9SE4OWXcGoCr3SD24p4eU9WkPT/8Dr0W0BLyRS6ndj7iK8wOTTE6puUgkdzuWpVvKC5ZU5XwYydV9aPpBISZpMYvMOp954zNTZQPyQnTE8xsPvZSdoPXsMc6nLYRHq5iKsYxwemC3BtB9AYqKn/WcL+e2SVSkdVdZWLptBDSb9ybcmiJr1Q4CwV7KUAMmEOL18J2ejtxF2bW6A53yDbwh4ggMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/24 15:34, Liang Chen wrote: The title seems a little hard for me to understand, but the description below does seem clear to me, so LGTM. Reviewed-by: Yunsheng Lin > Referring to patch [1], in order to support multiple users referencing the > same fragment and prevent overflow from pp_ref_count growing, the initial > value of pp_ref_count is halved, leaving room for pp_ref_count to increment > before the page is drained.