From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6995C433EF for ; Thu, 3 Mar 2022 21:27:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D35698D0002; Thu, 3 Mar 2022 16:27:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBE058D0001; Thu, 3 Mar 2022 16:27:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B88158D0002; Thu, 3 Mar 2022 16:27:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id AAC7D8D0001 for ; Thu, 3 Mar 2022 16:27:44 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F4EB20B9B for ; Thu, 3 Mar 2022 21:27:44 +0000 (UTC) X-FDA: 79204362048.09.AE35813 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf28.hostedemail.com (Postfix) with ESMTP id D04FCC0009 for ; Thu, 3 Mar 2022 21:27:43 +0000 (UTC) Received: by mail-io1-f47.google.com with SMTP id r8so7399141ioj.9 for ; Thu, 03 Mar 2022 13:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ih0JJt97BBLYj6Fn0f3k3bViw991U3vBLG4c2N4VIno=; b=Pf7u6B9wHbx5Ozd3EXU+1heavGLb89mO4+WtHg+MxHJM7uaFi7TVvEc7m8OxmUOd7X PDHum2XOROhKVlbmwnJ6p4R4fO325YxCEo8Zwn+nSpeNthHHTQvx8pdExlbnGzEYv+6X /R3lrU9fRntHH+wdRb5Tlgp/HD6eIbsc2wHJg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ih0JJt97BBLYj6Fn0f3k3bViw991U3vBLG4c2N4VIno=; b=vT+7vpcXiQKEl6CUU68K3OT6KkqofX8qjkgLO56rrqktIawvATHZaC0qcBxES9UvV6 yNYXtd26zOHKmydLVp9TTVPgz4zYbIx7dNIEIqnL8WSHnW1MpwWUBQV5G+pfOrObBJH6 m5rUvuJjuvLdP/o2VIIJvjeUp+wzXvkdOb8txPB5Ce7fCbAy+OnJ0NrIO7S7E+Yi1FH0 4FrwDZktVoI48Kdu3VLBx20N6OcCi7sYZm6nKm7DHE1N1th5kHPlkov2+EouqcktPhkH FffMTWHLspw4GkYa3b2Z/A/vUSkgfj/QRKiwsFPyyNUMokCuOeW65l9WlPADti2iJu5l Fbdw== X-Gm-Message-State: AOAM533yqfzHLO2rmDf8aKA8BHXb8ALyesgB3/utRZLb21Q7FBAz92DQ aX6jyQLI5ez6pSYP87Zy51jIcw== X-Google-Smtp-Source: ABdhPJxLJkLqkINiqGbVbJ4zT+0L5Qkaxvre0HSWGZ/ryhqV8qgdVfxgM0lguf4zYT5cA+cNSVWMVg== X-Received: by 2002:a05:6602:1541:b0:645:7001:8ad1 with SMTP id h1-20020a056602154100b0064570018ad1mr2991689iow.192.1646342862987; Thu, 03 Mar 2022 13:27:42 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id l1-20020a056e021aa100b002c56271ac39sm3120534ilv.56.2022.03.03.13.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 13:27:42 -0800 (PST) Subject: Re: [PATCH 2/2] kselftest/vm: fix tests build with old libc To: Chengming Zhou , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220227055330.43087-1-zhouchengming@bytedance.com> <20220227055330.43087-2-zhouchengming@bytedance.com> From: Shuah Khan Message-ID: Date: Thu, 3 Mar 2022 14:27:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220227055330.43087-2-zhouchengming@bytedance.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D04FCC0009 X-Stat-Signature: i6bunxrx6jkg7z5481kt6gqthwn6gkje Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Pf7u6B9w; spf=pass (imf28.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.47 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1646342863-706068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/26/22 10:53 PM, Chengming Zhou wrote: > The error message when I build vm tests on debian10 (GLIBC 2.28): > > userfaultfd.c: In function ‘userfaultfd_pagemap_test’: > userfaultfd.c:1393:37: error: ‘MADV_PAGEOUT’ undeclared (first use > in this function); did you mean ‘MADV_RANDOM’? > if (madvise(area_dst, test_pgsize, MADV_PAGEOUT)) > ^~~~~~~~~~~~ > MADV_RANDOM > > This patch includes these newer definitions from UAPI linux/mman.h, > is useful to fix tests build on systems without these definitions in > glibc sys/mman.h. > > Signed-off-by: Chengming Zhou > --- > tools/testing/selftests/vm/userfaultfd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index 2f49c9af1b58..3fc1d2ee2948 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -46,6 +46,7 @@ > #include > #include > #include > +#include > #include > #include > #include > Looks good to me. Andrew, If you want to take this through your tree or I can apply it. Reviewed-by: Shuah Khan thanks, -- Shuah