From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B24C04FE0 for ; Wed, 9 Aug 2023 19:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23B906B0071; Wed, 9 Aug 2023 15:04:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C4AD6B0074; Wed, 9 Aug 2023 15:04:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 016C98E0001; Wed, 9 Aug 2023 15:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DF6BC6B0071 for ; Wed, 9 Aug 2023 15:04:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9A019160FD6 for ; Wed, 9 Aug 2023 19:04:53 +0000 (UTC) X-FDA: 81105493266.13.24F580A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id E482A1C000E for ; Wed, 9 Aug 2023 19:04:51 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AneNvnqJ; spf=pass (imf21.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691607892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=alXrKPD5fHXeJn9UjHKim4LKQU7HoozYjQglaZ1xXaI=; b=6HaZ4W2t79KrXj96bwYyWl28sglT7+6hVr3Ca0SqoxoKVZNOS5jToYYJC32VGjFujq6pUu Ch4ZZ5gHfxdPzsp0IEANwNF+GIM8EvrGqDEts0XKNnw4HPbgUsbasoIfjfAw5hsTVA1ifd tLZUFk6bW7hqSHNeUJ989QqvaWdAqxk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691607892; a=rsa-sha256; cv=none; b=sEoE2aVcKigYwaER5YEWimB/W6qXkGncxORsPCd4F8RXJN0GhXMdDh+XJX7NR6dtQGk6/U s6zdp2BmEWaDRTfi4K6dCMXmR8R/nJ1ImDSETnDWJ0iHpciESliPnOu65+IuHtn/T36IFv xRVwdhROPHkLp39CzcQBbyhcd2LsTns= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AneNvnqJ; spf=pass (imf21.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C947D644DE; Wed, 9 Aug 2023 19:04:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB107C433C7; Wed, 9 Aug 2023 19:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691607890; bh=alXrKPD5fHXeJn9UjHKim4LKQU7HoozYjQglaZ1xXaI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=AneNvnqJ20CJmKiEgeASfLx4NSIFXV4j2vtzAKGnX32iLsSf9A43S7wAfHVHbYQQP h3ON9dJJ2d4zasDcG0OHa5a1AfenYnO+uoesgXhOt+soOjJtmmxlhUNc5QuXKGuVOg rulv+awus9qyVEIGRttUpq9Lcin2kAZfB093o2LczBjmWrzPbu4HcAMNS3Ib4zj45p 3u7x0mQLZuZR6+lN5gsi60S8IiOPzBT4vt1n3+KsBq67CA1z2KjKobM8vv+qdWmPsN ddnXMIFOGmdQH1E3uRbvXBai78DI/EAYz+8n3M9qwxNTsQtwGjIcAPpzsM/ELjqang 5ERP9Tcme3DHA== Message-ID: Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp From: Jeff Layton To: OGAWA Hirofumi Cc: Jan Kara , Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Date: Wed, 09 Aug 2023 15:04:42 -0400 In-Reply-To: <87h6p86p9z.fsf@mail.parknet.co.jp> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> <52bead1d6a33fec89944b96e2ec20d1ea8747a9a.camel@kernel.org> <878rak8hia.fsf@mail.parknet.co.jp> <20230809150041.452w7gucjmvjnvbg@quack3> <87v8do6y8q.fsf@mail.parknet.co.jp> <2cb998ff14ace352a9dd553e82cfa0aa92ec09ce.camel@kernel.org> <87leek6rh1.fsf@mail.parknet.co.jp> <87h6p86p9z.fsf@mail.parknet.co.jp> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: oo7pbrii9tcwewbfjfyz983kt3oepdos X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E482A1C000E X-Rspam-User: X-HE-Tag: 1691607891-654226 X-HE-Meta: U2FsdGVkX1/7fMbtfGkv5uUsbyqbp9qyI3+98a6Kmk7M2epwjKY8VGPE/uTOWhNT/U/HNTYeOY4TYsjBalyDHseuAobmSlpOl7Sg0TkoUW5NPvpoL79nL+Hs0X4pVGDP5fqjO/AJ3PUoeXddh5zO0Mp7aJa4c3z1ItvS5eoT/MNtqeeH3N5dkJq9y/OPM77ZOh00ys98CpTKrbzyALMnBhazhzJPxFQ9rjfTwBr4rwGUIIrQ7+CdpWRhq6+Ezg4/YjPQRuteC65P/yJdSke1GB1u+tF3QjmdOkzlz8uoj2IHweWZEiYlHfHkobYszNKtJ78FBYYluO3muAEIMEkA7Y/1EKUlElCW/TtXTkTtqtWnbnbuZW5LXWpgW/Cy8ZZZ7rch/8a3/i4JsfvJJrfMOapQrD8VzKN4xwTq8Hawh6GyAh2CVgnGKEl827xrw65nwzwqUKYC7tvzFsVvglmPxMOmb28IuMwBmeCeP91ojiKXlw7Rm/6Gc0qYl1vCvTDHUV3a4Ke2nD/jrD1ypPNfzh2q9b4RHaAivsAMgcYWABo88ktq4kpehsFoTKCJR8Rc1l5/fl5yS0ppbpURBFoZx2NITsAaWLFZU1e+MM0pPsYKqUZnQGnaviRSF0i3XPPGpxtUbCp5VLn9YCi4IOdcF3O+P7uyZ1UeoiEfY8Ne33uyJnLDmG3x9xYFoCubKNpJkSHRrYyrsBmW+Ecm9VpTMVUpV5rLk2k/gu3ApPLbbVl4Toc7XQjE308sahi/Y8mGhoaJ6gNVDVx2ql+kEzAqtwrTOmT05EOu9yhqdPVuq8teSYBbx6D1wbOioHrkkmFHUx2W+c4VnSBox1TNpVsULAvo0H+3dJhj9PqWn5T8YF+bGCu4G2JYHaSLLAmJvg5lkLED40+ukP7yQ9xQ1HxHlbkvKjFc1TeCpLx52QyNS9lqY9yscaUfiYXJV8GvmIhSVNWAhJCS6w2MeDmta92 B97vYawW OTsVfQyNxahD+L48PR1mO/RQfVH5OsAMvbAHvZwpZrnUrKO1Foob+MjWvFVUbV8c8UQCIG85nssGmU9LaCbTevhAAwMBFqJPCePzIquQrH7SrW+/wcUy1ROsjg99eubYa3/UOt7Ci0Se1XgG8c9vnP1O34DaOn5zeRFVQDZQi0B7I1gZ2IP2HlrGAu4mIL0rUvFx6bsow/fgZcQ+4Ar89XAPkGbj0Vk7G3Igect+kB7xrKcLJUnzGMLYRc+9L1J0yB1wbzcBR612J9Y/Bu/wEsPN1X+g+uMUTCXSw83yM6tOFVqsqvYTaZNBnYd3SSK0/BDY8LPKeZk8p5TXQJfkFYufwgUbfJfDnSZtL0QW48k2PbZYgnmrqCzcAkUkqV2Ro8fjj+ckGwe1XU64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-08-10 at 03:31 +0900, OGAWA Hirofumi wrote: > Jeff Layton writes: >=20 > > On Thu, 2023-08-10 at 02:44 +0900, OGAWA Hirofumi wrote: > > > Jeff Layton writes: > > >=20 > > That would be wrong. The problem is that we're changing how update_time > > works: > >=20 > > Previously, update_time was given a timestamp and a set of S_* flags to > > indicate which fields should be updated. Now, update_time is not given = a > > timestamp. It needs to fetch it itself, but that subtly changes the > > meaning of the flags field. > >=20 > > It now means "these fields needed to be updated when I last checked". > > The timestamp and i_version may now be different from when the flags > > field was set. This means that if any of S_CTIME/S_MTIME/S_VERSION were > > set that we need to attempt to update all 3 of them. They may now be > > different from the timestamp or version that we ultimately end up with. > >=20 > > The above may look to you like it would always cause I_DIRTY_SYNC to be > > set on any ctime or mtime update, but inode_maybe_inc_iversion only > > returns true if it actually updated i_version, and it only does that if > > someone issued a ->getattr against the file since the last time it was > > updated. > >=20 > > So, this shouldn't generate any more DIRTY_SYNC updates than it did > > before. >=20 > Again, if you claim so, why generic_update_time() doesn't work same? Why > only FAT does? >=20 > Or I'm misreading generic_update_time() patch? >=20 When you say it "doesn't work the same", what do you mean, specifically? I had to make some allowances for the fact that FAT is substantially different in its timestamp handling, and I tried to preserve existing behavior as best I could. --=20 Jeff Layton