From: Randy Dunlap <rdunlap@infradead.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Hackmann <ghackmann@android.com>, Tri Vo <trong@android.com>,
Linux Memory Management List <linux-mm@kvack.org>,
kbuild-all@01.org, kbuild test robot <lkp@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gcov: include linux/module.h for within_module
Date: Fri, 29 Mar 2019 11:10:49 -0700 [thread overview]
Message-ID: <eea3ce6a-732b-5c1d-9975-eddaeee21cf5@infradead.org> (raw)
In-Reply-To: <CAKwvOdmv4_8pN5r8EO8c59WN+EE7ZPST8qHKMg7SzPH1rzaqag@mail.gmail.com>
On 3/29/19 11:09 AM, Nick Desaulniers wrote:
> On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
>>> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>>>
>>> Cc: Greg Hackmann <ghackmann@android.com>
>>> Cc: Tri Vo <trong@android.com>
>>> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
>>> Cc: linux-mm@kvack.org
>>> Cc: kbuild-all@01.org
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
>>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
>>
>> Did you test this?
>
> Yes, built with gcc 7.3 and
> defconfig
> +
> CONFIG_GCOV_KERNEL=y
> CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
> CONFIG_GCOV_FORMAT_4_7=y
>
>> kernel/gcov/gcc_4_7.c includes local "gcov.h",
>> which includes <linux/module.h>, so why didn't that work or why
>> does this patch work?
>
> Good point. May be something in the configs from 0-day bot. Boarding
> a plane for Bangkok, but can dig further once landed.
>
> Maybe module support was disabled?
Yes, I reported the problem with CONFIG_MODULES not enabled.
--
~Randy
next prev parent reply other threads:[~2019-03-29 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 8:06 [linux-next:master 4291/4370] kernel/gcov/gcc_4_7.c:162:9: error: implicit declaration of function 'within_module'; did you mean 'init_module'? kbuild test robot
2019-03-29 17:45 ` [PATCH] gcov: include linux/module.h for within_module Nick Desaulniers
2019-03-29 18:01 ` Randy Dunlap
2019-03-29 18:08 ` Randy Dunlap
2019-03-29 18:09 ` Nick Desaulniers
2019-03-29 18:10 ` Randy Dunlap [this message]
2019-03-29 18:18 ` [PATCH v2] gcov: fix when CONFIG_MODULES is not set Nick Desaulniers
2019-03-29 20:53 ` Randy Dunlap
2019-03-30 23:57 ` Tri Vo
2019-04-02 2:54 ` Nick Desaulniers
2019-04-03 15:24 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea3ce6a-732b-5c1d-9975-eddaeee21cf5@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ghackmann@android.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
--cc=oberpar@linux.ibm.com \
--cc=trong@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).