From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E35EC12002 for ; Mon, 19 Jul 2021 06:35:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 467D561166 for ; Mon, 19 Jul 2021 06:35:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 467D561166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE8538D00F4; Mon, 19 Jul 2021 02:35:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D98508D00EC; Mon, 19 Jul 2021 02:35:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C121B8D00F4; Mon, 19 Jul 2021 02:35:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 9EFEE8D00EC for ; Mon, 19 Jul 2021 02:35:42 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3EEDD182CCFD0 for ; Mon, 19 Jul 2021 06:35:41 +0000 (UTC) X-FDA: 78378376482.14.19F774A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 8FB929000668 for ; Mon, 19 Jul 2021 06:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626676311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=VyL8LrzoP8cupK4fD6/DLdTVXUk17NBDDFrnzUmb2HxDjCS6D2Uo5Opm5URyEc1KvkaDnS 7tcSEyzDLnlPIIJzmG0aBmPAfyOZhCnUOBj3KvIocQYqFTYnrp4sLB6uswXMIWSRKcuRRG X2zulMuBCpdNCSbkiihBCU1PytfkmRE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-BVJ-JaFuP3672jboQp2u8A-1; Mon, 19 Jul 2021 02:31:48 -0400 X-MC-Unique: BVJ-JaFuP3672jboQp2u8A-1 Received: by mail-ej1-f72.google.com with SMTP id de27-20020a1709069bdbb02904dedfc43879so4862337ejc.1 for ; Sun, 18 Jul 2021 23:31:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=SAfE/VOA8K9EBJWtLQedRG6ewf8ApAs2A8QvpmC4GECDnPPyQ1GPXjBM4Vd7cvgIYf q1T5peanHZp/NO7Vrbplj+/IpxLc2XMjXhTm73V5KuJyus/Auw/n+6qHvq6i+UgJowkW v4FgKEdxndjj2eBVwuIHdmFJei+QnRKnk8KSh9nWbfvtrSxyOInnWqpU5U7mZ12JOuhc gz0HFDKnK6pk2WbgeLN/Vv7d10GKsy17bpYSO/EVhcMLYNgJRV8hEiyyXcLY9I4Uj7Dw W0abyvkbQ524rBiwsvg/Hu8HL7rXSIvjXs/Xyd/AgEzj/BgVnF5DoxSyez4wzIBFw9is fBuA== X-Gm-Message-State: AOAM532ITA7gyk5YdakOasahm0o4Kd4LoOCi0MjE7iQUvALD69f7NbVv V6P7w6YVP8sQ1g46rkvr8X3kQ8qQPdPed3cm/Jquqqp6XK0Fkq/8dy2kmHTSihDlHXqpQI1wqUu W/Hwreksjilk= X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130817ejp.443.1626676307274; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwKAXQ0jz8kg1aBiPUIh7/qkMfflW9/UFkvvWaaFSOpzP+F0zQJJOF6m/qps2butenIEa5BQ== X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130798ejp.443.1626676307142; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id f24sm4761419edv.93.2021.07.18.23.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jul 2021 23:31:46 -0700 (PDT) Subject: Re: [PATCH 5/5] KVM: Get rid of kvm_get_pfn() To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-mm@kvack.org Cc: Sean Christopherson , Matthew Wilcox , Will Deacon , Quentin Perret , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com References: <20210717095541.1486210-1-maz@kernel.org> <20210717095541.1486210-6-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Mon, 19 Jul 2021 08:31:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210717095541.1486210-6-maz@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VyL8Lrzo; spf=none (imf29.hostedemail.com: domain of pbonzini@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Stat-Signature: 3b4kbmkkgyf3jrseecteqeksr5muubt9 X-Rspamd-Queue-Id: 8FB929000668 X-HE-Tag: 1626676312-298389 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17/07/21 11:55, Marc Zyngier wrote: > Nobody is using kvm_get_pfn() anymore. Get rid of it. > > Signed-off-by: Marc Zyngier > --- > include/linux/kvm_host.h | 1 - > virt/kvm/kvm_main.c | 9 +-------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index ae7735b490b4..9818d271c2a1 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -824,7 +824,6 @@ void kvm_release_pfn_clean(kvm_pfn_t pfn); > void kvm_release_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_accessed(kvm_pfn_t pfn); > -void kvm_get_pfn(kvm_pfn_t pfn); > > void kvm_release_pfn(kvm_pfn_t pfn, bool dirty, struct gfn_to_pfn_cache *cache); > int kvm_read_guest_page(struct kvm *kvm, gfn_t gfn, void *data, int offset, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 2e410a8a6a67..0284418c4400 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2215,7 +2215,7 @@ static int hva_to_pfn_remapped(struct vm_area_struct *vma, > * Get a reference here because callers of *hva_to_pfn* and > * *gfn_to_pfn* ultimately call kvm_release_pfn_clean on the > * returned pfn. This is only needed if the VMA has VM_MIXEDMAP > - * set, but the kvm_get_pfn/kvm_release_pfn_clean pair will > + * set, but the kvm_try_get_pfn/kvm_release_pfn_clean pair will > * simply do nothing for reserved pfns. > * > * Whoever called remap_pfn_range is also going to call e.g. > @@ -2612,13 +2612,6 @@ void kvm_set_pfn_accessed(kvm_pfn_t pfn) > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_accessed); > > -void kvm_get_pfn(kvm_pfn_t pfn) > -{ > - if (!kvm_is_reserved_pfn(pfn)) > - get_page(pfn_to_page(pfn)); > -} > -EXPORT_SYMBOL_GPL(kvm_get_pfn); > - > static int next_segment(unsigned long len, int offset) > { > if (len > PAGE_SIZE - offset) > Acked-by: Paolo Bonzini