From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1373C5AE59 for ; Thu, 5 Jun 2025 08:15:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F3D26B0088; Thu, 5 Jun 2025 04:15:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CBBE6B008C; Thu, 5 Jun 2025 04:15:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E14D6B0429; Thu, 5 Jun 2025 04:15:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1CD9C6B0088 for ; Thu, 5 Jun 2025 04:15:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A1FF1EFCD2 for ; Thu, 5 Jun 2025 08:15:49 +0000 (UTC) X-FDA: 83520638418.08.8AAA899 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 03380100005 for ; Thu, 5 Jun 2025 08:15:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bdPh4mLG; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749111347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TWFAHyI2oWBZIYDgyjO/aLqdP+qyYXsDarr/6F4sU78=; b=aSkWwFviXIpkT4V4y1bKeTd37l2saTpZAq4S41zM0xlnHPU197cKczbkxiwYzVjbYzmQR2 0NYplxmMcd0pNTgYS1Pf9p3f7JaonFwfI9ph6zI1FJ9/j+AtHcHXkkxTXp1W23/ecvyF1q UdWwabr9a68wuswDh0K41LMYJf6+nLE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bdPh4mLG; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749111347; a=rsa-sha256; cv=none; b=0rHQIVUfisWMZl49YG9Og+X7zMEiRa33euzXRehlNQhoASjt8fDPZfz5lpxkHMWow0dNbD b1/EWX/w00aGUh/p4yhkbFkPG0ftuCyX/Hk0vrm7OAkABj0dOUIHC5S0mNnWNzzLs+1qK3 QT2VjxgEsGrEczUUYEnm1/uVlAtCOe4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749111346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TWFAHyI2oWBZIYDgyjO/aLqdP+qyYXsDarr/6F4sU78=; b=bdPh4mLGZY2sPsw89vdZoGgZHMKohaQG8Xnboc2RUUH1BHL+p4nAr5QBXMTHewd7v9j3ju VTkYJPcDHpTw4BDuUMI1JJrsPMXOidSN1bZJKOWjl/XcZo2jw10myKp2x0RpFlhhCeqnW8 +vVAnmgv93P9eIzoIqHvYrhum04+Beo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-FhfTUE2qOOSs4UC4xq1cIw-1; Thu, 05 Jun 2025 04:15:45 -0400 X-MC-Unique: FhfTUE2qOOSs4UC4xq1cIw-1 X-Mimecast-MFC-AGG-ID: FhfTUE2qOOSs4UC4xq1cIw_1749111344 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a503f28b09so341227f8f.0 for ; Thu, 05 Jun 2025 01:15:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749111344; x=1749716144; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TWFAHyI2oWBZIYDgyjO/aLqdP+qyYXsDarr/6F4sU78=; b=Vjh3TuCBxt/x2khTF0c3+jtwIKEyrg9IPlguLjDsh5GiD//g+b9j23A87jEttH32i6 RSbj4Y65UYMU7pHnXzosT2cCR1hQVTboX0VqItGqPb7/bS9UbKzw9nvxxdJx9TvQWc5q v0DbLwlGU/Tc4sa5P34Hg14fry2ju3pYbcoGK5OGJBbmU+5Oix4/nUhowVILcmBWn4d/ NO4FodWk9tzQ93dH7tcyS8lfJbCVhAGQGDiISotSUvGVrUjV4wjTbipK1DJzzT/G9n9S RQHosaN+Uz4WOE0z29UKex2WhR70JV11cshA4oP66PuOyTFUlrTPocAgSFFlHPBgPxhG EeZw== X-Forwarded-Encrypted: i=1; AJvYcCX3KBuDZKmgQPl4LtkuGHA7uWtHv9baTDNTGdeEguUlt304OH0nkwhtd098Zdlj52OsYKK9sCnwnA==@kvack.org X-Gm-Message-State: AOJu0YzfZTCIIgM0ZhndLHqmz73dpouLxQqmenQooqH3o1ZJ2H1WYNin BqHZPM9KJzB8oj/ijHt3cB8JC9xOhmsleJtn6u1dIx8r2mVbUXtss5LRkJlwSfNshiUrgGrikd1 RF6D2Czknmu0SVUc/z5o1kJHLv5/Zhsy4OdDrokBGGUXlt4pYP3Oh X-Gm-Gg: ASbGnctfFFfwH957X7yF4/IOEWzMcl8DD+EvxuK/zXZPDetcTz66zg0m+COwMOR7sr6 AaREmTcRtDN0qRraZttOyJ6lNJSPcGzf2eCzBNN95V75EtDz1dsR3YQWKpA+JX0+veFLGCp9uTp FGX+R+p1eyVwpea83y50XsDWCkyjgchtk5z3CrTFTnjWN3kX8arypR/sGSCMu+ecewz7g6k4fMR kUTguUeOesJjQO/gLeGfo2gMnTvfkrhY50n6sNz2Nu+NfAJldibxPIIyCA6VUXhpaJljs/FYG7t HJTXo6lx7efT8o2V/RxDwb1uWpuRSrRtAV7i+jVcruxf3gVwv22POHlhLRnM6+skJLEGoLUayRU BHZ17f4uKwsjM3Z1UkNzcYGa8Gg98X/tH/ixg X-Received: by 2002:a5d:5887:0:b0:3a4:dfbe:2b14 with SMTP id ffacd0b85a97d-3a526df4e74mr1861415f8f.16.1749111343869; Thu, 05 Jun 2025 01:15:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFw1voWF+d/eUMVg6y9seEwaoPlJCwiUiJqOTXVX/JiytzpP07QXaXPke/xd8dIDszc1oBy6A== X-Received: by 2002:a5d:5887:0:b0:3a4:dfbe:2b14 with SMTP id ffacd0b85a97d-3a526df4e74mr1861375f8f.16.1749111343389; Thu, 05 Jun 2025 01:15:43 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe7414fsm24272686f8f.55.2025.06.05.01.15.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 01:15:42 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 10:15:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: pairing the trace_cma_alloc_start/finish To: Richard Chang , Andrew Morton Cc: Martin Liu , Minchan Kim , Kalesh Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605072532.972081-1-richardycc@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605072532.972081-1-richardycc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KOZvU_PGQmZEo7rUq8tohvQdFPz9gbZKnxLRiHzPaBs_1749111344 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 03380100005 X-Stat-Signature: 5t7w1s53we3x3fue1hw15orymisekb1k X-Rspam-User: X-HE-Tag: 1749111346-226104 X-HE-Meta: U2FsdGVkX1/9pAuVFkj6SDnUKyWEum6SwSTV9scREcz6lZLCyhCn7xR30VpqVWkLsySneEX+6aEDZGdIfvDalRwOvUsqow8r3HlfJtuWGytkJiDttXPG+4+MqNmrZvTkHA3MH21pzKhLwjbjV76PeEF+n2t9TI1d11X/m5/AgyABZDMeGqOTPhluoL+74jBA/vinK6l2BocA0kZZJgINpYXMEIJNSNi7e5VB2PuMGGIRZ+p0AMw/xyoTdMTVadLxt+mwEnXysjez6YymASNVVHCUE8/Yo7kCVrVUFJ9hgUIOlbDETpD/s9xqH3e4FYwzuA7U7J5MAEZiLhfRNlYCIZyOPfbD1NuzZy5C8q0cB+aBwQOd3nQUmIlGhrwPta2LY4YOKu1TGU/z0vL27HkNvYKxMmL21d6OWRkc3NpYM0g7bHOuqFh//iFeEZhsFokBWnxWNe0NFyDelf9X/swt8gTYdSlGEf56rO/Hl90fB2jkdXrz8g4kQ0rm1UoqForM2YvjAio7IIfO3wABlBQZd3Ahd6Xo1frZoVlq7r29Pltwf0zrSN4sH0M3Mydl2m1kgs0oQ/L8GhO0mnOdWCGoHgJ+48ZCV6FIYCFeUK4mG8xm0drtYmqvG/8GGQCX2phwlSwzk1zRS+K6BZtUZoNYlZ808IuL4YMzdqXv6JJzphsi5s6Kdm0JXkvOBamC7edAiX79hlnJWCtYRnyifbKy3sDNc3hhoi4UlgZqT+u5q6h4FHMENEHiUPeBttWgwI6Df+OtVSL4GkMKjGPPxvuG+lEuNXzff29TFzgPh0ltYOZhTqiYE+V4kONB9zeN3kL0zBdYhB6y64kRjxVSe9tV/w2m6XGBWOjxxJTrB52rEqqrYqrkbFhe1T+lXSP45bM0P+0dxPp+Z7t19zPGqUlvVQ4kFcBinXbTIZ9Ye6l+Y6aDZ3enpdsJgnvwpVGs2YPuKjNSgtvchQoMSTLLuwC XS/EbdJ5 7zpU7QKpsjw+KyUS0zHJttuJf+qjuSzA43MvMJImo7LbYCs/zVKKXvIr0ipNgIV/RZV0JSl510CG2T34IYHEevHYVBp01GcaMYqoiNkn32Yr4Wp3lNxlvk6ZQGy1N6KmadTQwfzEkGyOxm76CtyGApfmVUQsp3XeCHJacfBkVKmlPVvfVx9xPI0A3CQdQlZsAh3CljH5f4UMQwYi3S0tqui2r4Hyrq0P5VqKF5yB7WRBxoW+DFJNvzJO386lMEW/MlcFDgvdzo8KcVNnkc3pZtJXduBg4ptIozzcEdXGF5NqHGuBkDv5rOGHBAna/BaI600bxIQLhrI0DcWSS4YKqPTZfWPpxWNSkf0PBTvBZLnvpFmVe/OYOhJx1qti3uXP2/kdcjLHi4N0A+iMXsPwpU9jgfHEzu18ZTzqDe8cFFgusn/nYXxbiP/sxfCm5JnG1hshcKC/akJ+PQ+sHAqfpXpHPv5kd1J9KoxSWjI84Fiy3o1/VsPLUdZVb+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 09:25, Richard Chang wrote: > In the bad input validation cases, there is no > trace_cma_alloc_finish to match the trace_cma_alloc_start. > Move the trace_cma_alloc_start event after the validations. > > Signed-off-by: Richard Chang > --- > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 397567883a10..bd3772773736 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -854,8 +854,6 @@ static struct page *__cma_alloc(struct cma *cma, unsigned long count, > unsigned long i; > const char *name = cma ? cma->name : NULL; > > - trace_cma_alloc_start(name, count, align); > - > if (!cma || !cma->count) > return page; > > @@ -865,6 +863,8 @@ static struct page *__cma_alloc(struct cma *cma, unsigned long count, > if (!count) > return page; > > + trace_cma_alloc_start(name, count, align); > + > for (r = 0; r < cma->nranges; r++) { > page = NULL; > Acked-by: David Hildenbrand -- Cheers, David / dhildenb