From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DCC2C19F2D for ; Tue, 9 Aug 2022 14:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8EBD6B0073; Tue, 9 Aug 2022 10:57:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3CF26B0074; Tue, 9 Aug 2022 10:57:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DD646B0075; Tue, 9 Aug 2022 10:57:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8E9386B0073 for ; Tue, 9 Aug 2022 10:57:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6AA89A06CB for ; Tue, 9 Aug 2022 14:57:56 +0000 (UTC) X-FDA: 79780358952.26.D92BDE7 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf01.hostedemail.com (Postfix) with ESMTP id D197840181 for ; Tue, 9 Aug 2022 14:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660057075; x=1691593075; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=c4OlQACnlgF7EiwwjFivbcgriHsBbGqtJVrPmg09I08=; b=prXmdpiWbCUtLgm4NfXwyEjYHnekHgNcgG+UmjzzbhGYTV/aI41OYQ9q 9ItQJjjSeBQWN5Or5N5bxMj6a+/kNEiVd26qobGu3XXcDOAhCRAUCaUqD s7QdDI41TIeMdCaWBryrFR17vwQTy79rwHbP7Irvta9wu97+z1XicBZqx g/7gMcvYI4rQItAIklcN0yBelt/3kHLCNHhMznSA2vVs/+up82jx6n6Mq LDWPUxq5lh3W2rXv+UB3Vg+EU6Ua8UP86EuVVMIvHlFRhmOgHflq7KmS0 yXgxqixfTnHuChShv6hn1v51AigzkxEMLtP2qBpjXZnhxYjUw5f08xoYZ g==; X-IronPort-AV: E=Sophos;i="5.93,224,1654531200"; d="scan'208";a="320343357" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 09 Aug 2022 22:57:54 +0800 IronPort-SDR: 6kjDVC+cF8H15eoDY+5RUaYqyGWpayVgZcLP1AbGsaWxYy2QqJ+LuENQP/PKR3697qhqCjQXL+ 2W0a3IenipVHwcF6dviHKAE8SL1JCBVB5D77a8d9ce5EbvJ+jUMJ7iHuOCec230WkX7+J/ahPN yHuAzmgRF0Ug9E5/CjEt+KyTACw5ltjMVEMCM3fWLyji7vrZqjrTHO+3hqKBekSb+Xc1BCpB+J C3elyU4uOTIr8gVGqY/ddKtVGVQS/7BrLfTkQWR3eyio0L4O/xU4Gqc5fjVVAr4kkmtXoah6DD /yqzZjCtLIA7TxTyf8EE6RCQ Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2022 07:13:34 -0700 IronPort-SDR: D/baGuk6f960Vkr+jMn/2o3B32lY6RknIlk8yo6W5P3nPZNJMLcxB2DyX24IdgtIPoe1Lggrsx sTV1sWnytXW1GUY9r5+Bdqi6kcuvcVHl/vATbKqPIuH2AJmqoB+mhnDJ2TbqWFzpFqeR8HCYqX Y4qmufLYTXXYLalOjZY+i4lR3KKTdUJLkQqQE7rvT2UwPysV0PcVfGGp2iM2QUR8IK1k4DfAIe MtEeozqynFdEBiEjLc+VORxFnh/57rzggqI1oNEv8TWqDMlO949nCWKkq3+/p+rJ1B45c0+9oH v9Q= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2022 07:57:55 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M2GQT59WYz1Rwry for ; Tue, 9 Aug 2022 07:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660057072; x=1662649073; bh=c4OlQACnlgF7EiwwjFivbcgriHsBbGqtJVr Pmg09I08=; b=HNpRgF5j2w9HqejYQ0X9G5Ul3dFnBEnCvkxyAIluWxIXUlajtFg sEm2OjDgO9kPJZyJN2SE1HC8MgxB4ODsjIMb95mxRDSG+/sUb7VVxaemq++S0f7s sCLZ1wxav1ztGG5zqEt31pyICJeuUYsSAgHCZI1SmIZsphI8Pzv3MjQe2MZ6bgV+ XgXYzJrEJBqpyQqyNo/DAgMwI2cEqJzgK7p1DviN8tVnxV82b00QBq60rT/BYcnJ 8CPnmNb+AMycv5u1wpOXCMLOHDiKWj11vMqC1DmSkWKvwmhVuwR8Y+IixBry47P0 1m99yw5FjVKWZFJ3a/twW28rnbRNXDzHKfg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7dO2NYhthgBU for ; Tue, 9 Aug 2022 07:57:52 -0700 (PDT) Received: from [10.111.68.99] (c02drav6md6t.sdcorp.global.sandisk.com [10.111.68.99]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M2GQS1cFyz1RtVk; Tue, 9 Aug 2022 07:57:52 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 07:57:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression Content-Language: en-US To: John Garry , kernel test robot Cc: Christoph Hellwig , "Martin K. Petersen" , LKML , Linux Memory Management List , linux-ide@vger.kernel.org, lkp@lists.01.org, lkp@intel.com, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com References: <1f498d4a-f93f-ceb4-b713-753196e5e08d@opensource.wdc.com> <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com> <16f03f81-a8c7-bacf-c74c-67231f7f7202@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <16f03f81-a8c7-bacf-c74c-67231f7f7202@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660057076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c4OlQACnlgF7EiwwjFivbcgriHsBbGqtJVrPmg09I08=; b=aEqrpCuYeh4R/sp504lOSJ83+lFDPF0J5cvxbG3+aeSRd/GsPi3X6MR+zZvyidEwEMtl78 Evz/zOcv5lSrVX0brrftyOxPudMjqyB9KLosUuIksaWv8M60/hfjtCj+TYF14f5L2JQ+w1 jbGcuYMJsyOH8kWmBYExy2S4w8pALB8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=prXmdpiW; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=HNpRgF5j; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf01.hostedemail.com: domain of "prvs=21358209d=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=21358209d=damien.lemoal@opensource.wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660057076; a=rsa-sha256; cv=none; b=OKAhzfbcXdY7oLQaQ6JGCYLIQ1JBPalE0YdYHsoSi8WMo2EVjfJl13y/UbUVjQbDgp+DQw bi6H5LzFPL4A5ga45/L3EOsEvGtS9jQjXcBZrDbZ9H6ts4+lkWl16H9IUfsXbf4+VPgnq0 X3E1P7+9dCiMIJFzgbPW3iUTZRuczAw= X-Rspamd-Queue-Id: D197840181 X-Rspamd-Server: rspam03 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=prXmdpiW; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=HNpRgF5j; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf01.hostedemail.com: domain of "prvs=21358209d=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=21358209d=damien.lemoal@opensource.wdc.com" X-Stat-Signature: niro7tdmj6ftnyb8dgrg1j19z77uyjeu X-HE-Tag: 1660057075-285219 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/08/09 7:16, John Garry wrote: > On 09/08/2022 10:58, John Garry wrote: >>>> >>>> commit: 0568e6122574dcc1aded2979cd0245038efe22b6 ("ata: libata-scsi:= =20 >>>> cap ata_device->max_sectors according to shost->max_sectors") >>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git mas= ter >>>> >>>> in testcase: stress-ng >>>> on test machine: 96 threads 2 sockets Ice Lake with 256G memory >>>> with following parameters: >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0nr_threads: 10% >>>> =C2=A0=C2=A0=C2=A0=C2=A0disk: 1HDD >>>> =C2=A0=C2=A0=C2=A0=C2=A0testtime: 60s >>>> =C2=A0=C2=A0=C2=A0=C2=A0fs: f2fs >>>> =C2=A0=C2=A0=C2=A0=C2=A0class: filesystem >>>> =C2=A0=C2=A0=C2=A0=C2=A0test: copy-file >>>> =C2=A0=C2=A0=C2=A0=C2=A0cpufreq_governor: performance >>>> =C2=A0=C2=A0=C2=A0=C2=A0ucode: 0xb000280 >>> >>> Without knowing what the device adapter is, hard to say where the=20 >>> problem is. I >>> suspect that with the patch applied, we may be ending up with a small= =20 >>> default >>> max_sectors value, causing overhead due to more commands than necessa= ry. >>> >>> Will check what I see with my test rig. >> >> As far as I can see, this patch should not make a difference unless th= e=20 >> ATA shost driver is setting the max_sectors value unnecessarily low. >=20 > For __ATA_BASE_SHT, we don't set max_sectors. As such, we default=20 > shost->max_sectors =3D SCSI_DEFAULT_MAX_SECTORS (=3D1024) in=20 > scsi_host_alloc(). I assume no shost dma mapping limit applied. >=20 > Then - for example - we could select dev->max_sectors =3D=20 > ATA_MAX_SECTORS_LBA48 (=3D65535) in ata_dev_configure(). >=20 > So with commit 0568e6122574 we would have final max sectors =3D 1024, a= s=20 > opposed to 65535 previously. I guess that the problem is something like= =20 > this. >=20 > If so, it seems that we would need to apply the shost dma mapping limit= =20 > separately in ata_scsi_dev_config() and not use shost->max_sectors. OK. Will have a look at that. >=20 > thanks, > John >=20 --=20 Damien Le Moal Western Digital Research