From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1519C4332F for ; Thu, 2 Nov 2023 20:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DB498D00A6; Thu, 2 Nov 2023 16:28:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3654B8D000F; Thu, 2 Nov 2023 16:28:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1910C8D00A6; Thu, 2 Nov 2023 16:28:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0428C8D000F for ; Thu, 2 Nov 2023 16:28:36 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D066F402DE for ; Thu, 2 Nov 2023 20:28:35 +0000 (UTC) X-FDA: 81414152190.22.044BE5A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 96FFB120004 for ; Thu, 2 Nov 2023 20:28:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Njwnwoq1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698956913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=56DyDqdEXuR0JDckJHzCKtyxShUi13+QbfqQakjzXUM=; b=61ni+4EphyRI4F+128kFtAW/4SPy1aNF1agiLMaw3+5eRe5w0a+fMy9Sv3tyMlwrXwg0xG YBNgAHX9b8a8k5TyUTDBSOCmJcxnSiZYhpxYYDpUdm5zIlAv1VPD3b24i+zMxk2Ud8sHUJ 5YOXizS5p0/zFVtI0JYETar+wcnhl+E= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Njwnwoq1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698956913; a=rsa-sha256; cv=none; b=gFc7XUR0eJGCZ8npzwvKYfZjtNXfzUPthU0GmKzxOGK42Iq9fg34TassnhgOcvyL5CYlyf 4v2tPW8XhMERL5hfGp8x8Twq57qR1j5vNBMthFgvXj3V/uvniXnZTf+8VuWvQBhWIokiif 5Olu0j/pqDhvEwFRFx3HiBzasSI5t0g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698956912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=56DyDqdEXuR0JDckJHzCKtyxShUi13+QbfqQakjzXUM=; b=Njwnwoq1Nq2Sg1W+p7QTKqXzNvgfdjGIQj/gJfGsk74/GXlnLIpE6Cu0eCOACNWSZ5iFaf lAkR24FVmpvcr0AEkxcp6s/E4CI7UroYu/uxys/Sw4SKcPZ9GwGByT3WOdSggEYOM3S29T HVi+aV0H0XmwWGjFn/JT3t23uzV1YMU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-1Wmt1IOsNqyElF1gvLBJvw-1; Thu, 02 Nov 2023 16:28:31 -0400 X-MC-Unique: 1Wmt1IOsNqyElF1gvLBJvw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c50d73e212so16618691fa.1 for ; Thu, 02 Nov 2023 13:28:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698956910; x=1699561710; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=56DyDqdEXuR0JDckJHzCKtyxShUi13+QbfqQakjzXUM=; b=HGWen7F9QKPEvmRPKzCd8zOhPFPAiotwodUp/jqppR5Y8fhX/ul1TUn1bLqfM+UBno sI2QTvqYQnG/9MEyzKtzXOpKCMzLb/kGN5AzjJORUREOCGBrHnfdlO6JzeJcIeHxW0S3 seEdXQch+BbfIIurmpj6ohhgkuDfbLVPs53FxTu0VHoDSVR31ARl/SgthfOZHJo9+/+i JJoA2nRlxlaHPHioXu9La/2zhiwcW5CJfPnLlEyPrA9kI/UA6CCgipY4j9pA0Cs5dUqO ireZIVZdWHaMKMLV5QX4p98SzN05O4vvSay/MJrVh9fJHn/VERXDTU5M2ZW/qA8Engq5 Acow== X-Gm-Message-State: AOJu0YyFjujGMYlKUlH9oBiaAOXxY7J3DzDSxcyzKPoOn5LlEvX4KEeP 0wv+sx4WQD3SndIsWqbD/KGEQn8qlxRIKG0oi2HO+73FfZBTvcQNlLGGyi0rUyHcAOMnC3R5ke9 u7llZqAfxBZk= X-Received: by 2002:a2e:a793:0:b0:2c5:8b1:7561 with SMTP id c19-20020a2ea793000000b002c508b17561mr19286393ljf.10.1698956910031; Thu, 02 Nov 2023 13:28:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnqs0Mxvj+h7m3Wt9gDD87PWJYPL1gESigSucuPc3UJt3PUXMZMHB642WeXW8CU1/OcsmiJQ== X-Received: by 2002:a2e:a793:0:b0:2c5:8b1:7561 with SMTP id c19-20020a2ea793000000b002c508b17561mr19286354ljf.10.1698956909628; Thu, 02 Nov 2023 13:28:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c716:3000:f155:cef2:ff4d:c7? (p200300cbc7163000f155cef2ff4d00c7.dip0.t-ipconnect.de. [2003:cb:c716:3000:f155:cef2:ff4d:c7]) by smtp.gmail.com with ESMTPSA id j11-20020a5d618b000000b0032db4825495sm228854wru.22.2023.11.02.13.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 13:28:29 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 21:28:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] mm: report per-page metadata information To: Pasha Tatashin Cc: Wei Xu , Sourav Panda , corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, Greg Thelen References: <20231101230816.1459373-1-souravpanda@google.com> <20231101230816.1459373-2-souravpanda@google.com> <1e99ff39-b1cf-48b8-8b6d-ba5391e00db5@redhat.com> <025ef794-91a9-4f0c-9eb6-b0a4856fa10a@redhat.com> <99113dee-6d4d-4494-9eda-62b1faafdbae@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 96FFB120004 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: e6ohygpr78zhmj6dhrktitff83tke3y9 X-HE-Tag: 1698956913-205333 X-HE-Meta: U2FsdGVkX1+MA8wfewcZvExaUSwKSm5Vo0NQcPz65ncKa+/X6cpx3D8Xx6V5IphM8c0KBiEcYxVfPV8yIqcmVE4jJAZpB6s4o/PW17WHNscOTGx3pbxE18d1bLLOE5OkFQi2t+wIdwIrSC4Np8O6LuDviZKSieN2uRTbfjrnudCFKQ+0X8S7Ox/M7X7zWE2be7L1QV2tgza3Mq8whapYXelySE3X7NIfqeCnMoosVzjTJ3fBH+S944EJnslWPCWoj2ZPtVikoGBJacLbuUJjbuj2C0FO0CZaed9FiyJF9vdeDRZ6YAP6z7wMkaruuQPzvhfy82xU8ESFLl7K8nbw3cNIpa+EypH77QQenyNALeadky3cXfQbbdc2SKi4RmbbaWqjFtwK4CFp0XW6gmWja42iP4AWwvOCLLZcm5aCXkWRBp7zPwNdfVytcgpC0ni87vsOSlrZAcC+lxPwv9THHo0a2jxtTw0pQEVtfZSrnMPOUXkLQFcmnc4tOnXdrfnSs1oqvJ4hF0Fh7tREgOD2m2vMrMXK0EvLFA55JCtgL6Ogmxz4jw8nQoOaJowIR3s/EO+3aYpimZ+tC1BF2CGusMkmxErzP56JKFsOkNQR/KHLvj1Z0UHv3Yk1QSWeSqLvCqTiAq3B8SlpIzbS/f7x8Dd17M3nga6wcm+IEnjK8m43dHTsPoapq6xZllHmJwxRb0eQyCE/vH/fPC9Z/P9nJGw9BSCEbyNitzJdI4feBqJT1ZQERj6UduCsko8/wjLm7iWMCYQdZhRN20r7jYGYeF5pQYNC++MU2KrmBykKuqICiRZTQv/gDOxwVuc3H/QWCQZAvGi4fIZmi6dzdCvYfRjLecLGovSI+eAD9voGSL3UIRXKFVptOOyasWxTEhDFRlSdTDYt7xyb7/lrQk+RkYqA8CxZ4sHTXgPfyNp8X5LlrunkbBCLdbwEzxCw6XCXf6XaSYNKztQvQIpUuBj m9Bh5UAf rlJGHehcy0smL5W7UMbAhMOAX39o0LJkG5ik6+0bBQhAuMtPfT61qx5lX0EmpQv+8/3vRyfqTgIQmnHAdqAOKngh/F1sqYM4wnugI5YSsbAauUVqthNABofKNQsUlKFVxNa6JxIbVT68I1ICpuZZF8SJ2xFpDS8G1Btuj1nZ9mN56UXTP0FZy1NZV9OFhKjAyPA6SyhOee6MWs1o1wazTqt5m75nmA5Fd9Q6YUTX/xp+gZoyaZN/Fj3Sd9tfMAoV6egfIz/flTpIz382wPys5/MsKMlD03TlWrzklVTbw2j0+IUPHfg7ZlijtWpHbTV1XRH2Uud4SXrhyvcXLbwxc6wL8KYXvx8PSjTqwbn7dwJVUNIdm+aOrYb/drKIiCY8DqrbkAadOTl+GJGLg1VoV+NVJ6+oErMQaxHvMWtLYLwyy18SCSGMS0dK+Id0RlrP4maoZsAVNQLMIJjjPzdzF3YeZ6Acb0lDaOCjuvMIULYFzYPAe2yeP2AkOkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.11.23 18:11, Pasha Tatashin wrote: >>> Wei, noticed that all other fields in /proc/meminfo are part of >>> MemTotal, but this new field may be not (depending where struct pages >> >> I could have sworn that I pointed that out in a previous version and >> requested to document that special case in the patch description. :) > > Sounds, good we will document that parts of per-page may not be part > of MemTotal. > >>> are allocated), so what would be the best way to export page metadata >>> without redefining MemTotal? Keep the new field in /proc/meminfo but >>> be ok that it is not part of MemTotal or do two counters? If we do two >>> counters, we will still need to keep one that is a buddy allocator in >>> /proc/meminfo and the other one somewhere outside? >> >> IMHO, we should just leave MemTotal alone ("memory managed by the buddy >> that could actually mostly get freed up and reused -- although that's >> not completely true") and have a new counter that includes any system >> memory (MemSystem? but as we learned, as separate files), including most >> memblock allocations/reservations as well (metadata, early pagetables, >> initrd, kernel, ...). >> >> The you would actually know how much memory the system is using >> (exclusing things like crashmem, mem=, ...). >> >> That part is tricky, though -- I recall there are memblock reservations >> that are similar to the crashkernel -- which is why the current state is >> to account memory when it's handed to the buddy under MemTotal -- which >> is straight forward and simply. > > It may be simplified if we define MemSystem as all the usable memory > provided by firmware to Linux kernel. > For BIOS it would be the "usable" ranges in the original e820 memory > list before it's been modified by the kernel based on the parameters. There are some cases to consider, like "mem=", crashkernel, and some more odd things (I believe there are some on ppc at least for hw tracing buffers). All information should be in the memblock allocator, maybe we just have to find some ways to better enlighten it what an allocation is (e.g., memmap), and what some other reason to exclude memory is (crash kernel, mem=, ACPI tables, odd memory holes, ...). -- Cheers, David / dhildenb