From: David Hildenbrand <david@redhat.com>
To: Alex Sierra <alex.sierra@amd.com>, jgg@nvidia.com
Cc: Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
willy@infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages
Date: Wed, 29 Jun 2022 09:33:28 +0200 [thread overview]
Message-ID: <f00f9c93-c115-d222-dc8c-11493ccd2567@redhat.com> (raw)
In-Reply-To: <20220629035426.20013-2-alex.sierra@amd.com>
On 29.06.22 05:54, Alex Sierra wrote:
> is_pinnable_page() and folio_is_pinnable() were renamed to
> is_longterm_pinnable_page() and folio_is_longterm_pinnable()
> respectively. These functions are used in the FOLL_LONGTERM flag
> context.
Subject talks about "*_pages"
Can you elaborate why the move from mm.h to memremap.h is justified?
I'd have called it "is_longterm_pinnable_page", but I am not a native
speaker, so no strong opinion :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-06-29 7:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 3:54 [PATCH v7 00/14] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra
2022-06-29 3:54 ` [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages Alex Sierra
2022-06-29 7:33 ` David Hildenbrand [this message]
2022-06-29 22:08 ` Felix Kuehling
2022-06-29 22:15 ` David Hildenbrand
2022-07-02 4:25 ` Andrew Morton
2022-06-29 23:24 ` Andrew Morton
2022-06-29 3:54 ` [PATCH v7 02/14] mm: add zone device coherent type memory support Alex Sierra
2022-06-29 18:48 ` David Hildenbrand
2022-06-29 3:54 ` [PATCH v7 03/14] mm: handling Non-LRU pages returned by vm_normal_pages Alex Sierra
2022-06-29 9:59 ` David Hildenbrand
2022-06-29 23:31 ` Andrew Morton
2022-06-29 3:54 ` [PATCH v7 04/14] mm: add device coherent vma selection for memory migration Alex Sierra
2022-06-30 10:04 ` David Hildenbrand
2022-06-30 11:44 ` Alistair Popple
2022-06-30 20:56 ` David Hildenbrand
2022-06-29 3:54 ` [PATCH v7 05/14] mm: remove the vma check in migrate_vma_setup() Alex Sierra
2022-06-29 3:54 ` [PATCH v7 06/14] mm/gup: migrate device coherent pages when pinning instead of failing Alex Sierra
2022-06-29 3:54 ` [PATCH v7 07/14] drm/amdkfd: add SPM support for SVM Alex Sierra
2022-06-29 3:54 ` [PATCH v7 08/14] lib: test_hmm add ioctl to get zone device type Alex Sierra
2022-06-29 3:54 ` [PATCH v7 09/14] lib: test_hmm add module param for " Alex Sierra
2022-06-29 3:54 ` [PATCH v7 10/14] lib: add support for device coherent type in test_hmm Alex Sierra
2022-06-29 3:54 ` [PATCH v7 11/14] tools: update hmm-test to support device coherent type Alex Sierra
2022-06-29 3:54 ` [PATCH v7 12/14] tools: update test_hmm script to support SP config Alex Sierra
2022-06-29 3:54 ` [PATCH v7 13/14] tools: add hmm gup tests for device coherent type Alex Sierra
2022-06-29 3:54 ` [PATCH v7 14/14] tools: add selftests to hmm for COW in device memory Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f00f9c93-c115-d222-dc8c-11493ccd2567@redhat.com \
--to=david@redhat.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).