From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE44C433EF for ; Wed, 29 Jun 2022 07:33:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BCB38E0007; Wed, 29 Jun 2022 03:33:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 745048E0002; Wed, 29 Jun 2022 03:33:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E72D8E0007; Wed, 29 Jun 2022 03:33:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4B95A8E0002 for ; Wed, 29 Jun 2022 03:33:35 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 2303A1211F8 for ; Wed, 29 Jun 2022 07:33:35 +0000 (UTC) X-FDA: 79630458390.23.AE2B45C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id C3D5E400A2 for ; Wed, 29 Jun 2022 07:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656488013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dA2eoSPtGttWxJYZGlfOcE/QeU9denwWrEKtVHSFEyo=; b=RjZzRQXEzUevNSu6VfUPeENuCjiAflugBKE+0cfUCRlXIpBVdVIGS4YDmWkDHcNEnodF8+ rIjdx3nEI740BDTAgJMA/+0Eq9MxsSwPgJmoxJV2IGg/6onWSsP2XnQQTSrJCucHYUEV26 2byZZM5eTTqV2w9n0D+DuZ29VIHMCY8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-396-Ns6PHda_PIygZR15urak5w-1; Wed, 29 Jun 2022 03:33:31 -0400 X-MC-Unique: Ns6PHda_PIygZR15urak5w-1 Received: by mail-wr1-f69.google.com with SMTP id z11-20020adfc00b000000b0021a3ab8ec82so2150047wre.23 for ; Wed, 29 Jun 2022 00:33:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=dA2eoSPtGttWxJYZGlfOcE/QeU9denwWrEKtVHSFEyo=; b=Ma7v0PznDHeYgPk1M+YvJncDAscCGXstzIMzB816iHXHRLZ+oWteeGNndwNflHF3pY kVEGYClWBS6b5oyglOum/BpT2i7agOmbNXXghwcM3JdjPseYvfcQdHHRfTf40FeFgOXH ZqC1tZcqljmc85OdpVPQCEVUn62IJmcDUQoMYQ0zgZthuRB3wHSJzA6bPe8nyNbxe3QA JegMjoevK95ovm0ZCE+j/bBzuVZTxTlu6cBFtpyzymE0oGj3q+oznvnGSQRiIZr6D6VC +06kK4jTDBuZ5tVR5YwUSeow1U7ID40y0rrg8cG5JTuRy8uuMeTf7jh9yuIV4SKAH+YH pWIQ== X-Gm-Message-State: AJIora8m8hyA+f+H3xI0Kda2hcXS4BhOA7KmDjMPRooUE1oKh7ZP5oo5 Kj+uVJHKEQr09XvV/SMl70JCQ6FnclbdVapfe+vw776DxNq4MySb8olpJs7hrj/kct1r8AHEuAr M0JvSD76bkwo= X-Received: by 2002:a05:600c:3591:b0:3a0:563a:49d3 with SMTP id p17-20020a05600c359100b003a0563a49d3mr1926451wmq.60.1656488010103; Wed, 29 Jun 2022 00:33:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uum8Hx2eoXPmPEzIAfJI+bxpHTzM8+zWRZ0znb96530kqbhcZ9rF+BBXjqVzGxgQ61VtlDlw== X-Received: by 2002:a05:600c:3591:b0:3a0:563a:49d3 with SMTP id p17-20020a05600c359100b003a0563a49d3mr1926431wmq.60.1656488009851; Wed, 29 Jun 2022 00:33:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:e600:d4fa:af4b:d7b6:20df? (p200300cbc708e600d4faaf4bd7b620df.dip0.t-ipconnect.de. [2003:cb:c708:e600:d4fa:af4b:d7b6:20df]) by smtp.gmail.com with ESMTPSA id g21-20020a7bc4d5000000b0039c587342d8sm2175038wmk.3.2022.06.29.00.33.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 00:33:29 -0700 (PDT) Message-ID: Date: Wed, 29 Jun 2022 09:33:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages To: Alex Sierra , jgg@nvidia.com Cc: Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org, akpm@linux-foundation.org References: <20220629035426.20013-1-alex.sierra@amd.com> <20220629035426.20013-2-alex.sierra@amd.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220629035426.20013-2-alex.sierra@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RjZzRQXE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656488014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dA2eoSPtGttWxJYZGlfOcE/QeU9denwWrEKtVHSFEyo=; b=nBDiJHgKc/xv5vm27ZDu7YbFGVDnhnyI9Tzyuu84GgtoIdj+D5hqFKIzB63/EXrwKQ8bKn mQ8ZH7vjHzqMdNiqxh9HUmNvnxms8eQsS1kK1yORyVS0awH93ERBapoUsrjWd2G86hgjZy t+8TOtiH0/JZARGXq4ry2TuiilbpfpY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656488014; a=rsa-sha256; cv=none; b=2drSzHvMagelT7a5SOQXO6asVaoNkNdE9acA9UUkzPp/Drlnjpx85NxxyhOVpI5zhil20t apXt0IZKCfvY2Uevk1kVh2A7xNXhRTV9Jak6oOACd8cWe4omRTrpLLiFg5nJVlxBBxMXlK s54wXnaXoNcLZ60iNFS79Jij89k+bqo= X-Stat-Signature: w5t8fh4sk6eztdywkwmqspjsqiq9ag5y X-Rspamd-Queue-Id: C3D5E400A2 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RjZzRQXE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1656488013-831701 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.06.22 05:54, Alex Sierra wrote: > is_pinnable_page() and folio_is_pinnable() were renamed to > is_longterm_pinnable_page() and folio_is_longterm_pinnable() > respectively. These functions are used in the FOLL_LONGTERM flag > context. Subject talks about "*_pages" Can you elaborate why the move from mm.h to memremap.h is justified? I'd have called it "is_longterm_pinnable_page", but I am not a native speaker, so no strong opinion :) -- Thanks, David / dhildenb