From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D7EFC433EF for ; Fri, 29 Apr 2022 10:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1D676B0074; Fri, 29 Apr 2022 06:09:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA5506B0073; Fri, 29 Apr 2022 06:09:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1FF76B0074; Fri, 29 Apr 2022 06:09:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id C3C886B0071 for ; Fri, 29 Apr 2022 06:09:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9858021A08 for ; Fri, 29 Apr 2022 10:09:02 +0000 (UTC) X-FDA: 79409493324.01.2FA32D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 04044A006C for ; Fri, 29 Apr 2022 10:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651226941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PcaISLSLdyWZemeMh79f2GIjMvsQzaqiIyNmuSTywU4=; b=RAl/mCGr55rnSh2yMfAR6xn9lIbHh8138xjPMaE5w0HJhBb8fUx8kRaSvndBCpQSZ1o96a y+56t3jbVOIiQr8vqg6d22dzRNHoKnodPzV/t7ZeB/kBAnMmHmCfjzLfqEOjoUjIdnPq1K pvTRKC08TQjmyW7bHvhbQhXQWx0Q95M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-15-425ZLGlHMdmPMJgpzUq0Vw-1; Fri, 29 Apr 2022 06:09:00 -0400 X-MC-Unique: 425ZLGlHMdmPMJgpzUq0Vw-1 Received: by mail-wm1-f69.google.com with SMTP id j5-20020a05600c1c0500b0039419a269a1so1046310wms.3 for ; Fri, 29 Apr 2022 03:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=PcaISLSLdyWZemeMh79f2GIjMvsQzaqiIyNmuSTywU4=; b=wRrWR8Dl+M+OE+Dm+vIKFDqgJJ2+5tl00jbRHqqOvwIgmIYjCmpy9V+kVAaXTHS/gQ /0YiP6DCWqQTw7ttUquRg1WtVkL4zhbEuKq1CJ9usUFwGKq3XqrLIPdoJxa0L4FOWSHg 6RLyKqfbjt69vVxeo0qiCQjw3BUef55M9TBV62gl4ZID8C2v5v3N3MnJFxMME1tjMgjz pKBm293bGWWcbgmvYaG2AcQLhA+Q4rVEQVuQ5/WsOHolCRC/smDuvfMcLu7cvp1Z32/S GTOjrlluKK88r8rNHDCvHYv9sID3RT/FVpvZR7Y2YrstoUgiM3yElq2ZD31xzllTNsPl Ivmg== X-Gm-Message-State: AOAM531W+5KPD4UOvvZIi6wUCFe/2mZZoYAWlUA/fBfsOglvZKKXj3L1 CHs3x+DMZdBwPVtXgFwkMGN7rdaIgye4hx4cOhq5MjQCP236zdIgHNPSvG9GREDk6gow0XQtcF4 vhRdkla6Ji1c= X-Received: by 2002:a7b:c106:0:b0:394:19aa:4f91 with SMTP id w6-20020a7bc106000000b0039419aa4f91mr2509835wmi.68.1651226938836; Fri, 29 Apr 2022 03:08:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdv5UT/aWPCC6mSRfc6RXnUHLUBDkQjXkGiwk5zB8FkDtFXoaysLHQZZrnFGmo42uAb40yGw== X-Received: by 2002:a7b:c106:0:b0:394:19aa:4f91 with SMTP id w6-20020a7bc106000000b0039419aa4f91mr2509816wmi.68.1651226938601; Fri, 29 Apr 2022 03:08:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:fe00:bbeb:98e6:617a:dea1? (p200300cbc707fe00bbeb98e6617adea1.dip0.t-ipconnect.de. [2003:cb:c707:fe00:bbeb:98e6:617a:dea1]) by smtp.gmail.com with ESMTPSA id o30-20020adf8b9e000000b0020ae802da1fsm2318717wra.90.2022.04.29.03.08.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 03:08:58 -0700 (PDT) Message-ID: Date: Fri, 29 Apr 2022 12:08:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 3/4] mm/migration: return errno when isolate_huge_page failed To: Miaohe Lin , akpm@linux-foundation.org, mike.kravetz@oracle.com, naoya.horiguchi@nec.com Cc: ying.huang@intel.com, hch@lst.de, dhowells@redhat.com, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220425132723.34824-1-linmiaohe@huawei.com> <20220425132723.34824-4-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220425132723.34824-4-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 04044A006C X-Stat-Signature: 5uhc5hbwoix6pgoizstx9nriwrgo55gr X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="RAl/mCGr"; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1651226935-263838 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.04.22 15:27, Miaohe Lin wrote: > We might fail to isolate huge page due to e.g. the page is under migration > which cleared HPageMigratable. So we should return -EBUSY in this case > rather than always return 1 which could confuse the user. Also we make > the prototype of isolate_huge_page consistent with isolate_lru_page to > improve the readability. > > Fixes: e8db67eb0ded ("mm: migrate: move_pages() supports thp migration") If this is a fix, what's the runtime effect of it? You state "could confuse", which doesn't indicate an actual BUG to me. -- Thanks, David / dhildenb