From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5429FC38150 for ; Wed, 10 Jul 2024 06:13:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C20BE6B0085; Wed, 10 Jul 2024 02:13:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA9A16B0088; Wed, 10 Jul 2024 02:13:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A49D16B008A; Wed, 10 Jul 2024 02:13:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 860856B0085 for ; Wed, 10 Jul 2024 02:13:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 409C11C3A8B for ; Wed, 10 Jul 2024 06:13:17 +0000 (UTC) X-FDA: 82322825634.17.51F597C Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf04.hostedemail.com (Postfix) with ESMTP id 4A51940005 for ; Wed, 10 Jul 2024 06:13:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZhHubHhD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720591969; a=rsa-sha256; cv=none; b=C/c4Z2qyDHAoWDTUq+CFtkGdNEIoaraA6P4jpub1q6ptKTW5c+k3FqCqA6m6B8Pyz6cMsu X9nLALE2H1idXltNKsBDdxc++LVaF5mRcU6B2TqZAO1CqRTynXzTCBnwSfNvoKz3v87cXg kbCpi289Q8mL4ZoVc55E+XsmMBwnOic= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZhHubHhD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720591969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fliPFUQMMU4ESDuf3cphReytLRzzabwtKhkiu8ItoPc=; b=Eh4FFLhE88+c03NDyKjZ9SzH+jqr+1AK/YpcfqJs+5E8OxS8cvEyW/pk8BuzNyj+bYb3Sc VGpAIwIU7FJuXGJZbcQ57vjc0Odi2Pbmhch80nVQSqmgkS3QccA5SLKVQ9aL0Fi4McdqbF GjNPsE2epnrnkUMl6u6tzV5zkQBCTFQ= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1fa9ecfb321so36349615ad.0 for ; Tue, 09 Jul 2024 23:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720591994; x=1721196794; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fliPFUQMMU4ESDuf3cphReytLRzzabwtKhkiu8ItoPc=; b=ZhHubHhDehEeiG4Fh6qsq8fWPDq+JdAsXkT+4SpgJZJd7MvU3Esc/WOOfXRWh8uetB COhHB8078IJuGODNX3O+jKzZbt3vcbjM8SgpXVkbHMViGL+f06jkqvM4YjhKFXs+zHJZ VIz90P5Z2jWiCGzTx6c1soKWPmeDk+FSpH4qH6OucUUq8aw3O3xHpOKZ8QtVtPBIL/zq Fau8DLSnt+WTDZOGr9NuL+5eGHLV7HBDTeOBAC4ENqZpFVIeNUthaRTuzUWSS99/+3fy u1Y6gz5AdPHANx1rpC7oj8L5HwnQabszFQpj1t0WQIcCkzU3WN8kGZORUvnmyW6QRwcm LQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720591994; x=1721196794; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fliPFUQMMU4ESDuf3cphReytLRzzabwtKhkiu8ItoPc=; b=UBp4uzUX/qUAMCcLG++/AfUrAYPeTw3lJhOCAOuNNFcsIDsfgI55vnUH49MA6DhLXU de4ssPdC9yfqOd+DUfCVlC5hc6nH4+7kd13MkJk2rLZEuuvd37GBDSw1kko2DsAdw0Gx digOoIFXTP5FVL/y2hSQ2GZGE/ZXJ0fKHzYfbqNhCiA9/CsuuvNY40bd83jNDNmN69NJ JfIa2nwLAycG9CDGHayVNDfO4uxJrfjwDRdfd/4iiQrvI7IgFLXt4yJ5/Yso0fl6dwFx qSEWs8N3DWqfA+tNkS+NRj+pPjiUDMB7ACuo79HYscRLZ6RVHdJPLyazpnpNuhs62BhV ER5A== X-Forwarded-Encrypted: i=1; AJvYcCWcYV6YxOMGX3MLiegxT8GE5h8ka+pZsxiObOQ7dg9K1EQG+aVsnRngZfcg08I8z8zi66imvD/QgBiFc54czBtadKg= X-Gm-Message-State: AOJu0YyC+dkH24GlZRCI6vKvxycqzVJx8KhDcZoC12B3PDyKFeG2iwOd DY1QVdXC6WjXAPJdDYQL5GZZ9mitwEzYFMOXIPx8WiZeb4BHT15h X-Google-Smtp-Source: AGHT+IF5ZY20tyWZvgef75ebwxVj/BmkeBDWG0TgcW31wLtjJTjLgexT/SR6pPhC/4cR5UurXotAJg== X-Received: by 2002:a17:902:da90:b0:1f4:977e:bf with SMTP id d9443c01a7336-1fbb6d3d348mr45905515ad.19.1720591993951; Tue, 09 Jul 2024 23:13:13 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6ab7980sm25804405ad.177.2024.07.09.23.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jul 2024 23:13:13 -0700 (PDT) Message-ID: Date: Wed, 10 Jul 2024 14:13:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REF PATCH v3 2/2] mm/slab: decouple the SLAB_OBJ_EXT from MEMCG To: alexs@kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Randy Dunlap , Yoann Congal , Masahiro Yamada , Petr Mladek , Suren Baghdasaryan References: <20240710054336.190410-1-alexs@kernel.org> <20240710054336.190410-2-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: <20240710054336.190410-2-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4A51940005 X-Stat-Signature: 617b4otkhrrfiim1knsrsq83qga4jqfc X-Rspam-User: X-HE-Tag: 1720591995-906687 X-HE-Meta: U2FsdGVkX1/DcLkYpaPt+YIOwFKrqUyg45zAxWs3CRcGCdpJKKR1z1TqdAu+hO5Tq0F1TEBYbrNDP86RcJp6VSRSPqf+hmBLpH1ZI0NH+U1z7EHQEGDJQWP7JB1PbzG3FWsqekd98d/8p2RLTCST1Fs2EBLZF+1jC/5NAXRnBV47kmuN2ZbENtgeeS4xu20lMCCK+GuYYYXQW+9TwWTfR/ZJnKulQqeiZpR3DIJsWyJaxzSyHCsBB50oxKiGMGHNNKlfmGHN6pSRqLN+FuDKWCNgQxZguvh5ckC9qKvVC0L52fIVWOPrC1fsH1ga3hQGgpCvWCur2vK6ZXsncx0aqhkd+SE0fNrYEzQYimRIX+CILecjmdsQzLfYZdUJQ1l9aqwXnCjneQtB4WMZ3In+h1qppkIVQpTTAS/jJsWjoYnl5HC2GclxaJ9g+oyIA6i3zNtIU5Y7vfizw8hWPkOfVhlBcahvSdTTVLUXsH8Ss2B4sypbR+zR+/nIA8Hh4s3pvdNUT2M8zfcwELodTueLbvon9d4E9cObYrWm6s5a9gY/xH989Rlp+P5sd5NGtN/QmJFuidRnX5A2qZvbEUy06iYMPwaXO/jKIBo8Kh5C8n0p4j0wxtdhKkU7zfuMJOzg39K3uChZPBAWKtwf0xenno9wuIQ4+Ay7UrmLBkdLIPS5ptuBELGGeK40lQjm2fp6HDb8YQ/9aMTh7of8fXEL4oOTaZ672L+/8cL614nuUSVpW9Ob07WEYoc/xaAUsc+h6gZaDzkbAUn4g9SS14qaS3zvTuE3BAf6B2UXgCIZWPH/pmKyDzZvhqC4sXN8kSwBQSVlhWXAjhVLH2DHeXo87U2juKLtrcKgWu7C1v7kieFLq3gCLzvROzOv8vfmibB5Aaf08SnU5oyVwcfDx+wrWqUjindu2vax2VgI9r0KK4sJERi4RqHRKaZ7FbOX/26PXj7P0XemJ20iuy5zKto YCT9Kheg E7GMWOpRejv5YRJ7stTLlv3tlp2+N/eqZPL6SQ6D+BxleLw3jcbDnz2nX3NyNXoGt0nRJHbLvv9erjrHRxpkeM7fpzkFyPJWBBT6LGvLqhcdI+TjVYg+yyaUxUBqk8hyY0LYC2KQWmAILmmoYO0Bo5UR3gByK0uN43aCqctdo/4lPsGOCyrS8DbHHB06rltFS39C/11H4IvfLjm1StXlc4RhrnMjindig20RRJb2bJ11FLA6d6hmzHCwTfy2S/q0QHUDc0+TZKVjjpHx29jIb/zMF0yEpQ7UoOHQ1ivW95nQTlgIv2bhA+dTiZVmPcN7fUOIj25XmUkzge6qIPi+Tt/ZeSiWg0+cY4KGRaCmmH4ilUwfLiV6RqgTVMmM67oSZK9mJsZL/BELKvnAi06MPul0NZondz2wJlq6xLTp4SUSUt/E7zowegxnYcm75p9QRTDr4LfuIdr8QrLT48iDci8ocW5zS6Teho4pzS4Q0VZmFY+qTpf7+w7YJzHkb+HyH6wvvfUaSS4wl+rq8UCG7wK3g5c2rCPJPHvKzQFo1mIYGCOWxucEju/WAoMEvtVHZtLIZbUNQTUHOhVdAMX4SMA0TbNxhsv9rZEZAKgyuLAu+Fj6Rf9n7jMkpKZFJUMd9wDrudRncZQ37x+g7JXrRZXLIyjbjnyOnAqGMPtL+qvWJB2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/24 1:43 PM, alexs@kernel.org wrote: > From: "Alex Shi (Tencent)" > > commit 21c690a349ba ("mm: introduce slabobj_ext to support slab object > extensions") selected SLAB_OBJ_EXT on MEMCG just for SLAB_MATCH > memcg_data, that included SLAB_OBJ_EXT for MEMCG. In fact, I didn't see > the necessary to enable SLAB_OBJ_EXT for SLAB_OBJ_EXT. > > Let's decouple the SLAB_OBJ_EXT from MEMCG and move out > alloc_slab_obj_exts() definition from SLAB_OBJ_EXT only. To alignment > the alloc_slab_obj_exts() return 0 for good. change its return value to > '-1' for always failed with !SLAB_OBJ_EXT. Now we could save unnecessary > code from MEMCG but !SLAB_OBJ_EXT. remove SLAB_OBJ_EXT from MEMCG, it introduce a new path in __memcg_slab_post_alloc_hook() for (i = 0; i < size; i++) { slab = virt_to_slab(p[i]); if (!slab_obj_exts(slab) && >>> alloc_slab_obj_exts(slab, s, flags, false)) { obj_cgroup_uncharge(objcg, obj_full_size(s)); continue; } Here alloc_slab_obj_exts() return 0 for good, that lead to "slab_obj_exts(slab)[off].objcg = objcg;" failed on !SLAB_OBJ_EXT. so change the return value could fix this. and its the only new path for this function. Another usage of alloc_slab_obj_exts() in prepare_slab_obj_exts_hook() doesn't exist on !SLAB_OBJ_EXT. Thanks Alex > > Signed-off-by: Alex Shi (Tencent) > Cc: Randy Dunlap > Cc: Yoann Congal > Cc: Masahiro Yamada > Cc: Petr Mladek > --- > init/Kconfig | 1 - > mm/slab.h | 6 +++--- > mm/slub.c | 6 +++--- > 3 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 26bf8bb0a7ce..61e43ac9fe75 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -965,7 +965,6 @@ config MEMCG > bool "Memory controller" > select PAGE_COUNTER > select EVENTFD > - select SLAB_OBJ_EXT > help > Provides control over the memory footprint of tasks in a cgroup. > > diff --git a/mm/slab.h b/mm/slab.h > index 8ffdd4f315f8..6c727ecc1068 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -559,9 +559,6 @@ static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > return (struct slabobj_ext *)(obj_exts & ~OBJEXTS_FLAGS_MASK); > } > > -int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab); > - > #else /* CONFIG_SLAB_OBJ_EXT */ > > static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > @@ -571,6 +568,9 @@ static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > > #endif /* CONFIG_SLAB_OBJ_EXT */ > > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab); > + > static inline enum node_stat_item cache_vmstat_idx(struct kmem_cache *s) > { > return (s->flags & SLAB_RECLAIM_ACCOUNT) ? > diff --git a/mm/slub.c b/mm/slub.c > index cc11f3869cc6..f531c2d67238 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2075,10 +2075,10 @@ alloc_tagging_slab_free_hook(struct kmem_cache *s, struct slab *slab, void **p, > > #else /* CONFIG_SLAB_OBJ_EXT */ > > -static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab) > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab) > { > - return 0; > + return -1; > } > > static inline void free_slab_obj_exts(struct slab *slab)