From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745A6EB64D7 for ; Mon, 26 Jun 2023 08:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3FE28D0003; Mon, 26 Jun 2023 04:08:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0768D0001; Mon, 26 Jun 2023 04:08:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDF068D0003; Mon, 26 Jun 2023 04:08:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B1AE68D0001 for ; Mon, 26 Jun 2023 04:08:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 89FE416060F for ; Mon, 26 Jun 2023 08:08:59 +0000 (UTC) X-FDA: 80944173198.05.64D8578 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 3C2B14000B for ; Mon, 26 Jun 2023 08:08:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gLFlw+LX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687766937; a=rsa-sha256; cv=none; b=Bz9olm0xWKkovTKKJTQ5CTToWv/TrzMXj166NYhmYUmVmrst55rVyo6+qY/BilWWnettQq TOaol0IqByW9KJcHAtKa8WxqFkBuQig2IxvqnsKYfKqTSBOUYxpAnHWrYbb9fjQ6FV1Ijv wwsL9eT3S53BXMAfNvV683u165QPrgM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gLFlw+LX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687766937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KqoKmhBlTtHVnB8gm1nDpTAgK/1vm8kZHpYD3t91RRo=; b=ukJpXWHnZ88ajMuDukizJfpUvZU47QTDFe1i+oapKljDRwhZ2PieC0pKHC7ekjTdK0JdSn sZsgEXO3SyctYKHNPC7VkHEsZ8VZMeVosCUqJA8VTUVbdBLk4q/va0o/ysduTBC3qBbHfp 5H2sF/0qLnu0zVCRKU/2f1fwxEKG6Vw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687766936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KqoKmhBlTtHVnB8gm1nDpTAgK/1vm8kZHpYD3t91RRo=; b=gLFlw+LX0G4hQBmAxpHLwj7aDttq/L/MMBOK39Wyrspb816GRQidQUhjGrQYFKWuOn6IcH ugpk5ZQznUXVR9lv4290oZio0Me9kqe1+U0Ta7u5TYpA/fEofcX/z5gv3gYHHKoGYInVeO h7LuDehm0Pndu56kWcmbYZFLpdPlOfk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-hg6O_8KoO3yokenDv5Qy3g-1; Mon, 26 Jun 2023 04:08:54 -0400 X-MC-Unique: hg6O_8KoO3yokenDv5Qy3g-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-313c930ee0eso961617f8f.0 for ; Mon, 26 Jun 2023 01:08:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687766934; x=1690358934; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KqoKmhBlTtHVnB8gm1nDpTAgK/1vm8kZHpYD3t91RRo=; b=RDDVDWbsWv/n7vNaRBO+OoGhf+Ycds86qRpjzh0Li0Q7dNeGxlYRhaG4MDGQ+UMZyt SHTCCNMXuWhdcILLGniJKraqAZk0qtQ9EMg6nYCayVetarVWbZBAdMES39gSC2LE1Bqi MPNkBLg7Ktjhu+ygVrVcbn/6SF0YhKHMvddh/5lnj4InZsYvx+pMpuveDn4wVpBhqsVZ dUUgpRymGGhHLaZ+8mpTDkrlBbhQG52fjfaI92+wwZnJbiidlJZTuDQU2F8RG64brvGZ SxQX3pPj03vknPLjedtIAmgruJIY+eLVoZxive1mAFCl7vJPv9VrEdbE4488eGOFWZpe 9YWg== X-Gm-Message-State: AC+VfDwLfovkpmhQfaROaAQhJkBYG8+wpekxgMVYvBCy+H2F+vpFWQMf AaY7cZGW8b9KcN9B9iTW7Aeq6gADX8o9GgvZtR5U4AlKzwDAvyKmJBWQYUbTOjTHjw4OodU0Nld vbwDTHWp1IYs= X-Received: by 2002:a05:6000:184:b0:309:1532:8287 with SMTP id p4-20020a056000018400b0030915328287mr7714283wrx.19.1687766933840; Mon, 26 Jun 2023 01:08:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6vrW3QD+fALJOHKAeyTZOgWHyoDD3cvdBTB698WGYKApvEdp0JvIQl5yjuAql2P8EKvsrXig== X-Received: by 2002:a05:6000:184:b0:309:1532:8287 with SMTP id p4-20020a056000018400b0030915328287mr7714271wrx.19.1687766933528; Mon, 26 Jun 2023 01:08:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:7300:2ef6:6cd6:703c:e498? (p200300cbc74b73002ef66cd6703ce498.dip0.t-ipconnect.de. [2003:cb:c74b:7300:2ef6:6cd6:703c:e498]) by smtp.gmail.com with ESMTPSA id v10-20020a5d590a000000b002fda1b12a0bsm6643196wrd.2.2023.06.26.01.08.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 01:08:52 -0700 (PDT) Message-ID: Date: Mon, 26 Jun 2023 10:08:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 6/8] mm/gup: Retire follow_hugetlb_page() To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Lorenzo Stoakes , John Hubbard , Andrew Morton , Mike Rapoport , Yang Shi , Andrea Arcangeli , Vlastimil Babka , "Kirill A . Shutemov" , James Houghton , Matthew Wilcox , Mike Kravetz , Hugh Dickins , Jason Gunthorpe References: <20230623142936.268456-1-peterx@redhat.com> <20230623142936.268456-7-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230623142936.268456-7-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3C2B14000B X-Stat-Signature: yfjmri9dti16auqctgs4j64zbmjp5g7n X-HE-Tag: 1687766937-394433 X-HE-Meta: U2FsdGVkX18qCaBg0eQvHi1wD+7x+Y4rQcWeWoHqUAsJk/tnrGC7AsOEt9Max4mKtjXF0M4w1VBXLAvyZ6HLge89vSO91rA5ur3nGiy7dyssQ2LybL2FkIaL4o57cPb1Vhc4PT2HUmciub/CoGx3dsacV2N8ubzxd/FyPVna0q22XO8FjUDhDnRg3Um5nwpMv6n2P5N6E5QGPqc3fGqrmmq9XJS7CqPWBgGzAjMDQzlCWDomngWYkrrsXa3PXJ4CYPf8YFzfzOs8hLEyLa69bHXHSvEDD248F7CSs9c4784FyfZzn8BjBns9ghUYYCtoSHZvuncaeFRMM5jXREERr0vlDe67c8YF7JyZDv5pG13+jlKJmK51WTBN4ADTI4T0hK7o2n7iR9ggSceH44vstWXvHSe3SOC5lH07KbQowjd0TXh3Kz73Hk3/ODqro15qLKFW4QxdCsZJNpAAJ0xxWHoEyjJze9V99OcoamLKfl/Gutk0P95v+yLoiDWtsf0x6nX7KHkQp9U+IADaIzh16olAFB/aFYgziOfAH+9eVuStkzj6Jubpb1TZuNmpF1THgM/lNp3y0nlIkM8BcAsP6u2DlMSkw93z7MIuLCH7gqyeVdULnbDdCqkujrts0uXA6hbo41EZ0PfLAcu4FDK6zeaB2AQPoykIpdqrSIzqSpUlAqdAfJIowAXU8nJMz3NpW9SBIgkidWybqSClDFjzYGZQ1MMrCxGdtgb9eZV507K9Jp0eFLKmrJaqGq0tR5rpx6RXH79+aBPza8e7NCw9900h0hshXFIYROrcbMlL8fqSEOQcVi9YlqOFN9hes+VUXXg0Fl6tIPbs/bZf4Cm/sIHgEo9hpM79G5yGzDGRUivNqYAkpLgbn0DvUAQa/Xa+2NqvqlmrqntEsDOlC/9cHJNduqYriUZlW9thjmaHJU3cWQnCzAw18qTyj/T3i+MtctrRpMs1GaYvIkwEqoI SdMXQOO7 hRBj1oD36NmvOZOacCWyoEFqF6wkxwchhHdjEw3x9FqP8FsedXDfJM2bQeYWW9UgK8iLqCjr7nSN3ChngzGxf6EyF0M4m6im7ywkDH67duEvJM/xe9NQ/LNAYNKdbdZeKoxpNY4CtGtdqRjaJ3mgnKtI8BGfgqph38OJZb9ZB8hXPCq45jr99nFFm0AgbgH8NYCqjQE7Vu80ZrIS+nPGOkBc2tDEOE77YAbXfkFtq8bR9m5hQWcVFPYwVBSbdUXC2u1hfoG9RxneDsGyw7RRuPqS9tzDFqqRe9YqzkP28wXAGz7b6u36AUZRw8mLb933nvVoOZZlSz/i6HS5qf54lh3HKC2JHK8Jp69iuqn0rzH0ZCWGMgeLOk548ulJmzVJSKN60QD7KFA0Qqg1robSBLMpP+gcDJVnF48liwGyf9MWuQPY+BR0LFPozW39k5KWDmfgYBtkew8SXNoc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.06.23 16:29, Peter Xu wrote: > Now __get_user_pages() should be well prepared to handle thp completely, > as long as hugetlb gup requests even without the hugetlb's special path. > > Time to retire follow_hugetlb_page(). > > Tweak misc comments to reflect reality of follow_hugetlb_page()'s removal. > > Signed-off-by: Peter Xu > --- > fs/userfaultfd.c | 2 +- > include/linux/hugetlb.h | 12 --- > mm/gup.c | 19 ---- > mm/hugetlb.c | 224 ---------------------------------------- > 4 files changed, 1 insertion(+), 256 deletions(-) Acked-by: David Hildenbrand -- Cheers, David / dhildenb