From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02543CF11F8 for ; Thu, 10 Oct 2024 14:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96F436B0089; Thu, 10 Oct 2024 10:41:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91F7B6B008A; Thu, 10 Oct 2024 10:41:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BFFF6B008C; Thu, 10 Oct 2024 10:41:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5DCE16B0089 for ; Thu, 10 Oct 2024 10:41:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 82E2E1605B0 for ; Thu, 10 Oct 2024 14:41:24 +0000 (UTC) X-FDA: 82657955856.15.40D7789 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 8D657C0013 for ; Thu, 10 Oct 2024 14:41:24 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jwr1cG0F; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728571103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MOowB3q7CIF+A6/KCbyXfz87mc73ZhF1qnl/ziI0mUk=; b=KwisGtsY8Y1oqJYrn2UeMRZgwFApIW4lyktBV1G1962okSq+vm0mOL4pF8K8Eb5f/ih2N2 UJNYbcDux8sEn9VWSSqIgQWt3ZB+CC2adsgCV8hQGucYlb/4FFXtjCI4nvbXkmrBv0gcUw fp/rDdICqUM+sM+KcduA+pYxrj5S+Ag= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jwr1cG0F; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728571103; a=rsa-sha256; cv=none; b=R6U8vP+7PJMKpFFQsvo9+OcNLAnmY428ivGx0I337LUD1dNpCyQ+YSUBhXidOWABBC+H1R Hqa1t7p54nOPwvJibhkA4w+AkAkuuJg4sb0O27spTWPbSzAjORQQwhC1FBd+FGVwherD+n QX/vmnpZKTpjJHasAcoTpnhE904yH7w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728571285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MOowB3q7CIF+A6/KCbyXfz87mc73ZhF1qnl/ziI0mUk=; b=Jwr1cG0F9ae0BLy0brRMzujRH3aP2IHS57SxsQPo7GviyI+RKolBqOlJcy+fx4X9UAGAv2 n4NCbQKQccrVeTkWjj0DsBb+88zxO3Hsfb5Inm/U8K3KNmgSCy1z0VUyaZFdCR4lwLYeh3 Afn0ip4/tCVJnel28y5oG0ItpZfpEEs= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-4Aognp7TOAGr3lFdSnoSLg-1; Thu, 10 Oct 2024 10:41:23 -0400 X-MC-Unique: 4Aognp7TOAGr3lFdSnoSLg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5398b9176dcso1058967e87.2 for ; Thu, 10 Oct 2024 07:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728571282; x=1729176082; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MOowB3q7CIF+A6/KCbyXfz87mc73ZhF1qnl/ziI0mUk=; b=bcHavhvI6h5bv1lKimyZd/VDvgk2XtSKWPbR2GX888i7o+txCcI3bO2KaU/vS/FULl cQCrdEJL3guwqNX8SPqJbp+NoX2ug1Ay3AYwqAH/XdHNM+VBFfpIcItLR6NokVxmIpuU gj6Pf3pO7WxWWkTfO8CEzKPjps8+xD77piW/TAR9VX3sYvRXjkn/YKSkipqtrfziEm8e AvPrLrBm7gX05lp2O69CeQDBeSBUWaAsWsJ6xQ03yT4P1mebHRP3ZNM5uxrxyL2HiAL3 71sV7SZX844bkyOt8m7gQL9xcklNd+T1WhTYsy9Orw3R31IDJgoo9njr0shggBkMoCGd rnGA== X-Forwarded-Encrypted: i=1; AJvYcCWFI6q2N3TwLWEl4YUOZXlDYERF59K+T85Ub7EwAxH3xkNyPLVOVXUpRodDvt1VMXjg01cdLlC1Ng==@kvack.org X-Gm-Message-State: AOJu0YxulqijzDGNbAHYV8yExI6ZWtMHr1K+hpZlBWBP0pj5MbapYoM6 g9pAl1+V67LevZOpuTERWJAVoE/5k+qq6Rg5a3zkqQ0GOdJ9j1Mllqzc/fuAndB78AyuCDo6aGh r5QW4ZiEYFXu81NW0+heiRQ2SddXyoaru55A8zzUYNHMXjJHs X-Received: by 2002:a05:6512:1246:b0:530:e323:b1ca with SMTP id 2adb3069b0e04-539c9296efamr2976626e87.25.1728571282226; Thu, 10 Oct 2024 07:41:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGu/vP7xjBHKB+N9RnNGxZNsbWdBtRKlIYQls+T4f+5AiwYHs10/QcdhKNBKRdvaPmVSTm0TA== X-Received: by 2002:a05:6512:1246:b0:530:e323:b1ca with SMTP id 2adb3069b0e04-539c9296efamr2976591e87.25.1728571281773; Thu, 10 Oct 2024 07:41:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:9200:eb2e:74f9:6f5c:3040? (p200300cbc7429200eb2e74f96f5c3040.dip0.t-ipconnect.de. [2003:cb:c742:9200:eb2e:74f9:6f5c:3040]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6a8ac3sm1722637f8f.3.2024.10.10.07.41.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 07:41:21 -0700 (PDT) Message-ID: Date: Thu, 10 Oct 2024 16:41:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: huge_memory: add thp_vma_disabled() To: Kefeng Wang , Andrew Morton Cc: Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , linux-mm@kvack.org References: <20241010061024.1846220-1-wangkefeng.wang@huawei.com> <20241010061024.1846220-3-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241010061024.1846220-3-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8D657C0013 X-Stat-Signature: 55bjjkjosdj57uwrjeghiawq54ee7wtq X-Rspam-User: X-HE-Tag: 1728571284-966639 X-HE-Meta: U2FsdGVkX1/mw6iV/RVILFb3zPPwFkC2KCTxcmm2hsTTLG/2cwJGf9Ut+1Qc3b0sUNf4ayotN1rbqo4GXDQok+pDU1qNmRIAV6P0WOZ2JcPza5Bfz83ryN55avo7T6xV4rettYpajJn6UMqFqZp5MAgM8vQoKnXrS4+9KwDJPmKsXAw+JNKnIKQcO/S+Wwz/14bp7x0Xc3v5jhvFdaEvVMMIwsg6jWtG+VtU/MsdqmApGps3w7Otesmd9OWN2sFAJ+1WMPQE2m5QEg5Q05v3nDrKPJcJsd2d7QWAi18AwGCl4t/etiRdF8zmSgZjrKWERO3y8j422IrZPIkKwo4Vm86b9Yxq7YcUekhnUB2UUeffC/7j83d9zvSp/GYazc9FYfxycp/RGdK2WPsKXx+2IFLUvIpFJRfYHfw1H26sv6giJixx5QGifd3gYVHed4aK23wmJw9VvSfaDepCXRIJ4+VMyZkMT9KFHZzUUD7uYzHCsgwEg3GrokTJm2uYUG3ujnenvneLob83U/4bnLxO3OIPSSYLwLVhxlCXOiTqObA4SBV/1GFQq84sdxb04P0wPbOYYqkjmwXbvWW9NWz2y/Pt7QiGVUo8FePxDz47K9eypLwDTVeNHT/YLTr60bGMxDV4+bvU5Y9b6dLNIQueQEPsRKz2lCON6c/WKrUbbxvU5yj1FpIiKoPNIYAJaPUBkPd32WypFhrRn35q3DX3tdXgUITT26ZTew2Ro9QoDevAAau8NWySsVdLXPVin2xxRZvRI8OXncD0XuwNZmzpd2rxHeMevwQYf90ZXuludlVfL3Vhpi3YPxT88hLJbVDr20TeVP5JYt6Vms+6TbY8XVOAvLhveKh0p9JbEUCkRwY21wX1Ey2FiQAkYyYuN3AGHVHjIkwbFKP6V84KzBYlY4Q8lEq/zX69v6UJQHRoIJk+qFA6zeW14C95mKfSqBWgusZyRB9GFLSJl7Mv+xT za3SvUGY eNipViukd1kgGinJfpF2zGbIFDJXdjX8ZAvKI+dByqrzyH3DtMSijZ6QGhII9aUipvEIHtQFloDcyMn2gEwOxD2Zsdw9lsZbpSWEkbuyrHkq4N9YEScoNVNCXMIWdnoJo5oljemEgw2Xh5tvwFhoGYjeFiBdLfO4OApLksQMaruMTIUxG72wLG0A9ShgxqRaeHLHD1WPNmIYCbQT/1AFD6+bk9jxfrsRaeTe7c0T9S9hZ0unzOSWLUUhY70AcqPIA9oxOrWIup1g8cVr2piklyi+I3PfxT0lxNullJFWycL9mj81bTdYsFVjk66/9XyZl6WUQa3mGam/piTSPremSf0DGwJV5AUHziROQM27IFlN3VSkoCEM4bzG3SkAc/UOb7ut6AYvackg2TZT1lCU92kBvPBTjR0j7R7ydizceESq3fGd6JeVo9adPWHzAF23/+IkV5V4nhAFPH1PyrcN+NmFovg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.10.24 08:10, Kefeng Wang wrote: > Add thp_vma_disabled() helper to shared by shmem_allowable_huge_orders() > and __thp_vma_allowable_orders(). > > Signed-off-by: Kefeng Wang > --- > include/linux/huge_mm.h | 19 +++++++++++++++++++ > mm/huge_memory.c | 13 +------------ > mm/shmem.c | 7 +------ > 3 files changed, 21 insertions(+), 18 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 795df660efa5..d77891332b35 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -309,6 +309,25 @@ struct thpsize { > (transparent_hugepage_flags & \ > (1< > +static inline bool thp_vma_disabled(struct vm_area_struct *vma, > + unsigned long vm_flags) > +{ > I might need a patch like this for an independent fix, and the more I look at this the more I hate the separate vm_flags and the optional vma argument. Let me try to improve things. Long term we can get rid of the vm_flags, it just needs some madvise() massaging. -- Cheers, David / dhildenb